Ubuntu
linux package

[19.10 FEAT] Crypto AP DD: handle reconfiguration events

Bug #1835554 reported by bugproxy
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu on IBM z Systems
Fix Released
High
Frank Heimes
linux (Ubuntu)
Fix Released
Undecided
Skipper Bug Screeners

Bug Description

Handle concurrent additions or removals of AP facilities.
Available with kernel 5.1
Git Commit: 16222cfb96

bugproxy (bugproxy)
tags: added: architecture-s39064 bugnameltc-178733 severity-high targetmilestone-inin1910
Changed in ubuntu:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
affects: ubuntu → linux (Ubuntu)
Revision history for this message
Frank Heimes (fheimes) wrote :

Setting this LP ticket to Incomplete until planned target kernel 5.2 has landed in Eoan (we are going to skip 5.1).

Changed in linux (Ubuntu):
status: New → Incomplete
Changed in ubuntu-z-systems:
status: New → Incomplete
importance: Undecided → High
assignee: nobody → Frank Heimes (frank-heimes)
Revision history for this message
Frank Heimes (fheimes) wrote :

$ rmadison --arch=s390x linux-generic | grep eoan-proposed
 linux-generic | 5.2.0.8.9 | eoan-proposed | s390x
$ git tag --contains 16222cfb96
Ubuntu-5.2.0-8.9
v5.2
$ git show 16222cfb96
commit 16222cfb96b02a4a3e38e52012f2a6304850c3c9
Author: Harald Freudenberger <email address hidden>
Date: Wed Apr 3 13:18:22 2019 +0200

    s390/zcrypt: fix possible deadlock situation on ap queue remove

    With commit 01396a374c3d ("s390/zcrypt: revisit ap device remove
    procedure") the ap queue remove is now a two stage process. However,
    a del_timer_sync() call may trigger the timer function which may
    try to lock the very same spinlock as is held by the function
    just initiating the del_timer_sync() call. This could end up in
    a deadlock situation. Very unlikely but possible as you need to
    remove an ap queue at the exact sime time when a timeout of a
    request occurs.

    Signed-off-by: Harald Freudenberger <email address hidden>
    Reported-by: Pierre Morel <email address hidden>
    Fixes: commit 01396a374c3d ("s390/zcrypt: revisit ap device remove procedure")
    Signed-off-by: Martin Schwidefsky <email address hidden>

With that changing status to Fix Committed.

Changed in linux (Ubuntu):
status: Incomplete → Fix Committed
Changed in ubuntu-z-systems:
status: Incomplete → Fix Committed
information type: Private → Public
Revision history for this message
Frank Heimes (fheimes) wrote :

Since kernel 5.2 eventually landed in eoan's release pocket:
  linux-generic | 5.2.0.8.9 | eoan | s390
I'm changing this LP ticket to Fix Released.

Changed in linux (Ubuntu):
status: Fix Committed → Fix Released
Changed in ubuntu-z-systems:
status: Fix Committed → Fix Released
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2019-07-16 06:35 EDT-------
IBM bugzilla status -> closed, Fix Released with Eoan

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.