-Version 1.16

- ${CMAKE_CURRENT_LIST_DIR}/src/checks/level0/qstring-ref.cpp

-add_clazy_test(qstring-ref)

- qstringref.cpp

- - [qstring-ref](docs/checks/README-qstring-ref.md) (fix-missing-qstringref)

-`clazy-overloaded-signal,clazy-connect-by-name,clazy-connect-non-signal,clazy-qstring-comparison-to-implicit-char,clazy-wrong-qevent-cast,clazy-lambda-in-connect,clazy-lambda-unique-connection,clazy-qdatetime-utc,clazy-qgetenv,clazy-qstring-insensitive-allocation,clazy-fully-qualified-moc-types,clazy-unused-non-trivial-variable,clazy-connect-not-normalized,clazy-mutable-container-key,clazy-qenums,clazy-qmap-with-pointer-key,clazy-qstring-ref,clazy-strict-iterators,clazy-writing-to-temporary,clazy-container-anti-pattern,clazy-qcolor-from-literal,clazy-qfileinfo-exists,clazy-qstring-arg,clazy-empty-qstringliteral,clazy-qt-macros,clazy-temporary-iterator,clazy-wrong-qglobalstatic,clazy-lowercase-qml-type-name,clazy-no-module-include,clazy-use-static-qregularexpression`

- "name": "qstring-ref",

- "class_name": "StringRefCandidates",

- "level": 0,

- "categories": ["performance", "qstring"],

- "fixits": [

- {

- "name": "missing-qstringref"

- }

- ],

- "visits_stmts": true,

- "can_ignore_includes": true

- },

- {

-# qstring-ref

-

-Finds places where `QString::fooRef()` should be used instead of `QString::foo()`, to avoid temporary heap allocations.

-

-#### Example

-

- str.mid(5).toInt(ok) // BAD

-

- str.midRef(5).toInt(ok) // GOOD

-

-Where `mid` can be any of: `mid`, `left`, `right`.

-And `toInt()` can be any of: `compare`, `contains`, `count`, `startsWith`, `endsWith`, `indexOf`, `isEmpty`, `isNull`, `lastIndexOf`, `length`, `size`, `to*`, `trimmed`

-

-#### FixIts

-

-This check supports a fixit to rewrite your code. See the README.md on how to enable it.

- ${CMAKE_CURRENT_LIST_DIR}/docs/checks/README-qstring-ref.md

-#include "checks/level0/qstring-ref.h"

- registerCheck(check<StringRefCandidates>("qstring-ref", CheckLevel0, RegisteredCheck::Option_VisitsStmts, true));

- registerFixIt(1, "fix-missing-qstringref", "qstring-ref");

-/*

- SPDX-FileCopyrightText: 2015 Sergio Martins <smartins@kde.org>

-

- SPDX-License-Identifier: LGPL-2.0-or-later

-*/

-

-#include "qstring-ref.h"

-#include "ClazyContext.h"

-#include "FixItUtils.h"

-#include "HierarchyUtils.h"

-#include "StringUtils.h"

-#include "Utils.h"

-#include "clazy_stl.h"

-

-#include <clang/AST/DeclCXX.h>

-#include <clang/AST/Expr.h>

-#include <clang/AST/ExprCXX.h>

-#include <clang/AST/Stmt.h>

-#include <clang/Basic/IdentifierTable.h>

-#include <clang/Basic/LLVM.h>

-#include <clang/Basic/SourceLocation.h>

-#include <clang/Lex/Lexer.h>

-#include <llvm/ADT/SmallVector.h>

-#include <llvm/ADT/StringRef.h>

-#include <llvm/Support/Casting.h>

-

-#include <vector>

-

-using namespace clang;

-

-static bool isInterestingFirstMethod(CXXMethodDecl *method)

-{

- if (!method || clazy::name(method->getParent()) != "QString") {

- return false;

- }

-

- static const std::vector<StringRef> list{"left", "mid", "right"};

- return clazy::contains(list, clazy::name(method));

-}

-

-static bool isInterestingSecondMethod(CXXMethodDecl *method, const clang::LangOptions &lo)

-{

- if (!method || clazy::name(method->getParent()) != "QString") {

- return false;

- }

-

- static const std::vector<StringRef> list{

- "compare", "contains", "count", "startsWith", "endsWith", "indexOf", "isEmpty", "isNull", "lastIndexOf", "length",

- "size", "toDouble", "toFloat", "toInt", "toUInt", "toULong", "toULongLong", "toUShort", "toUcs4",

- };

-

- if (!clazy::contains(list, clazy::name(method))) {

- return false;

- }

-

- return !clazy::anyArgIsOfAnySimpleType(method, {"QRegExp", "QRegularExpression"}, lo);

-}

-

-static bool isMethodReceivingQStringRef(CXXMethodDecl *method)

-{

- if (!method || clazy::name(method->getParent()) != "QString") {

- return false;

- }

-

- static const std::vector<StringRef> list{"append", "compare", "count", "indexOf", "endsWith", "lastIndexOf", "localAwareCompare", "startsWidth"};

-

- if (clazy::contains(list, clazy::name(method))) {

- return true;

- }

-

- if (method->getOverloadedOperator() == OO_PlusEqual) { // operator+=

- return true;

- }

-

- return false;

-}

-

-void StringRefCandidates::VisitStmt(clang::Stmt *stmt)

-{

- // Here we look for code like str.firstMethod().secondMethod(), where firstMethod() is for example mid() and secondMethod is for example, toInt()

-

- auto *call = dyn_cast<CallExpr>(stmt);

- if (!call || processCase1(dyn_cast<CXXMemberCallExpr>(call))) {

- return;

- }

-

- processCase2(call);

-}

-

-static bool containsChild(Stmt *s, Stmt *target)

-{

- if (!s) {

- return false;

- }

-

- if (s == target) {

- return true;

- }

-

- if (auto *mte = dyn_cast<MaterializeTemporaryExpr>(s)) {

- return containsChild(mte->getSubExpr(), target);

- } else if (auto *ice = dyn_cast<ImplicitCastExpr>(s)) {

- return containsChild(ice->getSubExpr(), target);

- } else if (auto *bte = dyn_cast<CXXBindTemporaryExpr>(s)) {

- return containsChild(bte->getSubExpr(), target);

- }

-

- return false;

-}

-

-bool StringRefCandidates::isConvertedToSomethingElse(clang::Stmt *s) const

-{

- // While passing a QString to the QVariant ctor works fine, passing QStringRef doesn't

- // So let's not warn when QStrings are cast to something else.

- if (!s) {

- return false;

- }

-

- auto *constr = clazy::getFirstParentOfType<CXXConstructExpr>(m_context->parentMap, s);

- if (!constr || constr->getNumArgs() == 0) {

- return false;

- }

-

- if (containsChild(constr->getArg(0), s)) {

- CXXConstructorDecl *ctor = constr->getConstructor();

- CXXRecordDecl *record = ctor ? ctor->getParent() : nullptr;

- return record ? record->getQualifiedNameAsString() != "QString" : false;

- }

-

- return false;

-}

-

-// Catches cases like: int i = s.mid(1, 1).toInt()

-bool StringRefCandidates::processCase1(CXXMemberCallExpr *memberCall)

-{

- if (!memberCall) {

- return false;

- }

-

- // In the AST secondMethod() is parent of firstMethod() call, and will be visited first (because at runtime firstMethod() is resolved first().

- // So check for interesting second method first

- CXXMethodDecl *method = memberCall->getMethodDecl();

- if (!isInterestingSecondMethod(method, lo())) {

- return false;

- }

-

- std::vector<CallExpr *> callExprs = Utils::callListForChain(memberCall);

- if (callExprs.size() < 2) {

- return false;

- }

-

- // The list now contains {secondMethod(), firstMethod() }

- auto *firstMemberCall = dyn_cast<CXXMemberCallExpr>(callExprs.at(1));

-

- if (!firstMemberCall || !isInterestingFirstMethod(firstMemberCall->getMethodDecl())) {

- return false;

- }

-

- if (isConvertedToSomethingElse(memberCall)) {

- return false;

- }

-

- const std::string firstMethodName = firstMemberCall->getMethodDecl()->getNameAsString();

- const std::vector<FixItHint> fixits = fixit(firstMemberCall);

-

- emitWarning(firstMemberCall->getEndLoc(), "Use " + firstMethodName + "Ref() instead", fixits);

- return true;

-}

-

-// Catches cases like: s.append(s2.mid(1, 1));

-bool StringRefCandidates::processCase2(CallExpr *call)

-{

- auto *memberCall = dyn_cast<CXXMemberCallExpr>(call);

- auto *operatorCall = memberCall ? nullptr : dyn_cast<CXXOperatorCallExpr>(call);

-

- CXXMethodDecl *method = nullptr;

- if (memberCall) {

- method = memberCall->getMethodDecl();

- } else if (operatorCall && operatorCall->getCalleeDecl()) {

- Decl *decl = operatorCall->getCalleeDecl();

- method = dyn_cast<CXXMethodDecl>(decl);

- }

-

- if (!isMethodReceivingQStringRef(method)) {

- return false;

- }

-

- Expr *firstArgument = call->getNumArgs() > 0 ? call->getArg(0) : nullptr;

- MaterializeTemporaryExpr *temp = firstArgument ? dyn_cast<MaterializeTemporaryExpr>(firstArgument) : nullptr;

- if (!temp) {

- Expr *secondArgument = call->getNumArgs() > 1 ? call->getArg(1) : nullptr;

- temp = secondArgument ? dyn_cast<MaterializeTemporaryExpr>(secondArgument) : nullptr;

- if (!temp) { // For the CXXOperatorCallExpr it's in the second argument

- return false;

- }

- }

-

- auto *innerCall = clazy::getFirstChildOfType2<CallExpr>(temp);

- auto *innerMemberCall = innerCall ? dyn_cast<CXXMemberCallExpr>(innerCall) : nullptr;

- if (!innerMemberCall) {

- return false;

- }

-

- CXXMethodDecl *innerMethod = innerMemberCall->getMethodDecl();

- if (!isInterestingFirstMethod(innerMethod)) {

- return false;

- }

-

- const std::vector<FixItHint> fixits = fixit(innerMemberCall);

-

- emitWarning(call->getSourceRange().getBegin(), "Use " + innerMethod->getNameAsString() + "Ref() instead", fixits);

- return true;

-}

-

-std::vector<FixItHint> StringRefCandidates::fixit(CXXMemberCallExpr *call)

-{

- auto *memberExpr = clazy::getFirstChildOfType<MemberExpr>(call);

- if (!memberExpr) {

- return {};

- }

-

- auto insertionLoc = Lexer::getLocForEndOfToken(memberExpr->getEndLoc(), 0, sm(), lo());

- if (!insertionLoc.isValid()) {

- return {};

- }

-

- std::vector<FixItHint> fixits;

- fixits.push_back(clazy::createInsertion(insertionLoc, "Ref"));

- return fixits;

-}

-/*

- SPDX-FileCopyrightText: 2015 Sergio Martins <smartins@kde.org>

-

- SPDX-License-Identifier: LGPL-2.0-or-later

-*/

-

-#ifndef QSTRING_REF_H

-#define QSTRING_REF_H

-

-#include "checkbase.h"

-

-#include <clang/Basic/Diagnostic.h>

-#include <vector>

-

-namespace clang

-{

-class CallExpr;

-class CXXMemberCallExpr;

-}

-

-/**

- * Finds places where the QString::fooRef() should be used instead QString::foo(), to save allocations

- *

- * See README-qstringref for more info.

- */

-class StringRefCandidates : public CheckBase

-{

-public:

- using CheckBase::CheckBase;

- void VisitStmt(clang::Stmt *stmt) override;

-

-private:

- bool processCase1(clang::CXXMemberCallExpr *);

- bool processCase2(clang::CallExpr *call);

- bool isConvertedToSomethingElse(clang::Stmt *s) const;

-

- std::vector<clang::CallExpr *> m_alreadyProcessedChainedCalls;

- std::vector<clang::FixItHint> fixit(clang::CXXMemberCallExpr *);

-};

-

-#endif

-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-3arg-lambda, connect-by-name, connect-non-signal, connect-not-normalized, const-signal-or-slot, container-anti-pattern, detaching-temporary, empty-qstringliteral, foreach, fully-qualified-moc-types, incorrect-emit, inefficient-qlist-soft, install-event-filter, lambda-in-connect, lambda-unique-connection, mutable-container-key, non-pod-global-static, overridden-signal, post-event, qcolor-from-literal, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qhash-namespace, qlatin1string-non-ascii, qmap-with-pointer-key, qproperty-without-notify, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, skipped-base-method, strict-iterators, temporary-iterator, unused-non-trivial-variable, virtual-signal, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-3arg-lambda, connect-by-name, connect-non-signal, connect-not-normalized, const-signal-or-slot, container-anti-pattern, detaching-temporary, empty-qstringliteral, foreach, fully-qualified-moc-types, incorrect-emit, inefficient-qlist-soft, install-event-filter, lambda-in-connect, lambda-unique-connection, mutable-container-key, non-pod-global-static, overridden-signal, post-event, qcolor-from-literal, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qhash-namespace, qlatin1string-non-ascii, qmap-with-pointer-key, qproperty-without-notify, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, skipped-base-method, strict-iterators, temporary-iterator, unused-non-trivial-variable, virtual-signal, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: auto-unexpected-qstringbuilder, base-class-event, child-event-qobject-cast, connect-3arg-lambda, connect-by-name, connect-non-signal, connect-not-normalized, const-signal-or-slot, container-anti-pattern, copyable-polymorphic, ctor-missing-parent-argument, detaching-temporary, empty-qstringliteral, foreach, fully-qualified-moc-types, function-args-by-ref, function-args-by-value, global-const-char-pointer, implicit-casts, incorrect-emit, inefficient-qlist-soft, install-event-filter, lambda-in-connect, lambda-unique-connection, missing-qobject-macro, missing-typeinfo, mutable-container-key, non-pod-global-static, old-style-connect, overridden-signal, post-event, qcolor-from-literal, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qhash-namespace, qlatin1string-non-ascii, qmap-with-pointer-key, qproperty-without-notify, qstring-allocations, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, returning-void-expression, rule-of-three, rule-of-two-soft, skipped-base-method, static-pmf, strict-iterators, temporary-iterator, unused-non-trivial-variable, virtual-call-ctor, virtual-signal, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: connect-by-name, connect-non-signal, connect-not-normalized, container-anti-pattern, empty-qstringliteral, fully-qualified-moc-types, lambda-in-connect, lambda-unique-connection, mutable-container-key, qcolor-from-literal, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, strict-iterators, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-3arg-lambda, connect-by-name, connect-non-signal, connect-not-normalized, const-signal-or-slot, container-anti-pattern, detaching-temporary, empty-qstringliteral, foreach, fully-qualified-moc-types, incorrect-emit, inefficient-qlist-soft, install-event-filter, lambda-in-connect, lambda-unique-connection, mutable-container-key, non-pod-global-static, overridden-signal, post-event, qcolor-from-literal, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qhash-namespace, qlatin1string-non-ascii, qmap-with-pointer-key, qproperty-without-notify, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, skipped-base-method, strict-iterators, temporary-iterator, unused-non-trivial-variable, virtual-signal, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: connect-by-name, connect-non-signal, connect-not-normalized, container-anti-pattern, empty-qstringliteral, fully-qualified-moc-types, lambda-in-connect, lambda-unique-connection, mutable-container-key, qcolor-from-literal, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, reserve-candidates, strict-iterators, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: connect-by-name, connect-non-signal, connect-not-normalized, container-anti-pattern, empty-qstringliteral, fully-qualified-moc-types, lambda-in-connect, lambda-unique-connection, mutable-container-key, qcolor-from-literal, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, strict-iterators, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: connect-by-name, connect-non-signal, connect-not-normalized, container-anti-pattern, empty-qstringliteral, foreach, fully-qualified-moc-types, implicit-casts, lambda-in-connect, lambda-unique-connection, mutable-container-key, qcolor-from-literal, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, strict-iterators, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-3arg-lambda, connect-by-name, connect-non-signal, connect-not-normalized, const-signal-or-slot, container-anti-pattern, detaching-temporary, empty-qstringliteral, foreach, fully-qualified-moc-types, incorrect-emit, inefficient-qlist-soft, install-event-filter, lambda-in-connect, lambda-unique-connection, mutable-container-key, non-pod-global-static, overridden-signal, post-event, qcolor-from-literal, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qhash-namespace, qlatin1string-non-ascii, qmap-with-pointer-key, qproperty-without-notify, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, skipped-base-method, strict-iterators, temporary-iterator, unused-non-trivial-variable, virtual-signal, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-3arg-lambda, connect-by-name, connect-non-signal, connect-not-normalized, const-signal-or-slot, container-anti-pattern, detaching-temporary, empty-qstringliteral, foreach, fully-qualified-moc-types, incorrect-emit, inefficient-qlist-soft, install-event-filter, lambda-in-connect, lambda-unique-connection, mutable-container-key, non-pod-global-static, overridden-signal, post-event, qcolor-from-literal, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qhash-namespace, qlatin1string-non-ascii, qmap-with-pointer-key, qproperty-without-notify, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, skipped-base-method, strict-iterators, temporary-iterator, unused-non-trivial-variable, virtual-signal, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: connect-by-name, connect-non-signal, connect-not-normalized, container-anti-pattern, empty-qstringliteral, fully-qualified-moc-types, lambda-in-connect, lambda-unique-connection, mutable-container-key, qcolor-from-literal, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, reserve-candidates, strict-iterators, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: connect-by-name, connect-non-signal, connect-not-normalized, container-anti-pattern, empty-qstringliteral, fully-qualified-moc-types, implicit-casts, lambda-in-connect, lambda-unique-connection, mutable-container-key, qcolor-from-literal, qdatetime-utc, qenums, qfileinfo-exists, qgetenv, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, reserve-candidates, strict-iterators, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

- - qstring-ref (fix-missing-qstringref)

-Requested checks: connect-by-name, connect-non-signal, connect-not-normalized, container-anti-pattern, empty-qstringliteral, fully-qualified-moc-types, lambda-in-connect, lambda-unique-connection, mutable-container-key, qcolor-from-literal, qdatetime-utc, qfileinfo-exists, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, strict-iterators, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-3arg-lambda, connect-by-name, connect-non-signal, connect-not-normalized, const-signal-or-slot, container-anti-pattern, detaching-temporary, empty-qstringliteral, foreach, fully-qualified-moc-types, incorrect-emit, inefficient-qlist-soft, install-event-filter, lambda-in-connect, lambda-unique-connection, mutable-container-key, non-pod-global-static, overridden-signal, post-event, qcolor-from-literal, qdatetime-utc, qdeleteall, qenums, qfileinfo-exists, qgetenv, qhash-namespace, qlatin1string-non-ascii, qmap-with-pointer-key, qproperty-without-notify, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, skipped-base-method, strict-iterators, temporary-iterator, unused-non-trivial-variable, virtual-signal, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: connect-by-name, connect-non-signal, connect-not-normalized, container-anti-pattern, empty-qstringliteral, fully-qualified-moc-types, lambda-in-connect, lambda-unique-connection, mutable-container-key, qcolor-from-literal, qdatetime-utc, qfileinfo-exists, qmap-with-pointer-key, qstring-arg, qstring-insensitive-allocation, qstring-ref, qt-macros, qvariant-template-instantiation, strict-iterators, temporary-iterator, unused-non-trivial-variable, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-Requested checks: auto-unexpected-qstringbuilder, child-event-qobject-cast, connect-3arg-lambda, connect-by-name, connect-non-signal, connect-not-normalized, const-signal-or-slot, container-anti-pattern, detaching-temporary, empty-qstringliteral, foreach, fully-qualified-moc-types, incorrect-emit, inefficient-qlist-soft, install-event-filter, lambda-in-connect, lambda-unique-connection, mutable-container-key, non-pod-global-static, overridden-signal, post-event, qcolor-from-literal, qdatetime-utc, qdeleteall, qfileinfo-exists, qgetenv, qhash-namespace, qlatin1string-non-ascii, qmap-with-pointer-key, qproperty-without-notify, qstring-arg, qstring-insensitive-allocation, qstring-left, qstring-ref, qt-macros, qvariant-template-instantiation, range-loop, returning-data-from-temporary, rule-of-two-soft, skipped-base-method, strict-iterators, temporary-iterator, unused-non-trivial-variable, virtual-signal, writing-to-temporary, wrong-qevent-cast, wrong-qglobalstatic

-#include <QtCore/QString>

-#include <QtCore/QObject>

-#include <QtCore/QVariant>

-

-void test()

-{

- QString line;

- QObject o;

- o.setProperty("size", line.mid(7).trimmed()); // OK

- QString attributes = line.mid(13).trimmed(); // OK

-

- QString comment;

- if (!comment.trimmed().isEmpty()) { // OK

- }

-}

-{

- "tests": [

- {

- "filename": "main.cpp",

- "qt_major_versions": [5]

- },

- {

- "filename": "bug376737.cpp",

- "qt_major_versions": [5]

- }

- ]

-}

-#include <QtCore/QString>

-#include <QtCore/QRegExp>

-#include <QtCore/QStringList>

-void test()

-{

- bool ok = false;

- QString s;

- s.mid(1, 1).toInt(&ok); // Warning

- s.mid(1, 1); // OK

- s.toInt(&ok); // OK

- s.midRef(1, 1).toInt(&ok); // OK

- s.mid(s.lastIndexOf(QLatin1Char('#')) + 1).toUpper(); // OK

- s.mid(s.lastIndexOf(QLatin1Char('#')) + 1).trimmed(); // Warning

- const QRegExp r;

- QRegExp r2;

- s.mid(1, 1).indexOf(r); // OK

- s.mid(1, 1).indexOf(r2); // OK

- QString s2;

- s.append(s2.mid(1,1)); // Warning

- s.count(s2.left(1)); // Warning

- QStringList list;

- list.append(s2.mid(1,1)); // OK

- s += s2.mid(1,1); // Warning

- int start,end;

- int m = s.mid(start + 1, end - start - 1).toUInt(&ok); // Warning

-}

-

-QString i18n(const QString &) { return {}; }

-

-void test2()

-{

- QString s;

- s.append(i18n(s.mid(1, 1))); // OK

-}

-qstring-ref/main.cpp:8:15: warning: Use midRef() instead [-Wclazy-qstring-ref]

-qstring-ref/main.cpp:19:5: warning: Use midRef() instead [-Wclazy-qstring-ref]

-qstring-ref/main.cpp:20:5: warning: Use leftRef() instead [-Wclazy-qstring-ref]

-qstring-ref/main.cpp:23:5: warning: Use midRef() instead [-Wclazy-qstring-ref]

-qstring-ref/main.cpp:25:45: warning: Use midRef() instead [-Wclazy-qstring-ref]