summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Enable more warnings on cmake buildPekka Vuorela2025-11-061-0/+3
| | | | | | | | | Maybe rough by explicitly doing compiler flags but it's a start. Change-Id: Ic7d28908fa8a1a6b5d6825adccb2726d1caed990 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi>
* Remove obsolete translations and adjust the setupPekka Vuorela2025-11-0189-16774/+593
| | | | | | | | | | | | | | | | | | | | | | Practically not touched since initial commit. There is no QTranslator used in the whole repository so they shouldn't be much of help either. Library's .ts file contain lot of content coming from examples or deleted files. Translation are more or less empty except for some (mostly obsolete) German translations and a couple arabic words. Using strange names for translation files. The problems here are endless. Just removed the majority of the .ts files as crap. Kept -de and en_US as some basis for later adding these back, hoping that the -de as best translated earlier would have kept something but even that was basically nothing. Executed "lupdate -no-obsolete *.pro" to at least update the .ts files to match the current sources. Change-Id: I11e5fe8c84d1e17ab8e4fcf158594815261acfe0 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Clean up QMailPluginLoaderPekka Vuorela2025-11-013-31/+18
| | | | | | | | | | | | | | | | | Different parts were calling the ctor parameter directory, path or identifier. Let's just call it consistently subdir as that's how it's used. Removed also LOAD_DEBUG_VERSION leftover which seemed like some win32 thing, most of that already gone in commit 70702bfb9c3f0efec. We should probably also define a specific directory where the plugins should be placed instead of the generic libraries and qt plugins, but that's for a separate commit. Change-Id: I12b6ac3129f7c3c5465d51845323c1b03821daa5 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Adjust messageserver naming versionsPekka Vuorela2025-11-0111-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | On Qt6 it's strange to have messageserver5. Could have bumped the binary there to '6' but maybe we don't really need to highlight the qt version that much. The '5's were added to allow parallel installability but that really matters more on libraries etc rather than the server. We don't want parallel installed daemons fighting who gets autostarted first. Also on credential side it shouldn't matter which was the Qt version. Switching to newer version should still be about the same service. In practice don't think the names matter too much, and auth success is ignored so think it should be ok just changing the naming. Removed the '5's from examples too. No need there. Left the .pro file binary as it was as that side now mostly serves the Qt5 builds where we wouldn't benefit much from changing the binary name. Change-Id: Ie4a843c944caa73b080e3610baee4842500f029b Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Avoid qFatal in imap clientPekka Vuorela2025-11-015-18/+10
| | | | | | | | | | | Nicer if plugins don't try to make the whole messagingserver to exit. Removed also a couple qtopia references, an if() check that's guaranteed to succeed and did some more simplifications on servicehandler. Change-Id: Ibf98d57d86cd4f183f40d71b712ca1539f17b755 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Simplify messageserver failure reportingPekka Vuorela2025-10-302-75/+44
| | | | | | | | | | The same thing for reporting account source failures was repeating again and again, including (in theory) translated strings. Change-Id: Ief4b40d8b1bbf84311bfe3ea398b856dbb7c344d Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Fix some more compiler warningsPekka Vuorela2025-10-305-52/+26
| | | | | | | | | | | | | | | Disclaimer: didn't actually test the example as those are not in good shape, but the migration to non-deprecated API should be straightforward enough: mostly question() having default yes/no, and warning() having ok button is enough to skip explicit button declarations. For minor change not having now "no" as option when there is no question in verifyAccount(). checkMailConflict() removed as unused. Change-Id: I15067e1222264a685ba8c83c50e6ae06d4c51c38 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi>
* Avoid translation on sqlstorage initStore()Pekka Vuorela2025-10-304-5/+5
| | | | | | | | | | | | This has been ok since the translations haven't been used but regardless of that the language might change at any point and we shouldn't store the first used translation into sql. Better let the client app handle that. Change-Id: Ifd919b853c51e704ac1de07787ef886db982c527 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Clean up some QList usage on qmailmessageheaderfieldPekka Vuorela2025-10-301-21/+23
| | | | | | | | | | | | | | | | These mostly should have worked but cleaning up to avoid suspicion and enhance readability. QMailMessageHeaderPrivate::remove() was pointlessly first getting matches and afterwards removing them. QMailMessageHeaderFieldPrivate::setParameter() was annoying to follow with generic names 'it' and 'end' used outside a loop. In theory the end iterator could be considered invalidated after item removals. But we don't even need a separately stored end iterator. Change-Id: I7192d8223ca9b50b877d54c9c6b45f9b35a007b3 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Avoid compiler warnings on implicitly defined operators etcPekka Vuorela2025-10-292-1/+18
| | | | | | | Change-Id: Iae14dd91c21d1351a6935bbd96e7bd955eef9d3f Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi>
* Simplify helper function, avoiding non-const reference parameterPekka Vuorela2025-10-291-9/+12
| | | | | | | Change-Id: I2ec19175bce6df5ed78d7e5783b30a9d2a67fb6e Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Use understandable types and names for transfer statesPekka Vuorela2025-10-296-52/+67
| | | | | | | | | | | | | | Pair of pair of etc is hard to follow. Use actual type for containing Imap/pop transfer states. Smtp was better with simpler data but even there the naming was confusingly singular. The m_ naming is maybe inconsistent within classes but let's just gradually move consistently that way. Change-Id: Iaeb156d894ebadabe7f89a143c51aff9750098a1 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi>
* Remove QPrivateImplementationPekka Vuorela2025-10-2913-924/+0
| | | | | | | | | Everything is now migrated to common Qt ways. Change-Id: Ic310067bc6ed46743bfcf6c5d667cc65ab6893e3 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Pimplify rest of QMailMessage classesPekka Vuorela2025-10-284-110/+164
| | | | | | | | | | | | | | | | | | | | | | These seem like the real reason why QPrivate existed in this repository. QSharedDataPointer<BasePrivate> holding an instance of DerivedPrivate would by default clone the instance with just the base class type, and everything breaking apart badly. Now instead of having all this QPrivate infrastructure for one private class that gets inherited twice, doing here a small trick used e.g. on qtbase QTimezone. The cloning now done with a virtual method that ensures the proper subtype gets copied. Could be considered is the COW really even needed for the whole QMailMessage and would simpler basic private data be enough here. The contained data is shareable and the copies shouldn't thus cost that much. Change-Id: I845b66a85d8459d7f91cf138133cb8197ee72f70 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Use conventional qt pimplification on QMailMessageMetaDataPekka Vuorela2025-10-284-75/+87
| | | | | | | Change-Id: I934e756c072b55ec9eca85e76a7eb80d458e12ad Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Remove non-virtual private method overridePekka Vuorela2025-10-282-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | There are quite a lot of these indicativeSize() implementations on public and private side. Making one easily confused. In this case there's basic implementation in QMailMessagePartContainerPrivate base class of QMailMessagePrivate, and then a version doing +1 for header in both non-virtual QMailMessagePrivate method and the public QMailMessage method. I'm guessing this was maybe implementation side confusion whether to do the addition in public method or the private one, ending up both and some vagueness which private method gets really called (should be the QMailMessagePrivate and not the base class as partContainerImpl() returns a qmailmessageprivate pointer, heh). IndicativeSize not having a precise meaning it probably doesn't matter too much but good to get rid of a bit of this mess. Change-Id: I8f8ce6ee459fc98ce56e321a71ae849a65055f5c Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Polish QMailMessage classes, and something small elsewherePekka Vuorela2025-10-2718-142/+121
| | | | | | | | | | | | | | | | | | | | - Made setBody() virtual and avoid dynamic_cast to check which type of instance was used - Cleaned up some cosmetic details, fixed typos etc - Restricted some variable scopes - Renamed some global constants with UpperCase name - Commented out some dead code - Use nullptr instead of NULL or 0 - Renamed vague "void QMailMessagePart::defaultContentType()" - Made attachment methods in QMailMessagePartContainer virtual. The implementation does some dynamic_casts to check the type of the instance, which would rather be better as overridden implementation. Didn't do that yet, but the virtuals should avoid a later ABI break if/when such is done. Change-Id: Ia7dc212a1b609d0b02c2cc269082a0e39667c157 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Use conventional qt pimplification on QMailMessageBodyPekka Vuorela2025-10-274-36/+48
| | | | | | | Change-Id: I1b837dac523837401ee22b876cc46705de461e35 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Use conventional qt pimplification on QMailMessageHeaderPekka Vuorela2025-10-274-26/+31
| | | | | | | Change-Id: I72888473549d46212327668cc262f957cb5de3f9 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Use conventional qt pimplification on QMailMessageHeaderFieldPekka Vuorela2025-10-274-38/+47
| | | | | | | | | | Export on private was added by commit a84920f307cd4 but I think that doesn't matter without QPrivatelyImplemented now. Change-Id: I1ccba0a466beb075d26776de740c867bfec81237 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Remove deprecated synchronizeAll requestPekka Vuorela2025-10-2712-154/+7
| | | | | | | | | | | | | | | | | | | | | Small leftovers: pop service uses its synchronize() implementation also internally. ImapClient has a strategy for that which is set as ImapClient ctor. To be considered should the IPC / message source API be brought back for QMailRetrievalAction::synchronize(). Currently it ends up doing different sub-actions even if the original rationale was allowing the behavior to do thing in parallel. See commit 3e40ef86ac810. Also to worth note that this didn't possibly even work as the servicehandler code was doing exportUpdates() instead of synchronize(), maybe copy/paste error in commit 9c73f5415ace31 from the above request handler. Change-Id: I044732d63a11524a9b4d3a038123315c477d96e5 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Remove empty test methodsPekka Vuorela2025-10-273-241/+1
| | | | | | | | | | Should be obvious enough that setter and getter are tested with a single test case etc. Change-Id: Ie64d1e48cd27ee1f30d7c006d6dd4f469e73cf95 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Mark no-op setId() parameters as unusedPekka Vuorela2025-10-201-0/+2
| | | | | | | Change-Id: I1fcc3b8423b277df9bc068acc2b0ee19f98e5eb7 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi>
* Move privates in qmailid.h more conventinally after public:Pekka Vuorela2025-10-201-4/+12
| | | | | | | Change-Id: I11fc34b4983a41152f2620584e78569791292afa Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Use pointer for out-parameters in QMailMessageClassifierPekka Vuorela2025-10-204-20/+18
| | | | | | | | | Easier to follow side-effects in caller side. Change-Id: Ife9d9d159bf4aaa3bbeffc858797381839bf03bf Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Remove deprecated retrieveAll requestPekka Vuorela2025-10-1516-167/+12
| | | | | | | Change-Id: I3d973ca81b5dcf532233aa97c1065f93c6bb840e Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Remove QMail::messageServerPath() and messageSettingsPath()Pekka Vuorela2025-10-1510-172/+7
| | | | | | | | | | | | | | | | | | | Not used in the library itself and the implementations don't make too much sense: the paths are using QCoreApplication::applicationDirPath() referring the random client app binary path so there's no much idea where the qmf content really is. There is some use for the server path in an example project, perhaps even proving how little it makes sense as it tries to launch a specific hard-coded binary from the directory. If something, the API should have a method for requesting launching the messageserver. Change-Id: I9b4b245e5c17f2e49fe3b9ed8b30cb175c5e8e45 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Use conventional qt pimplification on QMailMessageSetPekka Vuorela2025-10-157-262/+229
| | | | | | | | | | | | | | No much reason here either to use the custom QPrivate. The whole class set is quite funky and IMO subject for deletion, or moving to qwidgets side with FolderModel, but for starters now just avoiding now the custom pimplification in hope of getting rid of that soon. Change-Id: I5fe24574d5b9e3c24e944c6c8ae78b1f2f958bc1 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Remove network status leftover class from SmtpServicePekka Vuorela2025-10-151-11/+2
| | | | | | | | | | | Commit 1ff7dd4c878 removed the usage and made SmtpService attempt fetching the capabilities for 5 minutes before giving up. Kept a TODO item in different form. Change-Id: If09e0f78fed7497f6100bc2c8a465cd9c8c9655f Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi>
* Remove ancient SQL table version checkPekka Vuorela2025-10-151-12/+0
| | | | | | | | | | | The "latestinconversation" was introduced in 2011 and then soon enough renamed by commit de4ef974999da04de. The sql version check from commit 056c0c109eae763. Should be all ancient enough to get rid of. Change-Id: I1805c1dccf0394b56e91203c9baf2eac6f4a78bc Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Avoid QTextCodec references on documentationPekka Vuorela2025-10-152-27/+16
| | | | | | | | | | | QTextCodec is in core5compat and would be nice to eventually get rid of that requirement. Here we don't really need to document where internally it's still used. Can be considered an implementation detail. Change-Id: I69e86d95097f5c8e34e8f9a4be5fb5577345bf66 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Make QMailMessageHeaderField::setId() virtual and no-op where neededPekka Vuorela2025-10-152-30/+37
| | | | | | | | | | | | | | | | | Class structure where children move parent public methods to private on their declaration is suspicious, makes one question a bit the whole inheritance. It doesn't either entirely prevent usage if instance is accessed via parent class type. Hopefully making it a bit more conventional by making the method virtual and no-op where it shouldn't be used. Also reordered method declarations to be more consistent. Change-Id: I846686337fc0ba8083786b266bd2a9f0a264b382 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Minor API break: remove QMailMessage CR/LFPekka Vuorela2025-10-145-42/+36
| | | | | | | | | | | | These don't really belong here, and QChar::CarriageReturn and QChar::LineFeed have existed since Qt 5.0. Not even bothering deprecating, the switch to QChar is trivial enough. Change-Id: Ic4d48fcb27436c55f26c9e735b8d1a96d1a5fa9e Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Clean up ImapClientPekka Vuorela2025-10-144-142/+102
| | | | | | | | | | | | | | | | - Some switches were mixing return; and break; without any actual difference between them. - retrieveMessages() accountCheck parameter was named wrong in declaration vs implementation - Some slot parameters were declared const but implementation not having such. - Simplified error handling in a method to consistently handle error first instead of nesting deeper into ifs. Change-Id: I99b2528b20db9bbdf801bc7dbe361cc7b361b9f8 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Replace custom Maybe<T> with std::optionalPekka Vuorela2025-10-142-61/+4
| | | | | | Change-Id: I9b8a7e7d2a420216bc259499e0db1d8a1e58ca6f Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Remove more unnecessary usage of core5compatPekka Vuorela2025-10-1439-88/+86
| | | | | | | | | | | | | | Besides QTextCodec in a couple places, the remaining use was just - Couple simple QRegExps in protocol plugins. - QLinkedList in messageserver. QList should be good enough for that. Also spotted one ancient symbian test file and cleaned up some minor details. Change-Id: I348fd8d54ca3a6a6fcba1a757f33c7b490661706 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Fix build for examplesPekka Vuorela2025-10-1412-42/+10
| | | | | | | | | | | | | The QWidgets side is on its way out but fixing build in the meanwhile is simple enough. Maybe there's some benefit in having some more code here using the library. Not bothering about all the details here. Change-Id: I4ba71d03a5083623bf3cdb79082d6c77283f06bb Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Fix service handler request castsPekka Vuorela2025-10-141-2/+2
| | | | | | | Change-Id: I15b64f07ea04427bd3174aa1ecb587936b35be75 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Avoid custom QPrivatelyImplemented on QMailThread - ABI breakPekka Vuorela2025-10-116-85/+51
| | | | | | | | | | | Similar to removal on QMailServiceAction on commit b3a4d64808b nothing special here requiring the custom code. It's just a simple pimplification here. Also no need for separate _p.h Change-Id: I0c24ae8937a65789575d2173f26381d65865120a Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Remove some dead code and clean up a bitPekka Vuorela2025-10-116-142/+78
| | | | | | | | | | Some internal mail service command helpers have been dead for long time. For USE_ALTERNATE_MAILSTORE_IMPLEMENTATION only some references in 2010. Change-Id: I6bf8efb76f4f4e6b1877e7fe617c5c7b2370d8b3 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Pass function out parameters as pointers instead of refsPekka Vuorela2025-10-114-19/+17
| | | | | | | | | Even if minor internal function, it's easier to follow. Change-Id: I7a13f4c3e36c878213ca668e1895c15f60d4cfeb Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Add an API for account email aliasesDamien Caliste2025-10-108-32/+97
| | | | | | | | | | | | Consider the case where the QMailAddress used to store one account address is used as a group. It can then serve to set email aliases to an account. Add an explicit function to get aliases and adjust the documention of fromAddress() and setFromAddress() accordingly. Change-Id: I98fb96d8376ec9d57df70dd4c486fd84aa9067a3 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Replace QmfList usage with QListPekka Vuorela2025-10-0844-576/+140
| | | | | | | | | | | | QmfList was added on Qt6 migration as stopgap because of QList changes on iterator & content pointer details. Most of that seems to related to QMailMessageThreadedModel which now uses internally std::list. Doesn't seem that great stuff to begin with. Change-Id: I7c37cf69256273138e29001688de742c1d7ad40f Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Connect method documentation more consistently to implementationPekka Vuorela2025-10-079-58/+11
| | | | | | | | | And couple minor adjustments. Change-Id: I1fe3ad41253aff1401e92b96b973f4ed5bf289b5 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Avoid pointless const on by-value method return valuesPekka Vuorela2025-10-079-33/+46
| | | | | | | Change-Id: I33c176fca6e6de102e76ef7213b4d94ff1847ecd Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Use common if/else brace and operator stylePekka Vuorela2025-10-0624-286/+241
| | | | | | | | | And couple small simplifications too. Change-Id: Id5fe0a3e991961b9b39c92ab1b9b165c6f450289 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Remove unneeded typedef QMailMessageCountMapPekka Vuorela2025-10-066-14/+7
| | | | | | | | | | Not used anywhere in the qmfclient side since commit d06d3db4dfdc6de or so. Change-Id: I64d341bf56b1e9a887566f06631958eee58677d0 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Rename internal QCharsetDetector to use QMail prefixPekka Vuorela2025-10-016-168/+172
| | | | | | | | | | | | | | | | This was posing as more generic Qt class when it's just an internal helper. Renamed to QMail prefix as all the other files in .../support/. Some minor details fixed while at it: - Some #include guard were somewhat broken here - We don't need to support ICU <4.4 by now, it's ancient. - Some methods were having const QString parameter without the reference part. Change-Id: I6e4ff8037f20cee23107aeec1808ab51b48268f3 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi>
* Adjust some cosmetic details, againPekka Vuorela2025-10-0112-13/+22
| | | | | | | Change-Id: I061ae75d0196ee08380cf3763b1b12d55b631795 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Fix up Fwd API deprecationPekka Vuorela2025-10-012-2/+2
| | | | | | | Change-Id: I512329637d8fc2689c87a68e67abdf294dea6cd1 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-14 21:44:36 +0000