summaryrefslogtreecommitdiffstats
path: root/src/libraries
Commit message (Collapse)AuthorAgeFilesLines
...
* Use conventional qt pimplification on QMailMessageHeaderPekka Vuorela2025-10-274-26/+31
| | | | | | | Change-Id: I72888473549d46212327668cc262f957cb5de3f9 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Use conventional qt pimplification on QMailMessageHeaderFieldPekka Vuorela2025-10-274-38/+47
| | | | | | | | | | Export on private was added by commit a84920f307cd4 but I think that doesn't matter without QPrivatelyImplemented now. Change-Id: I1ccba0a466beb075d26776de740c867bfec81237 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Remove deprecated synchronizeAll requestPekka Vuorela2025-10-278-73/+3
| | | | | | | | | | | | | | | | | | | | | Small leftovers: pop service uses its synchronize() implementation also internally. ImapClient has a strategy for that which is set as ImapClient ctor. To be considered should the IPC / message source API be brought back for QMailRetrievalAction::synchronize(). Currently it ends up doing different sub-actions even if the original rationale was allowing the behavior to do thing in parallel. See commit 3e40ef86ac810. Also to worth note that this didn't possibly even work as the servicehandler code was doing exportUpdates() instead of synchronize(), maybe copy/paste error in commit 9c73f5415ace31 from the above request handler. Change-Id: I044732d63a11524a9b4d3a038123315c477d96e5 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Mark no-op setId() parameters as unusedPekka Vuorela2025-10-201-0/+2
| | | | | | | Change-Id: I1fcc3b8423b277df9bc068acc2b0ee19f98e5eb7 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi>
* Move privates in qmailid.h more conventinally after public:Pekka Vuorela2025-10-201-4/+12
| | | | | | | Change-Id: I11fc34b4983a41152f2620584e78569791292afa Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Use pointer for out-parameters in QMailMessageClassifierPekka Vuorela2025-10-202-16/+16
| | | | | | | | | Easier to follow side-effects in caller side. Change-Id: Ife9d9d159bf4aaa3bbeffc858797381839bf03bf Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Remove deprecated retrieveAll requestPekka Vuorela2025-10-159-58/+4
| | | | | | | Change-Id: I3d973ca81b5dcf532233aa97c1065f93c6bb840e Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Remove QMail::messageServerPath() and messageSettingsPath()Pekka Vuorela2025-10-152-30/+2
| | | | | | | | | | | | | | | | | | | Not used in the library itself and the implementations don't make too much sense: the paths are using QCoreApplication::applicationDirPath() referring the random client app binary path so there's no much idea where the qmf content really is. There is some use for the server path in an example project, perhaps even proving how little it makes sense as it tries to launch a specific hard-coded binary from the directory. If something, the API should have a method for requesting launching the messageserver. Change-Id: I9b4b245e5c17f2e49fe3b9ed8b30cb175c5e8e45 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Use conventional qt pimplification on QMailMessageSetPekka Vuorela2025-10-156-261/+228
| | | | | | | | | | | | | | No much reason here either to use the custom QPrivate. The whole class set is quite funky and IMO subject for deletion, or moving to qwidgets side with FolderModel, but for starters now just avoiding now the custom pimplification in hope of getting rid of that soon. Change-Id: I5fe24574d5b9e3c24e944c6c8ae78b1f2f958bc1 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Remove ancient SQL table version checkPekka Vuorela2025-10-151-12/+0
| | | | | | | | | | | The "latestinconversation" was introduced in 2011 and then soon enough renamed by commit de4ef974999da04de. The sql version check from commit 056c0c109eae763. Should be all ancient enough to get rid of. Change-Id: I1805c1dccf0394b56e91203c9baf2eac6f4a78bc Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Avoid QTextCodec references on documentationPekka Vuorela2025-10-152-27/+16
| | | | | | | | | | | QTextCodec is in core5compat and would be nice to eventually get rid of that requirement. Here we don't really need to document where internally it's still used. Can be considered an implementation detail. Change-Id: I69e86d95097f5c8e34e8f9a4be5fb5577345bf66 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Make QMailMessageHeaderField::setId() virtual and no-op where neededPekka Vuorela2025-10-152-30/+37
| | | | | | | | | | | | | | | | | Class structure where children move parent public methods to private on their declaration is suspicious, makes one question a bit the whole inheritance. It doesn't either entirely prevent usage if instance is accessed via parent class type. Hopefully making it a bit more conventional by making the method virtual and no-op where it shouldn't be used. Also reordered method declarations to be more consistent. Change-Id: I846686337fc0ba8083786b266bd2a9f0a264b382 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Minor API break: remove QMailMessage CR/LFPekka Vuorela2025-10-143-32/+24
| | | | | | | | | | | | These don't really belong here, and QChar::CarriageReturn and QChar::LineFeed have existed since Qt 5.0. Not even bothering deprecating, the switch to QChar is trivial enough. Change-Id: Ic4d48fcb27436c55f26c9e735b8d1a96d1a5fa9e Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Replace custom Maybe<T> with std::optionalPekka Vuorela2025-10-142-61/+4
| | | | | | Change-Id: I9b8a7e7d2a420216bc259499e0db1d8a1e58ca6f Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Remove more unnecessary usage of core5compatPekka Vuorela2025-10-145-6/+6
| | | | | | | | | | | | | | Besides QTextCodec in a couple places, the remaining use was just - Couple simple QRegExps in protocol plugins. - QLinkedList in messageserver. QList should be good enough for that. Also spotted one ancient symbian test file and cleaned up some minor details. Change-Id: I348fd8d54ca3a6a6fcba1a757f33c7b490661706 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Avoid custom QPrivatelyImplemented on QMailThread - ABI breakPekka Vuorela2025-10-116-85/+51
| | | | | | | | | | | Similar to removal on QMailServiceAction on commit b3a4d64808b nothing special here requiring the custom code. It's just a simple pimplification here. Also no need for separate _p.h Change-Id: I0c24ae8937a65789575d2173f26381d65865120a Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Remove some dead code and clean up a bitPekka Vuorela2025-10-114-85/+12
| | | | | | | | | | Some internal mail service command helpers have been dead for long time. For USE_ALTERNATE_MAILSTORE_IMPLEMENTATION only some references in 2010. Change-Id: I6bf8efb76f4f4e6b1877e7fe617c5c7b2370d8b3 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Pass function out parameters as pointers instead of refsPekka Vuorela2025-10-111-10/+11
| | | | | | | | | Even if minor internal function, it's easier to follow. Change-Id: I7a13f4c3e36c878213ca668e1895c15f60d4cfeb Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Add an API for account email aliasesDamien Caliste2025-10-108-32/+97
| | | | | | | | | | | | Consider the case where the QMailAddress used to store one account address is used as a group. It can then serve to set email aliases to an account. Add an explicit function to get aliases and adjust the documention of fromAddress() and setFromAddress() accordingly. Change-Id: I98fb96d8376ec9d57df70dd4c486fd84aa9067a3 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Replace QmfList usage with QListPekka Vuorela2025-10-0837-260/+139
| | | | | | | | | | | | QmfList was added on Qt6 migration as stopgap because of QList changes on iterator & content pointer details. Most of that seems to related to QMailMessageThreadedModel which now uses internally std::list. Doesn't seem that great stuff to begin with. Change-Id: I7c37cf69256273138e29001688de742c1d7ad40f Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Connect method documentation more consistently to implementationPekka Vuorela2025-10-079-58/+11
| | | | | | | | | And couple minor adjustments. Change-Id: I1fe3ad41253aff1401e92b96b973f4ed5bf289b5 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Avoid pointless const on by-value method return valuesPekka Vuorela2025-10-079-33/+46
| | | | | | | Change-Id: I33c176fca6e6de102e76ef7213b4d94ff1847ecd Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Use common if/else brace and operator stylePekka Vuorela2025-10-0613-197/+159
| | | | | | | | | And couple small simplifications too. Change-Id: Id5fe0a3e991961b9b39c92ab1b9b165c6f450289 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Remove unneeded typedef QMailMessageCountMapPekka Vuorela2025-10-064-10/+1
| | | | | | | | | | Not used anywhere in the qmfclient side since commit d06d3db4dfdc6de or so. Change-Id: I64d341bf56b1e9a887566f06631958eee58677d0 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Rename internal QCharsetDetector to use QMail prefixPekka Vuorela2025-10-016-168/+172
| | | | | | | | | | | | | | | | This was posing as more generic Qt class when it's just an internal helper. Renamed to QMail prefix as all the other files in .../support/. Some minor details fixed while at it: - Some #include guard were somewhat broken here - We don't need to support ICU <4.4 by now, it's ancient. - Some methods were having const QString parameter without the reference part. Change-Id: I6e4ff8037f20cee23107aeec1808ab51b48268f3 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi>
* Adjust some cosmetic details, againPekka Vuorela2025-10-018-4/+11
| | | | | | | Change-Id: I061ae75d0196ee08380cf3763b1b12d55b631795 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Fix up Fwd API deprecationPekka Vuorela2025-10-012-2/+2
| | | | | | | Change-Id: I512329637d8fc2689c87a68e67abdf294dea6cd1 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Fix slightly off indent, adjust enum style and minor detailsPekka Vuorela2025-10-0146-221/+181
| | | | | | | Change-Id: I4ad9396f40535fdf4b010af76e121f1339698e50 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Avoid failing on expected unit test failures, and some cleanupsPekka Vuorela2025-09-295-12/+7
| | | | | | | | | | | | | | | | - Imap test is marked insignicant in .pro but that allows success also, cmake's WILL_FAIL doesn't. Comment out latter to avoid unexpected failure. - Instead of failing, skip tst_qmailstorageaction if there's no messageserver running as such is not there with simple 'make test'. - Removed some qtopia style file references, adjusted cosmetic details, added/removed #includes depending on whether needed or not. Avoiding some pointless trinary operators. Change-Id: Ia7f2fd8e7c7318a138e1cb043f1da436902943c0 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Deprecate Fwd classes in favor of just introducing enums in real classesPekka Vuorela2025-09-2627-659/+438
| | | | | | | | | | | | | | | | | | | | | | | The Fwd classes were inherited by the actual classes, allowing to #include only the fwd and not the bigger real class header. Such a compilation time micro optimization shouldn't really be worth complicating the API. Thus just moved the enum content to actual classes. For some backwards compatibility made the Fwd classes typedeffed to the real ones. Crypto side didn't even have a proper class, only the Fwd and suppose all the usage of the code just did include anyway for the whole crypto api. The QMailFolderFwd::PredefinedFolderId was having a cyclic dependency when moved to QMailFolder: QMailFolderId ctor variant was depending on it and QMailFolder was depending on the Id. Moved the predefined id to the Id class which feels like a better home anyway. Change-Id: I9a9aa9c407ae90cc11b37179fe417e3a002ce94b Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi>
* Use qDeleteAll() more and some more cosmetic cleanupsPekka Vuorela2025-09-263-55/+51
| | | | | | | | | | For interesting detail ServiceActionQueue::clear() seemed badly done and likely leaking memory. Change-Id: Ibeb429bd46957dc1bac9e56f2bc8889a2e64b191 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Remove QMailMessageKey::serialize() variant that existed for symbianPekka Vuorela2025-09-262-14/+0
| | | | | | | Change-Id: I2bc7541ae5bcee84a990cf03d8276209771ba094 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Clean up some cosmetic detailsPekka Vuorela2025-09-1973-764/+405
| | | | | | | | | | | | | | | | | | | Mostly coding conventions here. - Method opening braces to their own lines - Adjusted some inconsistent init list styles - Removed some redundant static declarations inside anon namespace - Replaced one delete loop with qDeleteAll() - Remove some trailing extra new lines - Added some missing spaces after commas - for (), if (), switch as common qt style - Removed some unnecessary scopes within switch cases Etc. Change-Id: Ide9ad7fea6f5fce3b854af2bf05874623c474028 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Remove support for QT_NO_SSLPekka Vuorela2025-09-182-64/+7
| | | | | | | | | | In the world of today there shouldn't be much sense in doing email stuff without encryption support. Simplify code a bit by removing the ifdeffing. Change-Id: I90d90cd1ef11eed2ebd625dafee2f78b7d039233 Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>
* Simply notify on authentication errorDamien Caliste2025-09-172-2/+98
| | | | | | | | | | | | | | | | Let the credential implementations decide what to do on authentication error: either invalidate or retry. Adjust the API accordingly. Apply this change when caching credential data in the SingleSignOn plug-in: Don't make SSO calls on each service connection, use cached values instead. Only reset the cached values when the authentication fails with wrong credentials. Change-Id: I14fbe416567d552e7729ad8579fd9a763a3f6749 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Rename QMailMessage::setInResponseToDamien Caliste2025-07-272-2/+2
| | | | | | | | | | | | Because of automatic conversion from MessageId to Message, the calls to setInResponseTo(id) are interpreted as setInResponseTo(msg), making it infinitely recurring. Avoid this kind of issues by renaming the newly introduced function in QMailMessage to setReplyReferences(). Change-Id: I2acb1b6a7a6277c3685eabe757a6e9b11e798d06 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Setup references header when replying to a messageDamien Caliste2025-06-232-0/+30
| | | | | | | | | Add a convenient function in QMailMessage to properly compute the In-Reply-to: and References: headers when replying to a message. Change-Id: Ibe962383d95e101b612258eb0ced980fef7e7203 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Add a read receipt constructorDamien Caliste2025-06-163-0/+156
| | | | | | | | | | Add a constructor for a QMailMessage as a read receipt for a given message. The message is created according to RFC8098 as a multipart/report message. Change-Id: I41b70fd40e5f7e0a92e04cd92c387542b47686ce Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Rewrite logging with QLoggingCategoryDamien Caliste2025-06-1333-1276/+309
| | | | | | | | | Replace the custom logging mechanism with QLoggingCategory. Also declare the warnings with the proper category. Change-Id: If87d53d27ea0c65abd434af9f99fe49ce634d6dd Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Don't create a header for ContentDisposition::NoneDamien Caliste2025-06-111-1/+5
| | | | | | | | | When creating a part, if the given content disposition is None, don't create a associated header with an empty value. Change-Id: Id07887c6dda5a495e220e6c9f64e49b2d5214e4b Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Add missing spaces after for/if/while/switchPekka Vuorela2025-05-0924-122/+122
| | | | | | | Change-Id: I57c6ed78099b3359a16ce807da95325e755f0197 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi>
* Remove trailing whitespace with sed scriptPekka Vuorela2025-05-0962-1843/+1843
| | | | | | | Change-Id: Iebfffe7a6d5b2db40f0508ecd7c8ccddfa6665a6 Reviewed-by: Damien Caliste <dcaliste@free.fr> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Fix account added twice in list modelDamien Caliste2025-05-091-95/+84
| | | | | | | | | | | | | | If an account is added, while an account list model is still uninitialised, the account was added twice. Correct it by returning when d->initialize() is called. Also exclude current ids when matching new accounts. Also rename init member and initialize() to populated and populate() for clearer meaning. Additional clean-up in the class, polishing spacing and brackets alignments. Change-Id: I1e5e3b8dae15d0b86bfbf26b48085d1d9b599707 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Add a mail account manager based on libaccounts-qtDamien Caliste2025-05-069-4/+1259
| | | | | Change-Id: Ice8819e679da538e484c776138e3a9b101493a5d Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Introduce an API handling external accountsDamien Caliste2025-05-069-11/+294
| | | | | | | | | | | The new QMailAccountManager API is used by the mail store to deal with accounts, when provided. By default, the existing SQL handling of the accounts is used. Change-Id: Ided2132ce8bfc7a4efebff90cbb2a727134f8fda Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Make account tables optionalDamien Caliste2025-05-064-55/+153
| | | | | | | | | | Add a constructor option to QMailStoreSql to use or not the tables related to accounts. When true, it allows to use an external storage for the accounts, like system-wide accounts. Change-Id: I87d1dc8afafa56889511e25b58505dc5dfe1c89e Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Move handling of standard folders to dedicated routinesDamien Caliste2025-05-062-107/+152
| | | | | | | | | Separate the code dealing with standard folders, so it can be called separately from the code dealing with the account. Change-Id: I65a9ce2c32c5584e4df7f9b339cb4e6d639b5bdd Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Put key first in QMailStorePrivate::Cache templateDamien Caliste2025-05-062-36/+38
| | | | | | | | Use a key, value order when defining the Cache template, to follow QCache ordering. Change-Id: I14b56842a47753669d23d21f7166e8f89b166c0e Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* Move SQL-related parts into a dedicated classDamien Caliste2025-05-0613-9721/+10335
| | | | | | | | | | Cut QMailStorePrivate into two: - one new class that is handling SQL-related actions, - the remaining part, containing the cache and the notifications. Change-Id: Ide3f70a5da8e85b465dc0ccd07a4bc15e549f519 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
* New connect() api in QMailServiceAction - small api breakPekka Vuorela2025-04-223-107/+115
| | | | | | | | | | | | | | | | | | | | New api better checks the types and we have complex enough ones here. Besides that, the api had overloaded names for QMailSearchAction::remainingMessagesCount() and ::messagesCount(), having same name for both signal and getter. While we could cope with that with some extra code, it's really just bad API so changed the signal names to indicate it's about change. Also the totalProgressChanged() signalling seemed broken. The signal got connected to handler in private class, which emitted a similar signal, but that wasn't connected to the main class. Added such now in QMailActionInfo() ctor. Change-Id: If0264d8de65509cd1be9b5a5d994c57ab9e9f0d5 Reviewed-by: Pekka Vuorela <pvuorela@iki.fi> Reviewed-by: <matti.viljanen@kapsi.fi> Reviewed-by: Damien Caliste <dcaliste@free.fr>