| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |
|
|
|
|
|
|
|
|
|
| |
Create a new function to ensure that content type matching is always done
case insensitive.
Originally the comparison was done after a toLower(), but forgetting this, like
in src/libraries/qmfclient/qmailmessage.cpp#6252, can create bugs.
Change-Id: Ia93e068e5374c346c94c2afe4de768d3833b4a9a
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
QMF_NO_MESSAGE_SERVICE_EDITOR used to have this effect but now that
QmfWidget is a separate module, it pulls in QtWidgets.
There could be use for disabling service editors, but still keeping
QmfWidgets, but now for simplicity just disabling both with the
new option.
Change-Id: Iebb5c52aab4b645572f694bae8c5ed40e8d6aa6b
Reviewed-by: Christopher Adams <chris.adams@jollamobile.com>
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
API to move folder in the hierarchy. Implementation is mostly based on 'onlineRenameFolder' API implementation
Testing:
========
1) Gmail account: Try to move a folder from one folder to another. Expected result: move success
2) Gmail account: Try to move a folder from one folder to root. Expected: move success
3) Gmail account: Try to move top-level (root) folder to some other folder. Expected result: move success
4) Binary compatibility
- Verify that existing 3rd party QMF plugins still work well with new QMF
- Try to move folder for 3rd party QMF account (which doesn't have implementation of MoveFolder)
Verify that MoveFolder action is failed.
Verify in logs that action is completed with "This function is not currently supported" error
5) Gmail account (handling errors):
- Delete folder A on Web UI
- Try to move folder A to folder B on device
- Verify that action is failed
- Try to perform some moveFolder operations again
- Verify that those operation are completed (e.g. completion is not freezed)
Change-Id: Ifd59ad4fe9c41d17963aa64101b203d31dcdfb2d
Reviewed-by: Christopher Adams <chris.adams@jollamobile.com>
|
| |
|
|
|
| |
Change-Id: I67eb29e13c5e643ee2f58a0696400e085999c01c
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
|
| |
|
|
|
| |
Change-Id: Icce55517963f0cbc35211e9fc6f1a0fc413f5676
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
|
| |
|
|
|
|
|
|
|
| |
NewCountNotifier was never deleted because it never emitted any signals.
Original Author: Slava Monich <slava.monich@jolla.com>
Change-Id: I4e85256c4e40b0c386ce6f58f7a9a1637217dd16
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QmfMessageServer.
This was not possible prior to now due to Qt 4 support hanging around like the
undead vampire it is, but now we purged it with fire and light, and the build
system looks a lot less like a stinky, decomposed corpse.
There's still a lot of surprises lurking: qtmail is one such surprise. I don't
quite grasp why it's so heavy on plugins, and qmfutil also needs some...
attention. But at least it's a start.
As part of this work, we rename the qcop headers to fit the private convention.
This could have been done in a prior commit, but given that I didn't have an
easy way to build prior to this commit, I opted to roll them together.
Change-Id: Ia3e288ffc3639a7751c9040ceecb54fca77a31b1
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
Reviewed-by: Valerio Valerio <valerio.valerio@jollamobile.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
This has persisted long enough, and as far as I am aware, has no users. It is
also blocking potential build system cleanups and other good things.
Reviewed-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
Change-Id: I5e0e0549ef6ffee31b5e60ec94a9e17f27e01436
Reviewed-by: John Brooks <john.brooks@dereferenced.net>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|
| |
|
|
|
| |
Change-Id: I3215c99d44dc28b70890fcdd2dd3e4c2e10ba511
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|
| |
|
|
|
|
|
|
|
|
| |
This makes build system detect if Qt libraries are built as framework or not and
add correct flags to LIBS.
Change-Id: Ifb0d2ed87f5d624966395bce39959ce53f1dee89
Reviewed-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Reviewed-by: Tasuku Suzuki <stasuku@gmail.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|
| |
|
|
|
|
|
|
|
|
| |
Instead of having one gigantic master .pro, split things out into multiple
SUBDIRS templates. This allows for slightly better grained build dependencies
without losing the sanity of a clearly understandable build system.
Change-Id: Ib09cd6170bcf8be55a1b351731f9a6451bb82d27
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the following compilation errors with gcc 4.7 and later.
messageserver.cpp: In static member function 'static void MessageServer::hupSignalHandler(int)':
messageserver.cpp:501:5: error: '::write' has not been declared
messageserver.cpp: In member function 'void MessageServer::handleSigHup()':
messageserver.cpp:508:5: error: '::read' has not been declared
Change-Id: I6fbcf2cba884f5e285c0259e020c60f4a44173b4
Reviewed-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|
| |
|
|
|
|
| |
Change-Id: I379598ddb440fe5c7474873c078cade05c8e5fb6
Signed-off-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
MessageServer plugins will be loaded and executed in the messageserver main loop,
these plugins should only be used for services that need to know information
about the operations initiated by all clients connected to messageserver.
To make use of this functionality qmf should be compiled with 'DEFINES+=MESSAGESERVER_PLUGINS'.
Change-Id: I6bebb150645d2c70a5bc67ffcaaa904f94ed3705
Signed-off-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|
| |
|
|
|
|
|
|
| |
Signed-off-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Change-Id: I2c03d287fc871098cf45d75d4a1262b9c6c4378d
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
|
| |
|
|
|
|
|
|
| |
Update code base to match latest release of Qt.
Signed-off-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Change-Id: I02c2ff250ea8cd960938b81903e92b04c745ae9c
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|
| |
|
|
|
|
|
|
| |
Symbian is not a supported platform anymore.
Change-Id: I82e618e756ae0b247e6e038fa9d8d43fb90b44ff
Reviewed-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
|
| |
|
|
|
| |
Change-Id: If0f4427ee93a37de4ebd9e097defd8b3956f0fc6
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
|
| |
|
|
|
|
|
|
|
|
| |
minor, but matches the changes made in Qt 5, and reflects that Nokia is no
longer the vendor of this software.
Change-Id: I3b324b813359f53e65760f3ce7a751dbd5c970e7
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>
Reviewed-by: Johan Thelin <johan.thelin@pelagicore.com>
Reviewed-by: Valerio Valerio <vdv100@gmail.com>
|
| |
|
|
| |
Patch from Edit Siket-Szasz
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
As qDebug shouldn't be used in release code, and may become deprecated.
There's still some uses of qDebug left, namely, some automated
tests that actually test qDebug/qMailLog functionality, some uses of
qDebug in uncompiled documentation code snippet examples, one use of
include QDebug in symbian code, and in qmailid some uses of
defining operator<<(QDebug <<, ...).
There's still about 500 uses of qWarning and qFatal left. For these
I include qmaillog.h as currently that inclues QDebug. Apart from
the one symbian case already mention.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
When sending a forward without download message, with a sent
folder on the server, a second spurious attempt was being made
to APPEND the message into the sent folder on the server. (Test
server ignored the spurious append, so no error was detected).
So fix this, checked for regressions in 4 cases:
Forward without download with sent folder on server.
Forward without download without sent folder on server.
Normal sending (non-fwod) with sent folder on server.
Normal sending without sent folder on server.
|
| |
|
|
|
| |
By initializing variable. Don't expect that this code path
can be hit in practice. So just eliminate spurious warning.
|
| | |
|
| |
|
|
| |
Use 'kill -SIGHUP $(pidof messageserver)'
|
| |
|
|
|
|
|
|
|
| |
Keep info about QMailServiceAction::Status and progress of
running actions.
Tested by starting serverobserver tool after starting a long sync,
waiting until previewing progress was > 0%, and putting some
judicious qDebugs in.
|
| |
|
|
| |
Make sure all GUI code is under QMF_NO_MESSAGE_SERVICE_EDITOR config option.
|
| |
|
|
| |
And update auto test.
|
| |
|
|
|
|
| |
as they do nothing.
Thanks to Valerio for the patch.
|
| |
|
|
|
|
| |
queue.
Were clogging up the queue of actions to be serviced.
|
| |
|
|
|
|
|
|
|
|
|
| |
Only allow 2 concurrent actions to be serviced on the device.
Only allow 1 concurrent action per process.
Fix a bug whereby invalid actions where being added to mActiveActions.
Add 2 new functions (quasi public)
QMF_EXPORT int maximumConcurrentServiceActions();
QMF_EXPORT int maximumConcurrentServiceActionsPerProcess();
|
| |
|
|
|
|
|
|
|
| |
Instead of using its own private interface for push email and interval
checking operations. This change will faciliate monitoring of push email
network operations, and limiting peak memory use.
Required adding a new service action, retrieveNewMessages, for retrieving
new messages in a folder without updating existing messages.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
onlineCreateFolder service action was not returning when
trying to create a folder in the root of the folder list.
Fix accidentally committed in previous commit:
void ServiceHandler::onlineCreateFolder(quint64 action, const QString &name, const QMailAccountId &accountId, const QMailFolderId &parentId)
{
if(accountId.isValid()) {
- QSet<QMailAccountId> accounts = folderAccount(parentId);
+
+ QSet<QMailAccountId> accounts;
+ if (parentId.isValid()) {
+ accounts = folderAccount(parentId);
+ } else {
+ accounts.insert(accountId);
+ }
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
void QMailRetrievalAction::createStandardFolders(const QMailAccountId &accountId)
Requests that the message server create the standard folders for the
account accountId. If all standard folders are already set in the storage
the service action will return success immediately, in case some standard folders are
not set, a matching attempt against a predefined list of translations will be made,
if the folders can't be matched, messageserver will try to create them in the server side
and match them if the creation is successful. In case folder creation is not allowed for
the account accountId the service action will return.
|
| |
|
|
|
|
|
|
| |
void QMailMessageServer::transmitMessage(quint64 action, const QMailMessageId &messageId)
Requests that the MessageServer application transmit the message
identified by 'messageId' that are currently in the Outbox folder.
The request has the identifier 'action'.
|
| |
|
|
|
|
|
|
| |
Ported from MeeGo QMF.
Set custom fields, fix caching, set msg id in QMailServiceAction::Status
when TX fails.
Ensure that messageserver does not crash when sending email with invalid
smtp server address or invalid smtp commands, proper error will be reported.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically, as documented in src/libraries/qmfclient/CHANGES.qdoc item 52, added:
'void QMailStorageAction::deleteMessages(quint64, const QMailMessageIdList &ids)',
'void QMailStorageAction::rollBackUpdates(quint64, const QMailAccountId &mailAccountId)',
'void QMailStorageAction::moveToStandardFolder(quint64, const QMailMessageIdList& ids, QMailFolder::StandardFolder standardFolder)',
'void QMailStorageAction::moveToFolder(quint64, const QMailMessageIdList& ids, const QMailFolderId& folderId)',
'void QMailStorageAction::flagMessages(quint64, const QMailMessageIdList& ids, quint64 setMask, quint64 unsetMask)',
'void QMailStorageAction::restoreToPreviousFolder(quint64, const QMailMessageKey& key)',
'void QMailMessageServer::deleteMessages(quint64, const QMailMessageIdList &ids)',
'void QMailMessageServer::rollBackUpdates(quint64, const QMailAccountId &mailAccountId)',
'void QMailMessageServer::moveToStandardFolder(quint64, const QMailMessageIdList& ids, quint64 standardFolder)',
'void QMailMessageServer::moveToFolder(quint64, const QMailMessageIdList& ids, const QMailFolderId& folderId)',
'void QMailMessageServer::flagMessages(quint64, const QMailMessageIdList& ids, quint64 setMask, quint64 unsetMask)' and
'void QMailMessageServer::restoreToPreviousFolder(quint64, const QMailMessageKey& key)'.
Also added documentation for new functions, and made some minor documentation
updates for existing functions.
Additionally added a new set of module tests tst_qmailstorageaction. These
tests require the messageserver to be running. They are not just stubs
but do real testing.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to be online.
Specifically:
Renamed 'void QMailStorageAction::deleteMessages(const QMailMessageIdList &ids)' to onlineDeleteMessages,
'void QMailStorageAction::copyMessages(const QMailMessageIdList &ids, const QMailFolderId &destinationId)' to onlineCopyMessages,
'void QMailStorageAction::moveMessages(const QMailMessageIdList &ids, const QMailFolderId &destinationId)' to onlineMoveMessages,
'void QMailStorageAction::flagMessages(const QMailMessageIdList &ids, quint64 setMask, quint64 unsetMask)' to onlineFlagMessages,
'void QMailStorageAction::createFolder(const QString &name, const QMailAccountId &accountId, const QMailFolderId &parentId)' to onlineCreateFolder,
'void QMailStorageAction::renameFolder(const QMailFolderId &folderId, const QString &name)' to onlineRenameFolder,
'void QMailStorageAction::deleteFolder(const QMailFolderId &folderId)' to onlineDeleteFolder.
'void QMailMessageServer::deleteMessages(const QMailMessageIdList &ids)' to onlineDeleteMessages,
'void QMailMessageServer::copyMessages(const QMailMessageIdList &ids, const QMailFolderId &destinationId)' to onlineCopyMessages,
'void QMailMessageServer::moveMessages(const QMailMessageIdList &ids, const QMailFolderId &destinationId)' to onlineMoveMessages,
'void QMailMessageServer::flagMessages(const QMailMessageIdList &ids, quint64 setMask, quint64 unsetMask)' to onlineFlagMessages,
'void QMailMessageServer::createFolder(const QString &name, const QMailAccountId &accountId, const QMailFolderId &parentId)' to onlineCreateFolder,
'void QMailMessageServer::renameFolder(const QMailFolderId &folderId, const QString &name)' to onlineRenameFolder,
'void QMailMessageServer::deleteFolder(const QMailFolderId &folderId)' to onlineDeleteFolder.
Additionally updated the doc to fix some assorted discrepancies, and indicate which functions require the device to be online.
Have not yet regenerated the html version of the doc.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QMailMessageServer::messagesCount signal.
QMailSearchAction::countMessages(const QMailMessageKey &filter, const QString &bodyText) function
Requests that the message server count all messages that match the criteria
specified by \a filter. If \a bodyText is non-empty then messages that
contain the supplied text in their content will also be matched and counted.
It should be implemented for all protocol plugins for accounts with the
QMailAccount::CanSearchOnServer flag set.
Implemented for IMAP plugin, accelerated by use of ESEARH IMAP extension
when supported by the remote server.
QMailSearchAction::messagesCount(uint count)
This signal emits the \a count of matching messages on the remote server.
Only emitted for remote searches.
Emitted by countMessages, and searchMessages functions.
uint QMailSearchAction::messagesCount() const
Returns the count of matching messages on the remote server.
Also implemented boiler plate code in QMailMessageServer etc.
|
| |
|
|
|
|
|
| |
Add 'QMailSearchAction::remainingMessagesCount(uint count) signal.
and 'QMailSearchAction::searchMessages' function with limit argument.
Also add doc.
|
| |
|
|
| |
This reverts commit 6a547b0b74faa3fabbe1656b2d8a45d2be59c40f.
|
| |
|
|
|
|
| |
"Error occurred" keeps on popping up when sending mail to wrong recipient
Also ensure mailstore notifications are emitted for custom-field changes.
|
| |
|
|
| |
Remove obsolete pre-release clause.
|
| |
|
|
| |
Fix for nb#271151.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Finishes NB#257648 Use QTimer instead of syshb
Fixes NB#265381 crash in QMailHeartbeatTimer
Fixes NB#267768 segfaults @ QtMobility::QSystemAlignedTimerPrivate::error
|
| |
|
|
| |
Patch by Don
|