summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Handle empty uri-list in dropped MIME data6.6Moss Heim2024-04-052-1/+24
| | | | | | | | | | | | | Previously WebContentsAdapter assumed that drag-n-drop MIME data with hasUrls() == true would also have a nonempty url list. This is not always the case. Instead, check directly if urls() is nonempty. Fixes: QTBUG-123765 Change-Id: I9e2189e3f0223f98bdd8be273adb96cf063f4be3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit fa8ff1bb933b02f61e406cb29d5c8d4294676a5a) Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Update ChromiumMichael Brüning2024-03-263-2/+2
| | | | | | | | | | | Submodule src/3rdparty 326fa478..34ec0d3e: * [Backport] Security bug 325296797 Fixes: QTBUG-123292 Change-Id: I4052ff581d0414865f15d2386c3c4c970540482c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit c1adb7e02600f9bf2fbc586110aa7097adb0995a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Convert "page" <-> "view" coordinates for PdfSelection and LinkModelShawn Rutledge2024-03-258-40/+363
| | | | | | | | | | | | | | | | | | | Use FPDF_PageToDevice() rather than subtracting from page height, in all the remaining places where we were doing that. Also use FPDF_DeviceToPage() to convert coordinates coming from the view, for hit-testing links and for selecting ranges of text. Mark the private utility functions that we're modifying const while we're at it. Pick-to: 6.5 Task-number: QTBUG-100630 Fixes: QTBUG-106565 Change-Id: Ide4f73b80888a0e08381c6e4995f69ebeaa2d12f Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit b78c78349d786b294ee0845717ad5db38ae2565a) Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 5642f33e17aa82fd361b972cd8ac88ba83604273) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Convert search result bounds to account for PDF transformsShawn Rutledge2024-03-243-5/+26
| | | | | | | | | | | | | | | | | | As a drive-by, remove unneeded includes. QPdfDocumentPrivate::convertPageRect() will be useful for fixing related bugs. If PDF files can contain arbitrary transforms, and "page coordinates" returned from pdfium functions are not already converted, then it's never ok to just subtract from page height to invert the y's. Pick-to: 6.5 Fixes: QTBUG-120764 Change-Id: Iffce528c0c5e66c499e7147078b7b8718f7610ce Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit fccbc33d95c17b0911fd4cbd97998acfc8e6320f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 541b00830fdd12f91a9da5426536abc4787f4859)
* FIXUP for Force use of classic linker on AppleClang 15Michael Brüning2024-03-221-1/+1
| | | | | | | | | | | | | There was a PRIVATE missing when adding the linker flag due to a copying error from the development system. The CI did not catch this due to not compiling with XCode 15 yet. Fixes: QTBUG-122655 Change-Id: I1fbbba594fbef6b3d27b93c5d2c729f7b685d9ed Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 1321c9cc1508b0014af6462f101b765ad7805942) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 87744248ad1160afa447d8f8afcd619b9a9b5870)
* PDF multipage example: don't assume http by defaultShawn Rutledge2024-03-221-1/+3
| | | | | | | | | | | | | | | | | | | Avoid doing network operations unless a network-specific scheme is given. In fact, network loading is not supported anyway, so QUrl::fromLocalFile() would be just as good for now. But perhaps we could support network loading eventually; and this approach is not harmful in the example in the meantime. You just get a "file not found" error if you give an http(s) URL on the command line. Pick-to: 6.5 Fixes: QTBUG-123548 Change-Id: I2364fd99396d4d65df92106e45818166ef2abf2f Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit f0aa275be272c3ff8337c1d712f8833f7e5a05a6) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 6d0555d007d7daf482006eebf7d8c5fc1d842f6d)
* Update ChromiumMichael Brüning2024-03-143-2/+2
| | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 707f4e7c..326fa478: * [Backport] CVE-2024-25062 / Security bug 325094430 * [Backport] CVE-2024-1671: Inappropriate implementation in Site Isolation (2/2) * [Backport] CVE-2024-1671: Inappropriate implementation in Site Isolation (1/2) * [Backport] CVE-2024-1676: Inappropriate implementation in Navigation * [Backport] CVE-2024-1672: Inappropriate implementation in Content Security Policy. * [Backport] CVE-2024-1670: Use after free in Mojo * [Backport] Security bug 1504473 / 40945008 * [Backport] Security bug 1508758 / 41481379 * [Backport] Security bug 1518994 * Do not assert when ozone uses qt platform with vaapi Fixes: QTBUG-122931 Pick-to: 6.5 Change-Id: I6b9d3a8a4272e24fe818dc048113b170a3b191b5 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 9976aa426166012ede784b5806318ad296dfb331) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Force use of classic linker on AppleClang 15Michael Brüning2024-03-121-0/+9
| | | | | | | | | | | | | | | The new linker ld_prime became the default option, but has issues when building large libraries such as Qt WebEngine. Use the temporary work- around of forcing the classic linker until the issue has been resolved in AppleClang. Pick-to: 6.5 Task-number: QTBUG-122655 Change-Id: I1c21d6b1ac9f1fb89878bf8cc9786d24fe1c94da Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit df40c77a9a2bb2da90c5367f2ed217f027106e8f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 8a5a1a7beb785c6c15c537f4da5f09c38664e952)
* Fix flaky horizontalScrollbarTestMartin Negyokru2024-03-121-0/+94
| | | | | | | | | | | | Mouse events will miss the hittesting if they are sent before the page is drawn. Introduce new test page that listens for first paint events. Change-Id: I4846ec1bde3805f5dd0098d490cb85c72cb0884f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 290d7462696664a1e035082793907d3c698bc987) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 2b7954461c2d9d2e981768b255bec1caaabf18d0)
* Correct the dictionary path for spell checking on macOSAnu Aliyas2024-03-081-1/+1
| | | | | | | | | | | | | | The Spellchecker built using QtCreator didn't work because it didn't copy dictionary files to the application bundle's resource folder. To address this, used 'APPLE' instead of 'MACOS' as the value, since 'MACOS' was false when compiling in QtCreator Fixes: QTBUG-122997 Change-Id: I86a45b3c3622239873a7745e7b1fed5efbf696d8 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 2a85e96a685b36501dee35e8d70522be239d006d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit e1430db3a32c30b3f6c03f26f34b4d86bbbc48b5)
* Fix pure wayland builds with vaapiMichal Klocek2024-03-072-5/+10
| | | | | | | | | | | | | | Add missing build flag checks. This amends 1b7aaf1c7d98482cd6dc3d80aa0140fe9dd2c7d3. Task-number: QTBUG-118035 Fixes: QTBUG-121589 Change-Id: I7dc6aae9898133e893b544e392076dc421a51f17 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit fd1946fc90ec75582aa64bcf8f89940e2fc82120) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit c732837107e3d4fb172ce0a7d4cf4831b312922e)
* Set minimum required VA-API version to 1.14Peter Varga2024-03-051-1/+1
| | | | | | | | | | | | | | Chromium uses av1 encode DDI which has been added to VA-API in version 1.14. Older versions break the build. Note that the pkg-config returns the VA-API version (1.14) instead of the libva version (2.14). Change-Id: I4f206305fd8d9e8bd67385fbd3d3f267cae9b67d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 9064c51ae98d339ec89c1ccc0e7c06f9485fecb7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit bebb06a890fbb4066320ffa2487bd33e39ea044a)
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-03-031-4/+4
| | | | | Change-Id: I71ba5363503a63ac2705f2193352e5011c4fadb7 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-02-281-4/+4
| | | | | Change-Id: I792b2a869b1bd90f005d986c9daeeb8f7a6ca16d Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix outdated qwebenginesettings docsMichal Klocek2024-02-271-2/+2
| | | | | | | | | | | Old webkit's QWebSettings::setUserStyleSheetUrl is not ported to QWebEngineSettings, therefore do not mention it. Change-Id: Ibbc804d1c58657a1d641935a2341132cc723cd82 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 084e6675d7d678b3850ba992dae57f8391aca911) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 198a4334129f5754eed413134272eeb76f15435c)
* Fix error message when dictionary not foundMichal Klocek2024-02-261-0/+6
| | | | | | | | | | | When there is no existing candidate still return something so error message can be thrown. Change-Id: Iab71e089fec8ab88e36395474b6e5d4ecfa1ff4c Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit d86ddb74877342d82c36cb9f47cccb53bf339e23) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 49bdd5486dd962fa3bc0c7cba30737c36ddfdff0)
* Fix enable_plugins gn parameter useMichal Klocek2024-02-261-1/+6
| | | | | | | | | | | | | | | | | | In 106-based adaptations enable_plugins use was changed and it means enabling support for handing plugins, but does not include support for loading plugins using specific technology like Pepper. Moreover, enable_pdf requires plugin support, but it does not require Pepper support (enable_ppapi). Fixes: QTBUG-122137 Change-Id: I75cf611e54d0a47e2b96e7831c1fe1d20b6254b5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit d66a5433e08bce11f905b14c8a03f3a5e1db2b9a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 9dc04234d372c43300f013444a56fee30999a83b)
* Show guest WebContents in DevTools if possibleSzabolcs David2024-02-263-2/+11
| | | | | | | | | | | | | | | | | | | | | Chrome's DevTools has different behavior for PDF content: - If it was opened for the PDF viewer, it closes itself when the guest view has gone (e.g. by navigating away), but it shows the inner content of the plugin. - If it was opened for another site and then navigated to the PDF plugin it won't show the inner content, but the embedding HTML of the parent and it allows navigating away from the plugin. Make our inspector match the behavior of Chrome and allow DevTools to look into the plugin. It helps debugging PDF viewer related issues. Change-Id: I218d4fcf47d6b1f0101fa1d7f36758e04a1dd7b0 Reviewed-by: Anu Aliyas <anu.aliyas@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 6acf981aae2165cde6829f309f3792fc34852fd2) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit c503b50b189c7446b91edfede083100b206370fb)
* Retain focus while loading URLs into the pageAnu Aliyas2024-02-261-0/+3
| | | | | | | | | | | | | | | | While loading URLs, QtWebEngine will remove the old widget from the layout and then add the new widget. If the old widget is the focused widget, while deleting the widget, it will clear its focus, thereby causing QtWebEngine to lose focus. Therefore, if the old widget has focus, set focus to the new widget. Fixes: QTBUG-122153 Change-Id: I095a654ae80ad8089758eb785d4186a9708064a3 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 0a8962b40de96ca87663938427a410ce65f3a8a2) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit ff9fd8806248973f6fdf92190f11b11af0319437)
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-02-261-4/+4
| | | | | Change-Id: I35fb5183a2152cd2ad50fe39e8d1d2599382c920 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Keep page's background color when loading new URLsAnu Aliyas2024-02-261-0/+3
| | | | | | | | | | | | | | | Whenever a new URL is loaded, the background color is reset to white, even if the user has explicitly set the background color to a different value. Therefore, it needs to be reapplied when a new render widget is created. Fixes: QTBUG-112013 Fixes: QTBUG-120926 Change-Id: I6663008ee038f30ea6f5df8ab7d8ce7356b152a1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 85bfaa5274b5d47437d6e0634746f70a6646bd4e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 603c969421b98a9a285128c589b2c32fded21033)
* Fix misleading warningAllan Sandfeld Jensen2024-02-261-3/+6
| | | | | | | | | | | | This is only relevant for OpenGL or backends that needs to be forced to OpenGL Change-Id: Idd96e41c2ca2a87d1dd916e2fadf8945ee25805f Fixes: QTBUG-99446 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit aeea3674f6aa364ec1b4ee17a2e2c8c03127072b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit a057682017e45cb470581a066c0f3ed616ccb8be)
* Clarify meaning of baseUrl argument in setContentMoss Heim2024-02-263-7/+6
| | | | | | | | | | | | The previous wording made it sound as if baseUrl must always be non-empty, however this only affects external content relative URLs. Fixes: QTBUG-90927 Change-Id: I0dff3368dec60b5734c1b12bbfe3f4aefc240e14 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 2d52d1544e85b8bd15ea23c42872961b9f9249ec) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 48e08af384ff42f08106449a07e272195123cc5f)
* Fix for view displaying blank content with transparent backgroundAnu Aliyas2024-02-201-1/+3
| | | | | | | | | | | | | | | | | | | For transparent background color, QtWebEngine will set the attribute Qt::WA_AlwaysStackOnTop to true. This change necessitates triggering an update on the top-level window. The code has been adjusted to invoke an update on the parent widget if one is present. Additionally, update is disabled while widget attributes are being updated, and re-enabled once all attributes are properly set. This prevents unnecessary updates and ensures the widget updates only after all values are set. Fixes: QTBUG-120273 Fixes: QTBUG-121227 Change-Id: Id2a103a59e9dfeb98ac2245ec274360e3c65f239 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Moss Heim <moss.heim@qt.io> (cherry picked from commit 5c73b7f5719b61aad1d7709fee3f810732bb3fba) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 97394380fdd20a88b6e8fe4308d7a56134963d83)
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-02-201-4/+4
| | | | | Change-Id: I7ad2884c772a6d4f50711afde1c7331d044a6d71 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-02-161-4/+4
| | | | | Change-Id: I3d92cea0c5753bfa78571424400c2c21b6132c0c Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-02-151-4/+4
| | | | | Change-Id: I7fc0972f471bcf500d3d663c3a11ad5a0ede18af Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Expand helper process stack to 8MB on WindowsKaloyan Chehlarski2024-02-141-1/+1
| | | | | | | | | | | | | | | | | Chromium on Windows is built with a linker flag that ensures an initial stack size of 8MB, whereas a QtWebEngine build never sets one. The result is that on Windows the helper process only gets the default 1MB stack, which can cause stack overflows in pages with nested elements (see issue QTBUG-120420). This change makes sure the relevant linker flag is added when a Windows build is detected, and the stack size matches the one in Chromium. Task-number: QTBUG-120420 Change-Id: I42ff397f1b90c4455188b5711d5b3e9c1780db23 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit e604b302882d4ca4e8b6d311df31d4e958c9073c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit f153e8e695c267137130752bfde722a7e9467910)
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-02-131-4/+4
| | | | | Change-Id: I1211e54bb64dba30fac34bbb7b5092098f84d529 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-02-091-4/+4
| | | | | Change-Id: I88b72fa1dbd96fce91b493b7405b64be711bfa9f Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update ChromiumMichael Brüning2024-02-093-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty e257d651..707f4e7c: * [Backport] CVE-2024-1284: Use after free in Mojo * [Backport] CVE-2024-1283: Heap buffer overflow in Skia * [Backport] CVE-2024-1059: Use after free in WebRTC * Fixup: [Backport] Security bug 1407197 * [Backport] Use raw strings for regexps in Python code. * [Backport] CVE-2024-1077: Use after free in Network * [Backport] CVE-2024-1060: Use after free in Canvas * [Backport] Security bug 1519980 * FIXUP: Fix build with VS Toolset 17.8 * Fix build with VS Toolset 17.8 * Remove unused python import * [Backport] Update vendored copy of six to 1.16.0. Pick-to: 6.5 Fixes: QTBUG-121845 Fixes: QTBUG-122095 Change-Id: Ice00b6537b19d2a7af7787b5f2989283c89130b7 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 8b521bfccd0ed6fe084bc0bf5b41ec04c31dc83b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Use only 'pdbpagesize' linker option for webenginecore debugMichal Klocek2024-02-091-2/+4
| | | | | | | | | | | | | | | | | | | Using 'pdbpagesize' allows to create larger pdbfiles and it is needed for debug builds for qwebenginecore as it gets over 4Gb. However, these files are not yet well supported by older tooling therefore use the setting only for webengine debug build. This allows qtpdf debug builds and webenginecore/qtpdf release with debug info have functional pdb files with older tooling like cdb on windows. Task-number: QTCREATORBUG-30308 Change-Id: Icd79a0d36b2f4b7f767d17ed79de3a4cbf96f1b4 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 2af8c8c0b35bd37ba8df591d928720d2b894e816) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 0d1439fdf9b3b437f7bbf0876c92a3b2212175c1)
* Minor. Set autodetect for v8 snapshots for cross compilationMichal Klocek2024-02-081-1/+1
| | | | | | | | | | | | We do not compile v8 snapshots on ci as this doubles amount of tasks and ends in much longer compile times. However, they can be enabled otherwise. Change-Id: Ie59492af2bf01cdecf9525e708c642249a1ae681 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 6518a973b6c6644403a7d3a2f3d5eacfe0749f72) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 8cdca960d672b56fd3df13075ca15774f1841920)
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-02-071-4/+4
| | | | | Change-Id: I0d7e3779aee04dd1c090676c72f8d6f73dc399b3 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update ChromiumMichael Brüning2024-02-023-2/+2
| | | | | | | | | | | | | | | | | Submodule src/3rdparty 7b40abeb..e257d651: * [Backport] Security bug 1407197 (2/2) * [Backport] Security bug 1407197 (1/2) * [Backport] CVE-2024-0810: Insufficient policy enforcement in DevTools * [Backport] Security bug 1511389 (2/2) * [Backport] Dependency for security bug 1511389 (1/1) * [Backport] Security bug 1511389 (1/2) * [Backport] CVE-2024-0807: Use after free in WebAudio * [Backport] CVE-2024-0808: Integer underflow in WebUI Task-number: QTBUG-121685 Change-Id: Ie8e7a70265b142b65cea5bd89c9afa45fb0dec6c Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 935caecbbff5ac79d2c43d6bdcd81fe7d83baedf)
* QPdfIOHandler: Ensure QPdfDocument still exists before renderingShawn Rutledge2024-02-022-5/+7
| | | | | | | | | | | | | | | | If a PDF-viewing application is unceremoniously exited while QQuickPixmapReader::processJobs() still has PDF rendering jobs queued up, it could be that the shared QPdfDocument instance is deleted just as QPdfIOHandler::read() starts the rendering. Use a QPointer to avoid that. Fixes: QTBUG-121502 Pick-to: 6.5 Change-Id: I5d0674ca77ab5015b710df49b3842064e65d4adc Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit ed49163c8fef019be18475b86694263801c3a8ea) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 77d2e9ad33a12dbc3e8ddc3ce40498b28029147f)
* QPdfView: use per-page scale factors to render search result rectanglesShawn Rutledge2024-02-022-28/+44
| | | | | | | | | | | | | | | | | | | In FitToWidth and FitInView zoomModes, each page could potentially be a different size; so QPdfViewPrivate::calculateDocumentLayout() loops over all pages, calculating each pageSize and offset on the fly. m_zoomFactor doesn't get updated; but QPdfViewPrivate::updateDocumentLayout() stores the per-page zoom factors in m_documentLayout.pageGeometryAndScale. screenScaleTransform() takes the page index as an argument, looks up the per-page scale factor in those zoom modes, and QPdfView::paintEvent() uses the per-page transform to paint the rectangles. Pick-to: 6.5 Task-number: QTBUG-120764 Change-Id: I86308c8963ffadd2fdb6f36cf9f4696f75f550ed Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit 2b96bbb922c1500b8d3b12cf2eb3052ded41c5c6) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 427c1e114ab2969bfb51b24d0401f7e0286b5873)
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-01-291-4/+4
| | | | | Change-Id: Idb38d9a59c7ea3dc3a293e75a642b2a32e666308 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Bump version to 6.6.3Jani Heikkinen2024-01-291-1/+1
| | | | | Change-Id: Ie66e22f3fecc4b9dbf53e181a97699ee99a59c04 Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
* Delay PdfMultiPageView.goTo[Page|Location] if called too earlyShawn Rutledge2024-01-283-0/+52
| | | | | | | | | | | | | | | | | | | | PdfMultiPageView does not expose a property alias to TableView.rows; we could call it pageCount, but we don't want to mislead users into thinking that the view is the "source of truth" for how many pages it's going to show. The document's pageCount is populated earlier, and that's a problem only in such a case when it's too early to ask the view to go to a particular page. So we work around it in the view by treating these goTo functions as requests to be satisfied as soon as it becomes possible. Fixes: QTBUG-119416 Pick-to: 6.5 Change-Id: Ie2377fe6f2983b72e871b1be2afe4d0878f60841 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> (cherry picked from commit e9a5b6e514996c059d52a857a5aef624afb80a0e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit d63c4dacd2b4ffa2608965ed7e49303b75c722ad) Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Fix discontinuity with successive pinch-zoom in PdfMultiPageViewShawn Rutledge2024-01-272-1/+80
| | | | | | | | | | | | | | | | | | | | | | | | pinch.persistentScale is settable since 6.5 (qtdeclarative a432970b258edb9ff041d221b2155df30cad4799): we need that to tell PinchHandler to start over from 1 after we have also set the rendered scale back to 1, because PinchHandler does not read the scale property for itself. This cherry-pick includes 48ebac59b1ec5bbafa1c64adbdbc44b0cf3f302a to avoid a crash on exit by waiting for the rendering to be done, and a4e64baef027fb407b8c1491c444ed58edd15529 to disable touch compression. Fixes: QTBUG-115502 Task-number: QTBUG-120245 Task-number: QTBUG-121502 Fixes: QTBUG-121564 Pick-to: 6.5 Change-Id: I21951c447bf33e5942b6a1635488d5474ec8f293 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit c0524da14d92a957b4607fb5867dba5d23eea6d9) Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 8c27ae33f80440d20f578fa404c454c8d7bfdf19) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Correct PrintedPageSizeId to match QPageSize::PageSizeIdMichael Brüning2024-01-244-13/+135
| | | | | | | | | | | | | With Qt 6, QPageSize::PageSizeId enum was cleaned up and some values were reordered, but the WebEngineQuick part was not changed accordingly. Pick-to: 6.5 Fixes: QTBUG-120218 Change-Id: I7e4c419750d30a64193e68b0b217ebbccce07d87 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 199730bd41219c5484fb1c4c61b637ab9ceec0c4) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 8f017c2d9d015b9d72a7f1f36e53747bad6c3bfa)
* Fix high-dpi scaling in PdfScrollablePageViewShawn Rutledge2024-01-241-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Amends 85f82185ef5102a2dbe3b2e437b9723e1652ce57 In PdfScrollablePageView.qml, a property like property size pagePointSize: document.pagePointSize(pageNavigator.currentPage) would get evaluated too early (QPdfDocument::pagePointSize() returns a default-constructed QSize if d->doc is still null). We need to call pagePointSize() directly in bindings that need it, so that the function will be called again each time some other binding dependency changes, to get the size of the current page in the current document. Perhaps a binding to the result of a function call does not get invalidated when the function argument changes; or perhaps behavior changed now that the QML files tend to be compiled rather than runtime-interpreted resources. We also need PdfPageImage's width and height to be bound (as they are in PdfMultiPageView.qml), to avoid automatically scaling up to sourceSize. So now we get high-dpi page images again in the single-page example. Task-number: QTBUG-86948 Pick-to: 6.5 Change-Id: I44e8df15c18bd0b752dccc899028e7e7900f6ffb Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 3093ddfa8fb22db9295bc76a07207e6da0a3e995) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit bb514314f924e7f94ac48f4d2283a254cff4cd83)
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-01-221-4/+4
| | | | | Change-Id: I10ca844ae7ba7df62aa176ef5e1073ce7ccc66b3 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix cursor position during compositionAnu Aliyas2024-01-213-13/+64
| | | | | | | | | | | | | | | | During input composition, the cursor is set to the starting position of the string being edited and refrain from updating it throughout the composition process. Once the string is committed, it is set to the last position of the committed string. The modified code is designed to exhibit the same behavior as the widget and quickwidget. Fixes: QTBUG-118746 Pick-to: 6.5 Change-Id: I9adb7a9bea9493457a1d9d4b32338cdba30920a1 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit c9550388b9ab1d82454d0c59eaaf7e640d83d750) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 266c9a5605e05166c0b6e9113e19595856149bd2)
* Fix printing when page ranges are specifiedSzabolcs David2024-01-211-31/+7
| | | | | | | | | | | | | Page ranges are applied at the PDF generation phase and it's incorrect to do it again in PrinterWorker. Simplify it to print all available pages. Fixes: QTBUG-119991 Change-Id: Iaaf435ba2a93ea4480dc1d2f5500844138ea1b53 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit ad26c851700de5ee0962a944d6fc02b58004de1a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 2463c13ae64701e7c18495eb7dd63e0dc7a129b3)
* Fix compilation error with -no-feature-accessibility optionAnu Aliyas2024-01-213-2/+14
| | | | | | | | | | | | | | | - At present, there is no option to disable accessibility in Chromium during build time. - Added the missing definition for BrowserAccessibility::Create() to resolve the compilation issue. - This approach is similar to the BrowserAccessibilityManager::Create() function. Fixes: QTBUG-119789 Pick-to: 6.5 Change-Id: I87a0a3653fa18aa3d32d5620a18f89e9403c92ab Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 39e437f0bc990cf292defff0d77790d27b31df32) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 6fc5eff5cef36ae86704a5f2e05b58c1f5e82a62)
* Update ChromiumMichael Brüning2024-01-193-2/+2
| | | | | | | | | | | | | Submodule src/3rdparty 38bef0c..7b40abeb: * [Backport] Security bug 1506535 * [Backport] CVE-2024-0518: Type Confusion in V8 * [Backport] CVE-2024-0519: Out of bounds memory access in V8 * Fix compilation without webrtc * Speculative fix for jumbo builds on windows Fixes: QTBUG-121229 Change-Id: I106c80206bc84c592d2fe1df770c391883d587df Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update dependencies on '6.6' in qt/qtwebengineQt Submodule Update Bot2024-01-181-4/+4
| | | | | Change-Id: I81688266fd731fa23bfccbe5ebab8c94670c0e57 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix required version for core and core in host projectMichal Klocek2024-01-182-2/+2
| | | | | | | | | | | | During compile or cross compilation against core qt (or core qt in host) with lower version. As we 'support' compiling against latest LTS so currently 6.5 Change-Id: I62596e73fcd7265a85edf4048f82e1a060615e7f Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 8eba10d3b7db7e456f736417f90f84d460ead4f5) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit a1b0579555d91f34f452c4b94fe77f71e9448b7b)
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-17 05:48:08 +0000