| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we can get QuickWebEngineViewPrivate::loadFinished
while still being in RenderFrameHostImpl::OnDidStopLoading,
unfortunately if user connects onLoadingChanged signal
with new url load request this will end up in DiscardUnusedFrame
and delete on RenderFrameHostImpl which is still on the bottom of
the stack. Use QTimer::singleShot to return to the event loop
before emitting load handling signals.
Post all load handling calls with singleShot to avoid out of order
load "signals" delivery in some cases.
Emitting signals should be done from WebContentsAdapterClient to
make sure the destruction of WebConentAdapterClient prevents
emitting signals on already deleted adapter.
Task-numbmer: QTBUG-65813
Change-Id: I93263876fb14bd959ba951463c8aeb5155f04a4f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
| |
The 32bit compiler is required for creating v8 snapshots.
Task-number: QTBUG-65004
Task-number: QTBUG-64869
Change-Id: I0a7a351208768f0b12900fac14d3abd5c8d99fa2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |\
| |
| |
| | |
refs/staging/5.10
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/core/download_manager_delegate_qt.cpp
Change-Id: Ica57e582a323c6bd014a64bb615dd9454e656548
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-62640
Change-Id: I2b16f24533b38c20a7071319723382ba240e35f3
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The glXCreatePbuffer() documentation states that the attributes list
must be terminated with "None or NULL". However, GLX_NONE does not
have a null value. Mesa is sensitive to this.
Change-Id: I9606d95a6a0dadec446496abb8e0213950e3d700
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Destroy WebContentsDelegateQt before WebContents, since it
references already partly deleted WebContentsAdapterClient object.
This prevents calls by navigation handling on already destructed
web contents adapter client.
Task-number: QTBUG-65647
Task-number: QTBUG-47945
Change-Id: I0ed5887b337a43ab89ecbfe05130691b5f1f37ec
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently we need pkg-config host for cross-builds to build
build tools. Unfortunately if build environment exports
PKG_CONFIG_* variables pkg-config will pick them up also for host builds,
which can lead to compile errors. Create pkg-config-host_wrapper
which explicitly unsets PKG_CONFIG_* variables.
This is a temporary workaround till proper solution is implemented
in qtbase.
Task-number: QTBUG-65079
Change-Id: I9aff4a27ba62e096ed4c023cf022a41833260178
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Margins were applied two times: PrintViewManagerQt included them when
rendering to a temporary PDF, then QPrinter applied them when printing.
This patch changes the parameters of PDF generation to not contain the
area of margins. This way the user-provided QPrinter can handle it
without any kind of customization.
Task-number: QTBUG-65715
Change-Id: Ie32785857e5195aa21c6e2ccb7ebd1e6f6ecd954
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Use 'enable_precompiled_headers' instead of
'disable_precompiled_headers'
Change-Id: I23af6fe1c24a6ccc14d31f009710ebbc4cc2f716
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Triple click selects the entire paragraph and it should be
deselected on a quadra click.
Task-number: QTBUG-65649
Change-Id: I87c9405a202d8b6eacd7c19dbbcb051756c41220
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| | |
Pass Qt precompiled header settings to GN.
Change-Id: I4133c2fc77b50028be3ebb8feec24d49476e5e2d
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
...because the generated source files contain include directives with
relative paths that are too long for the toolchain.
Task-number: QTBUG-65677
Change-Id: I664309c16f7ac5cdd267f9463d061be90dc664a0
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |\|
| |
| |
| | |
Change-Id: I4aae316c9826d8ded09e673a01935dc07f13cd64
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Change order of parsing buildtools.pro to avoid
missing toolchain generated files.
Change-Id: I40456cbf38573903c119313d036e4c2aea039b16
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It is default off at run-time anyway.
Also updates 3rdparty with:
17e4aafb6fe8 [Backport] Clamp performance.now() to 100us.
f0775ea93ab6 Fix building with enable_reporting=false
Change-Id: I4d7c0423fff5ecd0291ffdc9bddb90050ed61d8c
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |\|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
src/core/web_contents_adapter.cpp
src/webengine/api/qquickwebengineprofile.cpp
src/webenginewidgets/api/qwebengineprofile.cpp
tests/auto/widgets/qwebenginedownloads/tst_qwebenginedownloads.cpp
tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp
Change-Id: I56c093ebab5ee8b577783ce71761719159cd3ddd
|
| | |\
| | |
| | |
| | | |
refs/staging/5.9
|
| | | |\
| | | |
| | | |
| | | | |
Change-Id: I63420b008c4511022868175ebac60949cf8aa434
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Pull in SPECTRE mitigation
Change-Id: I3849adce737c5518d02a5b27431bac50224c2065
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Pulling in the second set of security patches from Chrome 63.
Changes:
eebf32c32027 [Backport] Fix UAF in SetVisible().
a6ca6057e7e9 [Backport] [BlobStorage] Fixing potential overflow
0f0ad4d73977 [Backport] Fix a range bug in Persian calendar
81ed5d7a47a2 [Backport] Cherry-pick the entire fix for Persian calendar
9b1e7a460573 [Backport] Add size_t variants of constant-time functions.
941bccbf33f5 [Backport] Clear bottom three bits of password scalar in SPAKE2.
1f43353c961a [Backport] Change the script mixing policy to highly restrictive
Task-number: QTBUG-65042
Change-Id: I668700e17f89297bbf2593a248f301f56904c72c
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Pulling in the first set of security patches from Chrome 63
Changes:
4318c22e5167 Add missing .gitattributes -file in 3rdparty submodule
eb4e4c294b56 [Backport] Fix OOB Write in QuicStreamSequencerBuffer::OnStreamData
13d8b0ed6a3a [Backport] Remove unsafe align4 call
93362702cc7e [Backport] Don't clear DnsAttempts that have received a response
eeffcf490fd6 [Backport] Serialize struct tm in a safe way.
864b219901f8 [Backport] Simplify / fix SkBitmap::ReadRawPixels()
13827fc77195 [Backport] Resource Timing: Do not report subsequent navigations within subframes
07527dc5cae2 [Backport] Make CPWL_Wnd classes be observable.
0ce0976538dc [Backport] Setting focus on a widget may destroy the widget
Task-number: QTBUG-65042
Change-Id: I6bb1b93d37111ada696ae77c2b2c04ecc17d2ca3
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Moves QWebEngineBrowserContext to core and makes use of it from both
widget and qml.
Change-Id: I34748f302b0515b11b5831690d28478dfa6a852b
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Unlike QNetworkProxy, Chromium's net::ProxyServer expects the hostname and port
to be at default values for special schemes (DIRECT and INVALID). Otherwise, a
DCHECK is triggered at proxy_server.cc:73.
Change-Id: I1ac6c425ea03fcbfe084d25c2fd05bf174c753d6
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Guard QTemporaryDir::filePath (5.9) usage in the drag and drop implementation.
- Guard QQuickItem::mapToGlobal (5.7) usage in the Quick context menu
implementation.
Change-Id: If383fa55fbbd1b2a3fe4abd57373598a1703786c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Reduces amount of memory used when compiling and is more friendly when
compiling using icecream.
Change-Id: I3ba3afcaa75ee79e02f2a8b2fa6d8f19e5f7b929
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-64726
Change-Id: Ic88eed62e85ad1d95afcbd154c6556509e42bd47
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Changes:
44b6c003b1 Adapt sanitizer rules to Qt WebEngine build
5fd3b69840 [Backport] Disable SharedArrayBuffer by default.
Change-Id: Iec315a976e41029742a30aadf8cbf591aed2cb10
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes a race-condition crash the device is deleted when the
job delegate dies. Happens for instance when the device has the
job delegate as parent.
Change-Id: I5041bbd5747dddb18022044a310ccb5a5985f098
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
.qmake.conf
src/core/api/qwebengineurlrequestjob.cpp
src/core/browser_context_adapter.cpp
src/core/renderer/user_resource_controller.cpp
src/core/web_engine_context.cpp
src/webenginewidgets/api/qwebenginepage.cpp
Change-Id: I5278e5e22e1776d42975fc94d70ff8ca4f81fb9a
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
After we keep around the browser-context after the profile is deleted
it was keeping pointers to deleted objects and would sometimes use them
on shutdown.
Change-Id: Ib67d0ee0b27cb1a1b64d9b8b4c348ed418b9bbc3
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Static function ScreenWin::GetSystemMetricsInDIP returned an incorrect
(already scaled) size for the scrollbars. To take system scaling into
account an instance of the ScreenWin singleton has to be created once.
So let's use ScreenWin directly, instead of DesktopScreenQt, which is
just a mock object anyway.
[ChangeLog][Windows] Fixed issues with too large scrollbars on
Hi-DPI monitors.
Task-number: QTBUG-60705
Change-Id: I7cbc10e98b2a5217b0a0e78afb32818c1cb199d7
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It's used from another thread, so it shouldn't be deleted immediately,
and it's not deleted by the QtWebEngine code, so tell people to do it
themselves at the right time.
Change-Id: I54786be320f5fe82f144e7b1c2e6137260d9ceab
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| | |
2ee59e45bd Fix hanging of process when application is closed too fast
cdecf3ca05 Silence most spurious warnings with gcc
Change-Id: I220ec63538e13cd5e71552a5f6d99de564a3f0ea
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The docs were wrong in that the default is actually text/plain with
US-ASCII encoding (see e.g. data_url_unittest.cc).
Anyhow, saying it might change in the future does not help anyone,
and is actually a potential security risk - see e.g. the discussion
about 'magic' in QTextEdit::setText(). Because of this, it's
unlikely that Chromium ever changes the default. Anyhow, we can as
well hardcode the default, and document it then.
Change-Id: I949111598a30fa69d152d3e98d76e9d96df92d54
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When printing very large documents using the QPrinter-based API, it
was possible to run out of memory because the images that pdfium has
generated was cached for reuse when printing multiple copies of the
document.
Caching the images is now removed as printing multiple copies is not
the default use case and is nowadays often also handled by the printer
itself.
Task-number: QTBUG-58400
Change-Id: I27bd17b33a839a845ca1b387b0c3bd0466b6592f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
The method currentTimeForEvent() tried to access the timestamp() method
for a QEvent::Leave event. Leave events are regular QEvents and not
QInputEvents, and thus have no such method.
Change-Id: Iecc20d239b0e2a5b39b995dabdd7ca8fb44491aa
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Software layers (added in qtdeclarative 5.8) also need updating.
Task-number: QTBUG-62867
Change-Id: If7a941d7e360871822e1776cde3845abcb1f7efa
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | |
| |
| |
| |
| |
| | |
Task-number: QTBUG-64967
Change-Id: Ida79d6cdb682d510e9a2e91e3e3ca263acf34a99
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It can according to documentation potentially be null, even if it might
not happen in our cases.
Task-number: QTBUG-63854
Change-Id: I76029c83fe32c163c2707568fe81b7590a79b4fe
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Hide tooltip on empty text and make tooltips more fluent by ignoring
duplicate requests.
Task-number: QTBUG-64933
Change-Id: Ib82cb06ceda938548429cd694b849a2faadd2633
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-64812
Change-Id: I9df71253cf6c541622e431b1ff444fc49269d0c3
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Pull in the rest of the Chrome 63 security patches
Changes:
6e4dc78363 [Backport] Serialize struct tm in a safe way.
ccdc643a9e [Backport] [BlobStorage] Fixing potential overflow
f2ffe010d9 [Backport] Fix a range bug in Persian calendar
fb4add52f7 [Backport] Cherry-pick the entire fix for Persian calendar
f67ed4572c [Backport] Clear bottom three bits of password scalar in SPAKE2.
28e6df60ab [Backport] Don't clear DnsAttempts that have received a response
5971c2e515 [Backport] Change the script mixing policy to highly restrictive
Task-number: QTBUG-65042
Change-Id: Ic23e47469c91e53556c63ebf4b3fa6e03e9b8ada
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Pulls into the first set of security patches from Chrome 63
Changes:
ecf956cc0a [Backport] Fix OOB Write in QuicStreamSequencerBuffer::OnStreamData
44d355f3b2 [Backport] Remove unsafe align4 call
d66a2fdf0d [Backport] trim down colortable impl
741f3965b4 [Backport] Simplify / fix SkBitmap::ReadRawPixels()
d0e7830edb [Backport] Resource Timing: Do not report subsequent navigations within subframes
79ef6c0691 [Backport] Do not use NavigationEntry to block history navigations.
7869641c98 [Backport] Setting focus on a widget may destroy the widget
51bfe44529 [Backport] Fix UAF in SetVisible().
Task-number: QTBUG-65042
Change-Id: I2139a45d3d95f26ff378a27777ccdae03a9f2a19
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| | |
This amends commit 656b7fdd2d972946fe980f4089f5e9d01160dc68.
Task-nmuber: QTBUG-65455
Change-Id: I3d8d7017a9dbffd9b2ce020cdce7918b6efaf46a
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
WebEngine prepends "." to domain if one is set
explicitly to the cookie.
Task-nmuber: QTBUG-64732
Change-Id: Ic54531281cf3a26f7a516118b8ecd78a2ac27e4a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
- Get rid of the unused return value
- Instantiate event only when used
Change-Id: I01b93d133a53185c2c87f61ea688be3742511c38
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| | |
224acc2957 Fix hanging of process when application is closed too fast
Change-Id: I7b7e599c982d3af4f62d53f7c69907e31acb3f25
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
3af56a2143 FIXUP: Reduce warning flood when compiling with clang
e82868662a Add all devtools resources to our resource pak
26515640a6 Adapt licenses.py for qdoc needs
dc7aa94b2e Reduce warning flood when compiling with clang
75390a1c00 [Backport] [TabDiscarding] Reset the sudden termination
features flag when renderer dies
4dd3a30491 Fix API to allow InspectElement to work with remote inspector
Task-number: QTBUG-64799
Task-number: QTBUG-58698
Change-Id: I084686222826859a05935c3081114fa05d47b18b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |\ \
| | |
| | |
| | | |
Change-Id: I331f4b2b0348d5ee1fb8ff83803bfc9cd359c2d3
|