| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Update the plugin finder logic everywhere to match with Chrome. This
comes with a small cleanup: collect PDF-related helper functions
scattered around WebEngine in one pdf_util_qt implementation.
Add auto test to catch this recurring issue earlier.
Pick-to: 6.5 6.6 6.7
Task-number: QTBUG-119878
Change-Id: I03b2bd62bebf5b38afc572e0629db106d024e89d
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][WebEngineCore] Add QWebEnginePage::desktopMediaRequested() signal
[ChangeLog][WebEngineQuick] Add QQuickWebEngineView::desktopMediaRequested() signal
Pick-to: 6.7
Fixes: QTBUG-112142
Task-number: QTBUG-70077
Change-Id: I4bfad88732b45fb68b77f7617440bcb50b248a11
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
| |
Implement QWebEngineClientHints class to provide API for each
user agent client hints.
Task-number: QTBUG-112826
Task-number: QTBUG-112825
Change-Id: I3091d60fb363bbafc16c8e48195c1fd82e8a81bb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
| |
|
|
|
| |
Change-Id: I8eea99a472cc597ff9864b570c90b28b79b3751e
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
|
|
|
|
|
|
| |
Apparently didnt affect test results though
Pick-to: 6.6
Change-Id: I86809e6287ba7ca80209146c73a0cc0d523756ac
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
|
|
|
|
|
|
|
|
| |
Add missing header include.
Do not compile global setting tests as it tests so far
only doh and requires ssl.
Fixes: QTBUG-119525
Change-Id: I011cd3b0ed6e9d5e55e1fc80a102cc7a388681f1
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
|
|
|
|
|
|
|
|
| |
- DCHECK hit while running tst_QQuickWebEngineViewGraphics test.
- Added qWaitForWindowExposed() to wait for the windows, and then perform the verification.
Pick-to: 6.6
Change-Id: Ia5c2dba5f1c38ae06e7aac24f0f6d5f3d6f5859d
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
| |
|
|
|
|
|
|
|
|
| |
Not only tables can have cell as a child.
Pick-to: 6.5 6.6
Fixes: QTBUG-119023
Task-number: QTBUG-113859
Change-Id: Ic997f752059f5ac3cac9a7d7cf1fefcecbc2ddd5
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a QWebEngineUrlRequestInterceptor has added extra headers to
the request on profile level, later the request was not processed
by the page interceptor. Relax this rule and only prevent the
interception of blocked or redirected requests.
Add auto test and extend documentation.
Pick-to: 6.6
Task-number: QTBUG-117752
Change-Id: I503bfc256a5e874a678be64c597c74e04e7ce966
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
| |
The pointer to the page interceptor is stored in WebContentsAdapter
and we lose it when recreating the adapter. Prevent this and add
auto test.
Fixes: QTBUG-117867
Pick-to: 6.6
Change-Id: I5e79cdcc5996bdf2bb53c3016d4133f978ccfb39
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
We have constant crashes on apple m1 with those test,
skip it for now.
Verify window in comboBoxPopupPosition* tests.
Pick-to: 6.6
Change-Id: I4b9744fbcae556bc8d17e7602d003f306f54c62d
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Calling QWebEngineDownloadRequest::cancel() had no effect if the download
request was accepted by default. These downloads had no corresponding
internal DownloadItem yet, but we tried to cancel them using the
DownloadManager. The safest option is to always check if the DownloadItem
exists in Chromium.
Pick-to: 6.6
Task-number: QTBUG-117624
Change-Id: I8f92d45e00e088aea7d22d5b7271b5b09adf6cbb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
-Duplicate entries in the QML type file are created when exporting the type as a value and its enums within a namespace.
Resolved this by introducing a derived class, and using it for exporting the Enums.
- Added namespace resolution to avoid type ambiguity
Fixes: QTBUG-117031
Pick-to: 6.6
Change-Id: Ieea4492238843c3c781c8d9602ddc89207b61137
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Images and PDFs had to be explicitly accepted to download, even if a
filePath was given as argument of QWebEnginePage::save(). This behavior
was inconsistent with saving HTML pages (and the documentation).
Adjust the corresponding test case with verifying the download result
of an auto-accepted download, and add a new test case to make sure about
downloads are not accepted by default when there is no desired filePath.
Pick-to: 6.6
Task-number: QTBUG-117624
Change-Id: I90f4cfa485da2831327bcb25571a0b69499d9006
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the filePath argument of QWebEnginePage::save() is ignored
when the user tries to download anything but HTML; and the requested
download path is the Downloads folder of the OS.
Fix this and adjust the corresponding test case with checking path
and file name of the download request.
Pick-to: 6.6
Task-number: QTBUG-117624
Change-Id: Ia1d3afc898b1aad223aab772b775724a50e88bd3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
| |
Fix a race-condition in our tests that the change exposed
Pick-to: 6.6
Task-number: QTBUG-116478
Change-Id: Id21c6b0bc9934fdcb69bd85350f5f263a9b96914
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium introduced the Initial NavigationEntry that meant to
represent the initial empty document at FrameTree creation time.
It is just a placeholder entry put in the list of NavigationEntries
that gets replaced on the next navigation.
A side effect of this is that we have an extra entry in the list before
we load any page.
This change also reverts the history related tests modified by
106 Adaptations that introduced this behavior.
Fixes: QTBUG-117489
Pick-to: 6.5 6.6
Change-Id: I2738591b681082792544bd884f8ecec54ce9d72d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
| |
Enable forcibly modifying content rendering to result in dark color scheme.
[ChangeLog][Settings] ForceDarkMode added, disabled by default.
Fixes: QTBUG-84484
Change-Id: I4b3512dc365c61da8f91d8dead0715dadce91f75
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebContentsImpl::IsSavable() decides which file formats are saveable,
but it allows this only for text-based files. All other files will go
around on the code path of downloading. MHTML (multipart) and PDF files
are saved like this, which means they aren't marked as isSavePageDownload.
Just simply set this flag if the save was requested by the user even if
it was a download.
This fixes the flag for saving MHTML and PDF files from context menu,
and leaves the flag false when a PDF download was initiated by the
button of the web UI.
Pick-to: 6.6
Task-number: QTBUG-114859
Change-Id: Id65f26a96952c5a43876338ad37f40570e544f3a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
| |
qmltests::WebEngineViewSingleFileUpload::test_acceptSingleFileSelection
and
tst_QWebEngineView::textSelectionOutOfInputField
Pick-to: 6.6
Change-Id: Ica3e91f109ae2a43bff9cd25e0da7d363823a762
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
|
|
|
|
| |
cocoa qpa uses it.
Pick-to: 6.6.0 6.6 6.5 6.5.3
Fixes: QTBUG-115994
Change-Id: Ie9556169add96946b71299066b8db92bee23066e
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use ScopedConnection to avoid "stack-use-after-return" address
sanitizer error.
Also reduce potential wait time in case of failure by waiting
for accepted and finished states individually (same as
tst_QWebEngineDownloadRequest tests).
Pick-to: 6.6
Fixes: QTBUG-116738
Task-number: QTBUG-56093
Change-Id: I49a60c95a816ae1b4cb6b227501ff81ca9c6f82b
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Do comments from api review:
* use static setDnsMode
* use struct for mode and server templates
* remove QObject
* do not use QScopedPointer
* use the namespace instead of the class
Pick-to: 6.6
Change-Id: I766626330e4cc190a170fcd6b5e32b1f60ad675c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
| |
To allow duplicate key values and preserve order within multi key
duplicates
Pick-to: 6.6
Change-Id: I8da0a3441255c9b72256d63f4ede10491c96c2dc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
|
|
|
|
|
|
|
| |
For consistency with other response headers, even if it is going
to be inconsistent with existing request headers.
Pick-to: 6.6
Change-Id: I9e9c36ac20982d9c833486171fa9944c9059f471
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It has been found to not have any real effect, therefore, we remove it
again to not release a non-functional API and create false expectations
in users.
This reverts commits
3f5de5fab74e6c152cdf5d04f3d893feaa31790b
ab21f39c6a54be331dd8a155d3374bfe790e0274 (parts)
082eef1916a86d6d5e0c751d271c7c8a1a5e457d
5e257fb57a211f95556ec387fe6f262a60cbb6fe
Pick-to: 6.6
Task-number: QTBUG-61071
Change-Id: Ifb33e32128e77dfffed863a1a7501ba21796692d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not actually used, ../../touchbrowser/touchmockingapplication.cpp
is.
I actually started editing this file when I noticed that nothing was
changing. Do the next guy a favor and remove this stale file.
Amends c89fcec0bcb65aae737f2dd733790f74e4303114.
Task-number: QTBUG-100417
Pick-to: 6.6
Change-Id: I4e08db66e62aaa1b7bcbfb61ea060881c16a48f2
Reviewed-by: Martin Negyokru <negyokru@inf.u-szeged.hu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The density of Q_FOREACH uses is non-negligible here, too high for
this author, still unfamiliar with this module, to tackle in a short
amount of time. But they're concentrated in just a few TUs, so pick a
different strategy:
Mark the whole module with QT_NO_FOREACH, to prevent new uses from
creeping in, and whitelist the affected TUs by #undef'ing
QT_NO_FOREACH locally, at the top of each file. For TUs that are part
of a larger executable, this requires these files to be compiled
separately, so add them to NO_PCH_SOURCES (which implies
NO_UNITY_BUILD_SOURCES, too). Created QTBUG-115805 to keep track of
this.
Task-number: QTBUG-115805
Change-Id: I7a80b1820972687ccced24d9edd7a8f5b826556f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][QtWebEngineQuick][WebEngineProfile] Added
clearHttpCacheCompleted signal.
[ChangeLog][QtWebEngineCore][QWebEngineProfile] Added
clearHttpCacheCompleted signal.
Fixes: QTBUG-89670
Fixes: QTBUG-111541
Change-Id: If93a99f7171c516ef75a3c8004da9ae621705a1a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
|
|
|
|
| |
Naviagte away from reload.html as it may reload
multiple times.
Task-number: QTBUG-105342
Task-number: QTBUG-116165
Change-Id: I5dc6b7eeb9827a13752f476f2e3b0c415cedbb43
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We kept urls in examples to point to company website.
However this site is heavy to load and moreover it changes
overtime leaving example screenshots obsolete.
Introduce internal qt version web ui page which will
be default page for examples and which displays basic
information and can work offline.
For start show version info and command line options
for chrome://qt
Pick-to: 6.6
Change-Id: I0271ce6e7b152efe4942a6240b0c74ba382d5fcc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
| |
We prefer to name settings with Enabled at the end.
From API review.
Pick-to: 6.6
Change-Id: I7aacc6dbb92d852fd21b067475d2fd9e7df56163
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch improves the DNS-over-HTTPS configuration and sets defaults
for the general DNS logic. The following changes are included:
- Insecure Chromium DNS client is always OFF (OFF is the Chromium
default as well)
- Add DnsMode::SystemOnly, which configures Chromium to only use the
system DNS
- The default DNS configuration is DnsMode::SystemOnly
- Rename DnsMode::Secure to DnsMode::SecureOnly and
DnsMode::WithFallback to DnsMode::SecureWithFallback to be clearer
what each enum value does
- Add error handling for invalid URI templates
- Added test cases to handle the new logic
- Some minor refactoring for cleanup purposes with the new defaults and
logic taken into consideration
- Some minor bug fixes
Task-number: QTBUG-98284
Pick-to: 6.6
Change-Id: Ie332166f8b5b83c8939af35e4eb8b69b417abdcf
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- test_findTextInterruptedByLoad:
Remove whitespaces from the text as it takes lot
of time to render according to perf.
It should fix the timeout errors.
- loadStartedAfterInPageNavigation:
Remove the viewport meta tag from test.html.
The 2x scale is only applied in embedded builds,
it puts some elements out of the view.
- acceptNavigationRequestNavigationType:
Refresh the reload.html page only once.
On qemu it may reload multiple times messing up
the list of navigation types.
- horizontalScrollbarTest:
Skip instead of blacklist.
- tst_qtbug_110287:
Use an url that loads faster.
Pick-to: 6.6
Task-number: QTBUG-105342
Change-Id: Ifbd41885fee62b12f7022534f9b8bd5e20cbef01
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
| |
The error page is not relevant for the test but it can significantly
slow down the test because of the embedded javascript.
Pick-to: 6.6
Change-Id: I8b7e876f74110f758c5a23579018c598a29ba1e2
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The accessibility tree serialization may happen before the layouting is
completed. This means that during the serialization some children may
have not been created yet and results different roles for elements.
It has been broken by enabling the TimedHTMLParserBudget optimization:
https://crrev.com/c/4152859
Pick-to: 6.6
Change-Id: I798a8ed5bd704a6900c7b56f462091b79a12815d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QtPositioningHelper now uses the Qt Permissions API. Also fixup the
examples Simple Browser, Quick Nano Browser and Maps to use the right
key on macOS and sign the application as part of the build process
Moves the Geopermission auto tests to manual tests for webenginequick
and webenginewidgets on macOS.
Pick-to: 6.6
Fixes: QTBUG-114939
Change-Id: Id6771889f20c866d2fcdbb477dbbb7da30367043
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
|
|
|
|
| |
Additionally make destructor out of line in
qwebengineurlrequestinterceptor as it mirrors
qwebenigneurlresponeinterceptor.
Pick-to: 6.6
Change-Id: I0cdf7eae9faa671415359368560fb8f6aabf05fe
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
| |
- Implemented AuthenticatorRequestClientDelegateQt support to handle authenticator requests.
- Added FIDO user verification and resident credential support
Fixes: QTBUG-90938
Fixes: QTBUG-90941
Change-Id: I6367791e1e9e8aaac27c376408377f838832f426
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
|
|
|
|
|
|
| |
The wait took too long. Rewrite it to be race safe, and increase timeoue.
Pick-to: 6.6
Change-Id: I18c8e17621502bfcfaa739d900ea64e33d0678f6
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
With the invalid 'width' attribute the input element
defaults to a size that depends on the system (charmap) settings.
It may result in failing tests that depend on the size of the element
e.g. tests that use 'elementCenter'.
Pick-to: 6.5 6.6
Task-number: QTBUG-105342
Change-Id: I508d365fc4240d67d3e2240e8e33495c1de6ee4c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
| |
Pick-to: 6.6
Change-Id: I1bb84b20a080d7f615bf0795ac2d97739e99ac1d
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
|
| |
Pick-to: 6.6
Change-Id: Ibe750d541dba458f2278632355bcaf864fdc845a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
|
|
|
|
|
|
| |
ICU has to be initialized to make it work.
Pick-to: 6.6
Change-Id: Icff7cd4d7b93768d46c02612d9f477bfc2b6230e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a WebView or WebEngineView gets a mouse or touch grab, we don't want
to give it up to any handlers that may be lurking on Items underneath.
WebView is opaque, so we don't know whether the user is trying to drag a
scrollbar or something else, but interactive items outside shouldn't
interfere, in general.
[ChangeLog][QtWebEngineQuick] WebEngineView (or WebView backed by Qt
WebEngine) no longer allows components outside to take over the mouse or
touch exclusive grab. For example if the user starts dragging a
scrollbar inside the web view, that continues until release, regardless
of any DragHandler, Flickable etc.
Fixes: QTBUG-103518
Pick-to: 6.5 6.6
Change-Id: I4352dc8482020f0efc7a0901e94ccf7fc147fa1b
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
|
|
|
| |
Add ResourceRequestBody to QWebEngineUrlRequestJob, thus exposing the
request body to custom URL scheme handlers.
Fixes: QTBUG-67055
Change-Id: I0a31dfdbb4e3353dc1e469234ba452a0cbfd5965
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
|
|
|
| |
This patch implements a QIODevice subclass that gives access to the
request body inside QWebEngineUrlRequestInterceptor::interceptRequest().
Fixes: QTBUG-61320
Change-Id: Ib6010dad908c65e070d63927b619eaed2347e317
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
| |
The pdfquick subdir was added when the target Pdf was found.
This breaks the build if PdfQuick is not compiled.
=> make adding the subdir conditional to PdfQuick.
Pick-to: 6.6 6.5
Change-Id: I9f46d4254c402f7f1dbde8a899edffd3f8b21c4e
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Invalid proxy settings may result in a crash in chromium.
Use chromium's helper function that validates proxy configs
instead of constructing net::ProxyServer manually.
On invalid input, result will be a `SCHEME_INVALID` ProxyServer.
Fixes: QTBUG-113992
Pick-to: 6.5 6.6
Change-Id: I1745ae3c3cd4da40d3d8b92a14f752ac9b3f8d31
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
|
|
|
|
|
| |
Make the constructor explicit, add explicit external destructor.
Use QMultiMap instead of QHash for request headers, as those can
potentially be repeating.
Pick-to: 6.6
Change-Id: Id1730b015971287e63562ac67cfa964f2abbb7cc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|