Return to Question

deleted 6 characters in body

Source Link

edited Nov 25, 2013 at 1:28

I've implemented a working version of Array#uniq in Ruby to answer the question here: http://www.rubeque.com/problems/like-a-snowflake, but I'd like to see if there's ways to clean up my code or some better practices I should follow? This is my version:

class Array
  def uniq(&block)
    @objsobjs = []
    @yield_valsyield_vals = []
    self.each do |obj|
      yield_val = yield obj
      unless @yield_valsyield_vals.include?(yield_val)
        @yield_valsyield_vals.push(yield_val)
        @objsobjs.push(obj)
      end
    end
    @objsobjs
  end
end

class Array
  def uniq(&block)
    @objs = []
    @yield_vals = []
    self.each do |obj|
      yield_val = yield obj
      unless @yield_vals.include?(yield_val)
        @yield_vals.push(yield_val)
        @objs.push(obj)
      end
    end
    @objs
  end
end

class Array
  def uniq(&block)
    objs = []
    yield_vals = []
    self.each do |obj|
      yield_val = yield obj
      unless yield_vals.include?(yield_val)
        yield_vals.push(yield_val)
        objs.push(obj)
      end
    end
    objs
  end
end

Source Link

asked Nov 25, 2013 at 1:05

TenJack

Implementing Array#uniq in Ruby

class Array
  def uniq(&block)
    @objs = []
    @yield_vals = []
    self.each do |obj|
      yield_val = yield obj
      unless @yield_vals.include?(yield_val)
        @yield_vals.push(yield_val)
        @objs.push(obj)
      end
    end
    @objs
  end
end

ruby array