Remove overzealous _bt_killitems assertion.
authorPeter Geoghegan <pg@bowt.ie>
Fri, 10 Oct 2025 18:52:12 +0000 (14:52 -0400)
committerPeter Geoghegan <pg@bowt.ie>
Fri, 10 Oct 2025 18:52:12 +0000 (14:52 -0400)
commitaf302ff6b84ab136533e98b69f645fc271338915
treed2658d24e1574322879a860036dbd5dab3f477d2
parentc878d98084208551e6c44ede046c4d7a5be9dc56
Remove overzealous _bt_killitems assertion.

An assertion in _bt_killitems expected the scan's currPos state to
contain a valid LSN, saved from when currPos's page was initially read.
The assertion failed to account for the fact that even logged relations
can have leaf pages with an invalid LSN when built with wal_level set to
"minimal".  Remove the faulty assertion.

Oversight in commit e6eed40e (though note that the assertion was
backpatched to stable branches before 18 by commit 7c319f54).

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl>
Bug: #19082
Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org
Backpatch-through: 13
src/backend/access/nbtree/nbtutils.c