Fix busted Assert for CREATE MATVIEW ... WITH NO DATA.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 11 Aug 2016 15:22:25 +0000 (11:22 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 11 Aug 2016 15:22:25 +0000 (11:22 -0400)
commit268d92e5336d25b296a5ccf8ccf803a2adb40251
tree943b7398707b7fb09131ae6a6915f14cd6e58645
parent042b6beeeb17ec34ea0764921574f2d8a2761472
Fix busted Assert for CREATE MATVIEW ... WITH NO DATA.

Commit 874fe3aea changed the command tag returned for CREATE MATVIEW/CREATE
TABLE AS ... WITH NO DATA, but missed that there was code in spi.c that
expected the command tag to always be "SELECT".  Fortunately, the
consequence was only an Assert failure, so this oversight should have no
impact in production builds.

Since this code path was evidently un-exercised, add a regression test.

Per report from Shivam Saxena. Back-patch to 9.3, like the previous commit.

Michael Paquier

Report: <97218716-480B-4527-B5CD-D08D798A0C7B@dresources.com>
src/backend/executor/spi.c
src/test/regress/expected/matview.out
src/test/regress/sql/matview.sql