Make HEAP_LOCK/HEAP2_LOCK_UPDATED replay reset HEAP_XMAX_INVALID.
authorAndres Freund <andres@anarazel.de>
Fri, 15 Jul 2016 21:37:06 +0000 (14:37 -0700)
committerAndres Freund <andres@anarazel.de>
Fri, 15 Jul 2016 21:50:46 +0000 (14:50 -0700)
commitf66828ba6e6bb0024433b4cb88afc4d7cecbf278
tree6678baba30a6b76673e1cc7729ad674934f03582
parent166873dd0c3083884ed16ce17f29f67ac8a64641
Make HEAP_LOCK/HEAP2_LOCK_UPDATED replay reset HEAP_XMAX_INVALID.

0ac5ad5 started to compress infomask bits in WAL records. Unfortunately
the replay routines for XLOG_HEAP_LOCK/XLOG_HEAP2_LOCK_UPDATED forgot to
reset the HEAP_XMAX_INVALID (and some other) hint bits.

Luckily that's not problematic in the majority of cases, because after a
crash/on a standby row locks aren't meaningful. Unfortunately that does
not hold true in the presence of prepared transactions. This means that
after a crash, or after promotion, row level locks held by a prepared,
but not yet committed, prepared transaction might not be enforced.

Discussion: 20160715192319.ubfuzim4zv3rqnxv@alap3.anarazel.de
Backpatch: 9.3, the oldest branch on which 0ac5ad5 is present.
src/backend/access/heap/heapam.c