-
-
Notifications
You must be signed in to change notification settings - Fork 49.6k
Improve comments, add doctests to coloring.py #11589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
cclauss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep comments short to not slow down the reader.
The ruff rules D can be quite useful.
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
38d0560 to
9da28b0
Compare
Co-authored-by: Christian Clauss <cclauss@me.com>
42c32e7 to
38d0560
Compare
Co-authored-by: Christian Clauss <cclauss@me.com>
38d0560 to
42c32e7
Compare
Co-authored-by: Christian Clauss <cclauss@me.com>
26321da to
7fafb02
Compare
I have committed the suggested comment changes and marked the changes as resolved. |
|
Please remove the duplicate type hints in comments so the following command passes without errors. |
I'm sorry for missing this! I have removed the argument type hints in the function docstring. |
Added more comprehensive comments and more doctests to each function present in
coloring.py.Checklist: