regression: fixed ARDUINO_USER_AGENT pollution / resolve compile-sketch GH action failure on Teensy (#2669)

cmaglie · web-flow · commit eb286385e7e8 · 2024-07-19T14:49:39.000+02:00
* Removed useless gRPCClientUnknown tag * 'task build' now uses a compliant semver notation * Revert "'task build' now uses a compliant semver notation" This reverts commit 7f8ad1f.
diff --git a/commands/instances.go b/commands/instances.go
@@ -67,9 +67,6 @@ func (s *arduinoCoreServerImpl) Create(ctx context.Context, req *rpc.CreateReque
 	if md, ok := metadata.FromIncomingContext(ctx); ok {
 		userAgent = strings.Join(md.Get("user-agent"), " ")
 	}
-	if userAgent == "" {
-		userAgent = "gRPCClientUnknown/0.0.0"
-	}
 
 	// Setup downloads directory
 	downloadsDir := s.settings.DownloadsDir()

Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,6 @@ func (s arduinoCoreServerImpl) Create(ctx context.Context, req rpc.CreateReque`
`67`	`67`	`if md, ok := metadata.FromIncomingContext(ctx); ok {`
`68`	`68`	`userAgent = strings.Join(md.Get("user-agent"), " ")`
`69`	`69`	`}`
`70`		`- if userAgent == "" {`
`71`		`- userAgent = "gRPCClientUnknown/0.0.0"`
`72`		`- }`
`73`	`70`
`74`	`71`	`// Setup downloads directory`
`75`	`72`	`downloadsDir := s.settings.DownloadsDir()`