Partially revert #e80400b7ddbbc2e8f34f1e6701b55102c3a99289

Author: umbynos

bufferflow.go

@@ -19,7 +19,6 @@ type Bufferflow interface {
 	Init()
 	BlockUntilReady(cmd string, id string) (bool, bool) // implement this method
 	//JustQueue(cmd string, id string) bool                     // implement this method
-	OnIncomingDataBinary(data []byte)
 	OnIncomingData(data string)                               // implement this method
 	ClearOutSemaphore()                                       // implement this method
 	BreakApartCommands(cmd string) []string                   // implement this method

bufferflow_default.go

@@ -20,10 +20,6 @@ func (b *BufferflowDefault) BlockUntilReady(cmd string, id string) (bool, bool)
 	return true, false
 }
 
-// not implemented, we are gonna use OnIncomingData
-func (b *BufferflowDefault) OnIncomingDataBinary(data []byte) {
-}
-
 func (b *BufferflowDefault) OnIncomingData(data string) {
 	//log.Printf("OnIncomingData() start. data:%v\n", data)
 }

bufferflow_timed.go

@@ -61,10 +61,6 @@ func (b *BufferflowTimed) BlockUntilReady(cmd string, id string) (bool, bool) {
 	return true, false
 }
 
-// not implemented, we are gonna use OnIncomingData
-func (b *BufferflowTimed) OnIncomingDataBinary(data []byte) {
-}
-
 func (b *BufferflowTimed) OnIncomingData(data string) {
 	b.Input <- data
 }

bufferflow_timedbinary.go

@@ -57,12 +57,9 @@ func (b *BufferflowTimedBinary) BlockUntilReady(cmd string, id string) (bool, bo
 	return true, false
 }
 
-func (b *BufferflowTimedBinary) OnIncomingDataBinary(data []byte) {
-	b.Input <- data
-}
-
 // not implemented, we are gonna use OnIncomingDataBinary
 func (b *BufferflowTimedBinary) OnIncomingData(data string) {
+	b.Input <- []byte(data)
 }
 
 // Clean out b.sem so it can truly block

bufferflow_timedraw.go

@@ -59,10 +59,6 @@ func (b *BufferflowTimedRaw) BlockUntilReady(cmd string, id string) (bool, bool)
 	return true, false
 }
 
-// not implemented, we are gonna use OnIncomingData
-func (b *BufferflowTimedRaw) OnIncomingDataBinary(data []byte) {
-}
-
 func (b *BufferflowTimedRaw) OnIncomingData(data string) {
 	b.Input <- data
 }

serialport.go

@@ -118,11 +118,9 @@ func (p *serport) reader(buftype string) {
 
 			data := ""
 			switch buftype {
-			case "timedraw", "timed": // data is handled differently inside BufferFlowTimed (bufferedOutput is string) and BufferFlowTimedRaw (bufferedOutputRaw is []byte)
+			case "timedraw", "timed", "timedbinary":
 				data = string(ch[:n])
 				p.bufferwatcher.OnIncomingData(data)
-			case "timedbinary":
-				p.bufferwatcher.OnIncomingDataBinary(ch[:n])
 			case "default": // the bufferbuftype is actually called default 🤷‍♂️
 				// save the left out bytes for the next iteration due to UTF-8 encoding
 				ch = append(buffered_ch.Bytes(), ch[:n]...) // TODO ch is not handled correctly: doing this way its length is messed up. Use ch2