Check min size of node group and resource limits for set of nodes #5502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d660b80 to
1e8f072
Compare
x13n
reviewed
Feb 14, 2023
Member
x13n
left a comment
There was a problem hiding this comment.
Thanks for the change! A couple of minor comments, otherwise lgtm.
| nodeGroupSize := utils.GetNodeGroupSizeMap(context.CloudProvider) | ||
| for nodeName, v := range n.byName { | ||
| klog.V(2).Infof("%s was unneeded for %s", nodeName, ts.Sub(v.since).String()) | ||
| nodeGroupSize := make(map[string]int) |
Member
There was a problem hiding this comment.
GetNodeGroupSizeMap already allocates a new map, I don't think we need another one.
Contributor
Author
There was a problem hiding this comment.
Right, missed that
1e8f072 to
60a264b
Compare
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x13n, yaroslava-serdiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
For parallel scale down we might scale down below min size of the node group because RemovableAt() verify each node individually. This PR add verification for set of nodes.