Use snapshot of NodeDeletionTracker for ActuationStatus #5562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4acb5e8 to
1afb605
Compare
1874371 to
bd62ff5
Compare
x13n
requested changes
Mar 3, 2023
cluster-autoscaler/core/scaledown/deletiontracker/nodedeletiontracker.go
Show resolved
Hide resolved
| // TODO: snapshot information from the tracker instead of keeping live | ||
| // updated object. | ||
| return a.nodeDeletionTracker | ||
| return a.nodeDeletionTracker.Snapshot() |
Member
There was a problem hiding this comment.
I think ideally we'd just replace ActuationStatus interface with a simple struct that doesn't have the mutex overhead. It would also be simpler to mock in tests. Can you add a TODO for this somewhere? Perhaps next to the interface definition.
bd62ff5 to
7a218f3
Compare
7a218f3 to
156ee9e
Compare
156ee9e to
dec8136
Compare
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x13n, yaroslava-serdiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Node deletions happens in separate go routine, so it's possible that node was removed during unneeded node verification. In such case we have updated number of ongoing deletions but outdated size of the node group, so CA will have wrong verification of min size of the node group.