ext/standard: Refactor and add {s|f}scanf tests #20676
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…printf This effectively tests scanning an empty file line or a file line only containing '1', which is already handled by the string tests
These are not parsing related
A bunch of the test cases are testing the language scanner rules rather than fscanf
This is in preparation for some major refactoring as the current error messages are non-sensical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for some major refactoring.
Most of the
fscanf()tests are pure garbage, as they don't actually test what they are claiming to do.They mostly test
fprintf()and/or casting various values to string on top of how PHP parses integers/floats.As such, I suggest deleting the majority of these nonsensical tests and then write some tests that actually try to examine the behaviour of
{f|s}scanf().TODO and or follow-up: