Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5955~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5955
Choose a head ref
  • 9 commits
  • 15 files changed
  • 2 contributors

Commits on Dec 6, 2025

  1. Refactor: pg_waldump: Move some declarations to new pg_waldump.h 

    This change prepares for a second source file in this directory to
support reading WAL from tar files. Common structures, declarations,
and functions are being exported through this include file so
they can be used in both files.
    @amulsul
    amulsul authored and Commitfest Bot committed Dec 6, 2025
    Configuration menu
    Copy the full SHA
    04e5c84 View commit details
    Browse the repository at this point in the history

  2. Refactor: pg_waldump: Separate logic used to calculate the required r… 

    …ead size.

This refactoring prepares the codebase for an upcoming patch that will
support reading WAL from tar files. The logic for calculating the
required read size has been updated to handle both normal WAL files
and WAL files located inside a tar archive.
    @amulsul
    amulsul authored and Commitfest Bot committed Dec 6, 2025
    Configuration menu
    Copy the full SHA
    9594f35 View commit details
    Browse the repository at this point in the history

  3. Refactor: pg_waldump: Restructure TAP tests. 

    Restructured some tests to run inside a loop, facilitating their
re-execution for decoding WAL from tar archives.

== NOTE ==
  This is not intended to be committed separately. It can be merged
  with the next patch, which is the main patch implementing this
  feature.
    @amulsul
    amulsul authored and Commitfest Bot committed Dec 6, 2025
    Configuration menu
    Copy the full SHA
    f230b05 View commit details
    Browse the repository at this point in the history

  4. pg_waldump: Add support for archived WAL decoding. 

    pg_waldump can now accept the path to a tar archive containing WAL
files and decode them. This feature was added primarily for
pg_verifybackup, which previously disabled WAL parsing for
tar-formatted backups.

Note that this patch requires that the WAL files within the archive be
in sequential order; an error will be reported otherwise. The next
patch is planned to remove this restriction.
    @amulsul
    amulsul authored and Commitfest Bot committed Dec 6, 2025
    Configuration menu
    Copy the full SHA
    19d33db View commit details
    Browse the repository at this point in the history

  5. pg_waldump: Remove the restriction on the order of archived WAL files. 

    With previous patch, pg_waldump would stop decoding if WAL files were
not in the required sequence. With this patch, decoding will now
continue.  Any WAL file that is out of order will be written to a
temporary location, from which it will be read later. Once a temporary
file has been read, it will be removed.
    @amulsul
    amulsul authored and Commitfest Bot committed Dec 6, 2025
    Configuration menu
    Copy the full SHA
    b49e566 View commit details
    Browse the repository at this point in the history

  6. pg_verifybackup: Delay default WAL directory preparation. 

    We are not sure whether to parse WAL from a directory or an archive
until the backup format is known. Therefore, we delay preparing the
default WAL directory until the point of parsing. This delay is
harmless, as the WAL directory is not used elsewhere.
    @amulsul
    amulsul authored and Commitfest Bot committed Dec 6, 2025
    Configuration menu
    Copy the full SHA
    d25e69c View commit details
    Browse the repository at this point in the history

  7. pg_verifybackup: Rename the wal-directory switch to wal-path 

    With previous patches to pg_waldump can now decode WAL directly from
tar files.  This means you'll be able to specify a tar archive path
instead of a traditional WAL directory.

To keep things consistent and more versatile, we should also
generalize the input switch for pg_verifybackup. It should accept
either a directory or a tar file path that contains WALs. This change
will also aligning it with the existing manifest-path switch naming.

== NOTE ==
  The corresponding PO files require updating due to this change.
    @amulsul
    amulsul authored and Commitfest Bot committed Dec 6, 2025
    Configuration menu
    Copy the full SHA
    ae8fb3c View commit details
    Browse the repository at this point in the history

  8. pg_verifybackup: enabled WAL parsing for tar-format backup 

    Now that pg_waldump supports decoding from tar archives, we should
leverage this functionality to remove the previous restriction on WAL
parsing for tar-backed formats.
    @amulsul
    amulsul authored and Commitfest Bot committed Dec 6, 2025
    Configuration menu
    Copy the full SHA
    67ff887 View commit details
    Browse the repository at this point in the history

  9. [CF 5955] v9 - pg_waldump: support decoding of WAL inside tarfile 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5955

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAAJ_b94SEcBVJcsp0Y1-YvLqZWBHPQH4FhRzSJfaH_ah_eL_FQ@mail.gmail.com
Author(s): Amul Sul
    Commitfest Bot committed Dec 6, 2025
    Configuration menu
    Copy the full SHA
    4d929ad View commit details
    Browse the repository at this point in the history
Loading