Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/6139~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/6139
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Oct 22, 2025

  1. Avoid double translation of messages for invalid primary_slot_name. 

    When primary_slot_name is invalid, ReplicationSlotValidateNameInternal()
returns already translated error messages (when NLS is enabled). Previously,
the check hook for primary_slot_name passed these messages to
GUC_check_errdetail() and GUC_check_errhint(), which could retranslate
them and cause double translation.

To fix this, this commit adds GUC_check_errmsg_internal(),
GUC_check_errdetail_internal(), and GUC_check_errhint_internal().
These work like their counterparts but skip translation. The check hook
for primary_slot_name now uses these new functions when handling
messages from ReplicationSlotValidateNameInternal().
    @MasaoFujii
    MasaoFujii authored and Commitfest Bot committed Oct 22, 2025
    Configuration menu
    Copy the full SHA
    ec9e727 View commit details
    Browse the repository at this point in the history

  2. [CF 6139] v7 - Invalid primary_slot_name triggers warnings in all pro… 

    …cesses on reload

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/6139

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAHGQGwHJxhaQQ7bf_wPBYBTJO+X+rK_-znsgay_kYm2ncJYAGQ@mail.gmail.com
Author(s): Fujii Masao
    Commitfest Bot committed Oct 22, 2025
    Configuration menu
    Copy the full SHA
    ed1da4a View commit details
    Browse the repository at this point in the history
Loading