Skip to content

review: refactor: Controlflow cleanup #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Mr-Pine wants to merge 32 commits into
base: master
Choose a base branch
from
Open

review: refactor: Controlflow cleanup #5733

Mr-Pine wants to merge 32 commits into from

Conversation

@Mr-Pine
Copy link
Contributor

@Mr-Pine Mr-Pine commented Apr 5, 2024

The control flow module is in dire need of a (spring) cleaning. As it is currently spring, this PR does at least some of the work, including:

  • Moving to a better package name
  • Removing unused and broken code
  • Finding better replacements for single letter variables
  • Move to modern java features such as enhanced switch expressions and type patterns
  • Updating dependencies
  • Fixing broken javadoc comments
  • Replacing raw types

@Mr-Pine Mr-Pine mentioned this pull request Apr 5, 2024
Closed
@Mr-Pine Mr-Pine changed the title Controlflow cleanup review: Controlflow cleanup Apr 5, 2024
@Mr-Pine Mr-Pine changed the title review: Controlflow cleanup review: refactor: Controlflow cleanup Apr 5, 2024
@SirYwell SirYwell requested a review from MartinWitt April 6, 2024 08:57
@MartinWitt MartinWitt requested a review from SirYwell April 6, 2024 10:05
@MartinWitt
Copy link
Collaborator

MartinWitt commented Apr 6, 2024

Please use mvn com.mycila:license-maven-plugin:4.1:format for the headers.

Mr-Pine added 24 commits April 10, 2024 19:01
@Mr-Pine
Update spoon pom to current version
7c1d9ea
@Mr-Pine
Use Launcher in MetaFactory
4c57655
@Mr-Pine
Clean up ForwardFlowBuilderVisitorTest and ControlFlowArithmetic
61ef636
@Mr-Pine
Remove unnecessary comments and raw types
45fc7e6
@Mr-Pine
Properly format javadoc, remove unnecessary throw
8baab3f
@Mr-Pine
Remove unnecessary print of cfg
f8c8edd
@Mr-Pine
Better formatting for javadoc
283fc65
@Mr-Pine
Rename BranchKind to NodeKind, add better JavaDoc
da7554c
@Mr-Pine
Remove dependency provided by spoon-pom
fa0df40
@Mr-Pine
Clean up ControlFlowBuilder
49dd4e0 
remove unnecessary Overrides
Replace Raw types
@Mr-Pine
Clean up control flow graph elements
7e13d16
@Mr-Pine
Replace else if construct with switch
229e618
@Mr-Pine
Properly render javadoc
0af0a32
@Mr-Pine
Remove creation date
e3f413a
@Mr-Pine
Remove creation date and unnecessary type parameters
d1d6a8b
@Mr-Pine
Clean up value
efdc0da
@Mr-Pine
Remove unnecessary type arguments
237de0c
@Mr-Pine
Update jgrapht version
fb7148f
@Mr-Pine
Clean up pom xml. Version now follows spoon
bb9bd6c
@Mr-Pine
Remove never-used TransferFunctionVisitor and Value (dataflow) from c…
b9c24aa 
…ontrol-flow
@Mr-Pine
Remove uselessAssignmentAnalysis as it was completely broken
78d242d
@Mr-Pine
Clean up InitializedVariables analysis and move it to control flow
c204bfd
@Mr-Pine
Remove unused and unimplemented visitors
708b7a6
@Mr-Pine
Move visitors to control flow package
96ca648
@Mr-Pine Mr-Pine force-pushed the controlflow-cleanup branch from 7d5652e to 511c23c Compare April 10, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinWitt MartinWitt Awaiting requested review from MartinWitt

@SirYwell SirYwell Awaiting requested review from SirYwell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mr-Pine @MartinWitt