From 7cfcff8a3b6a149707aa2f8e7eaf7ffa81072e22 Mon Sep 17 00:00:00 2001
From: Harsh Pathak <156679457+HarshPathak310@users.noreply.github.com>
Date: Tue, 7 Oct 2025 10:21:49 +0530
Subject: [PATCH] Update logical issue in decision_tree.py

---
 machine_learning/decision_tree.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/machine_learning/decision_tree.py b/machine_learning/decision_tree.py
index 72970431c3fc..b4df64796bb1 100644
--- a/machine_learning/decision_tree.py
+++ b/machine_learning/decision_tree.py
@@ -146,14 +146,13 @@ def predict(self, x):
         """
         if self.prediction is not None:
             return self.prediction
-        elif self.left or self.right is not None:
+        elif self.left is not None and self.right is not None:
             if x >= self.decision_boundary:
                 return self.right.predict(x)
             else:
                 return self.left.predict(x)
         else:
-            print("Error: Decision tree not yet trained")
-            return None
+            raise ValueError("Decision tree not yet trained")
 
 
 class TestDecisionTree:
@@ -201,4 +200,4 @@ def main():
     main()
     import doctest
 
-    doctest.testmod(name="mean_squarred_error", verbose=True)
+    doctest.testmod(name="mean_squared_error", verbose=True)