angular-data-grid#11 Text based filter does not filter out empty/null values

Igor Korshuk · Igor Korshuk · commit dbb495ec28e3 · 2016-05-19T16:13:04.000+03:00
diff --git a/dist/dataGrid.js b/dist/dataGrid.js
@@ -365,7 +365,7 @@
 
             function textFilter(items, value, predicate) {
                 return items.filter(function (item) {
-                    return value && item[predicate] ? ~(item[predicate] + '').toLowerCase().indexOf((value + '').toLowerCase()) : true;
+                    return value && item[predicate] ? ~(item[predicate] + '').toLowerCase().indexOf((value + '').toLowerCase()) : !!item[predicate];
                 });
             }
 
diff --git a/dist/dataGrid.min.js b/dist/dataGrid.min.js
diff --git a/src/js/dataGrid.js b/src/js/dataGrid.js
@@ -365,7 +365,7 @@
 
             function textFilter(items, value, predicate) {
                 return items.filter(function (item) {
-                    return value && item[predicate] ? ~(item[predicate] + '').toLowerCase().indexOf((value + '').toLowerCase()) : true;
+                    return value && item[predicate] ? ~(item[predicate] + '').toLowerCase().indexOf((value + '').toLowerCase()) : !!item[predicate];
                 });
             }
 

Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@`
`365`	`365`
`366`	`366`	`function textFilter(items, value, predicate) {`
`367`	`367`	`return items.filter(function (item) {`
`368`		`- return value && item[predicate] ? ~(item[predicate] + '').toLowerCase().indexOf((value + '').toLowerCase()) : true;`
	`368`	`+ return value && item[predicate] ? ~(item[predicate] + '').toLowerCase().indexOf((value + '').toLowerCase()) : !!item[predicate];`
`369`	`369`	`});`
`370`	`370`	`}`
`371`	`371`