From 226093cb2c3b55d35477af5398fa7b3c8c78ae49 Mon Sep 17 00:00:00 2001 From: Giulio Pilotto Date: Thu, 27 Nov 2025 09:43:53 +0100 Subject: [PATCH] deprecate require_devices --- internal/orchestrator/bricks/testdata/bricks-list.yaml | 2 -- internal/orchestrator/bricksindex/bricks_index_test.go | 1 - internal/orchestrator/orchestrator_test.go | 2 -- internal/orchestrator/provision.go | 2 +- 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/internal/orchestrator/bricks/testdata/bricks-list.yaml b/internal/orchestrator/bricks/testdata/bricks-list.yaml index 9a8c68c4..e38eeeb4 100644 --- a/internal/orchestrator/bricks/testdata/bricks-list.yaml +++ b/internal/orchestrator/bricks/testdata/bricks-list.yaml @@ -4,7 +4,6 @@ bricks: description: Connects to Arduino Cloud require_container: false require_model: false - require_devices: false mount_devices_into_container: false ports: [] category: null @@ -19,7 +18,6 @@ bricks: local database. require_container: false require_model: false - require_devices: false mount_devices_into_container: false ports: [] category: storage diff --git a/internal/orchestrator/bricksindex/bricks_index_test.go b/internal/orchestrator/bricksindex/bricks_index_test.go index b8bf7c0a..b8d28c07 100644 --- a/internal/orchestrator/bricksindex/bricks_index_test.go +++ b/internal/orchestrator/bricksindex/bricks_index_test.go @@ -148,7 +148,6 @@ func TestBricksIndexYAMLFormats(t *testing.T) { category: storage require_container: true require_model: true - require_devices: false mount_devices_into_container: true model_name: a-complex-model required_devices: diff --git a/internal/orchestrator/orchestrator_test.go b/internal/orchestrator/orchestrator_test.go index d6c6a4dc..ab42d287 100644 --- a/internal/orchestrator/orchestrator_test.go +++ b/internal/orchestrator/orchestrator_test.go @@ -447,7 +447,6 @@ bricks: \ or with custom object detection models trained on Edge Impulse platform. \n" require_container: true require_model: true - require_devices: false ports: [] category: video model_name: yolox-object-detection @@ -533,7 +532,6 @@ bricks: \ or with custom object detection models trained on Edge Impulse platform. \n" require_container: true require_model: true - require_devices: false category: video model_name: yolox-object-detection variables: diff --git a/internal/orchestrator/provision.go b/internal/orchestrator/provision.go index 393fbc8c..c5ab52b6 100644 --- a/internal/orchestrator/provision.go +++ b/internal/orchestrator/provision.go @@ -257,7 +257,7 @@ func generateMainComposeFile( } // 4. Retrieve the required devices that we have to mount - slog.Debug("Brick config", slog.Bool("require_devices", idxBrick.MountDevicesIntoContainer), slog.Any("ports", ports), slog.Any("required_devices", idxBrick.RequiredDevices)) + slog.Debug("Brick config", slog.Bool("mount_devices_into_container", idxBrick.MountDevicesIntoContainer), slog.Any("ports", ports), slog.Any("required_devices", idxBrick.RequiredDevices)) if idxBrick.MountDevicesIntoContainer { servicesThatRequireDevices = slices.AppendSeq(servicesThatRequireDevices, maps.Keys(svcs)) }