move serialportlist inside hub

Author: dido18

hub.go

@@ -60,15 +60,15 @@ type hub struct {
 	systray *systray.Systray
 }
 
-func newHub(serialList *serialPortList, tools *tools.Tools, systray *systray.Systray) *hub {
+func newHub(tools *tools.Tools, systray *systray.Systray) *hub {
 	hub := &hub{
 		broadcast:      make(chan []byte, 1000),
 		broadcastSys:   make(chan []byte, 1000),
 		register:       make(chan *connection),
 		unregister:     make(chan *connection),
 		connections:    make(map[*connection]bool),
 		serialHub:      newSerialHub(),
-		serialPortList: serialList,
+		serialPortList: newSerialPortList(tools),
 		tools:          tools,
 		systray:        systray,
 	}
@@ -132,6 +132,8 @@ func (hub *hub) sendToRegisteredConnections(data []byte) {
 }
 
 func (hub *hub) run() {
+	go hub.serialPortList.Run()
+
 	for {
 		select {
 		case c := <-hub.register:

main.go

@@ -176,9 +176,7 @@ func loop(stray *systray.Systray) {
 	}
 	tools := tools.New(config.GetDataDir(), index, signaturePubKey)
 
-	serialPorts := newSerialPortList(tools)
-
-	hub := newHub(serialPorts, tools, stray)
+	hub := newHub(tools, stray)
 
 	// Let's handle the config
 	configDir := config.GetDefaultConfigDir()
@@ -394,8 +392,6 @@ func loop(stray *systray.Systray) {
 		}
 	}
 
-	// launch the discoveries for the running system
-	go serialPorts.Run()
 	// launch the hub routine which is the singleton for the websocket server
 	go hub.run()
 	// launch our dummy data routine

serialport.go

@@ -241,9 +241,10 @@ func (p *serport) writerNoBuf() {
 
 	p.portIo.Close()
 
-	// NOTE:  by removing the 'serialPorts.List()' line, the list of serial ports are NOT sent to the websocket clients.
-	// after a write is completed. It should not be an issue also because the other two 'writerBuffered' and 'writerRaw' methods
-	// do not call it.
+	// NOTE:  by removing the 'serialPorts.List()' line,
+	// the list of serial ports are NOT sent to the websocket clients  after a write is completed.
+	// This should not be an issue since the list are periodically called.
+	// Note also that the 'writerBuffered' and 'writerRaw' methods do not call it.
 	// serialPorts.List()
 
 }