Skip to content

Commit 11f2411

Browse files
authored
chore(cli): fix issue with running individual sub-tests of Test_Tasks (coder#20646)
Closes coder/internal#1112 Turns out sub-tests aren't ideal when you're running things that depend on each other and need to be run in a certain order.
1 parent 3d411dd commit 11f2411

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

cli/exp_task_test.go

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ func Test_Tasks(t *testing.T) {
5353
taskName = strings.ReplaceAll(testutil.GetRandomName(t), "_", "-")
5454
)
5555

56-
//nolint:paralleltest // The sub-tests of this test must be run sequentially.
5756
for _, tc := range []struct {
5857
name string
5958
cmdArgs []string
@@ -135,16 +134,15 @@ func Test_Tasks(t *testing.T) {
135134
},
136135
},
137136
} {
138-
t.Run(tc.name, func(t *testing.T) {
139-
var stdout strings.Builder
140-
inv, root := clitest.New(t, tc.cmdArgs...)
141-
inv.Stdout = &stdout
142-
clitest.SetupConfig(t, userClient, root)
143-
require.NoError(t, inv.WithContext(ctx).Run())
144-
if tc.assertFn != nil {
145-
tc.assertFn(stdout.String(), userClient)
146-
}
147-
})
137+
t.Logf("test case: %q", tc.name)
138+
var stdout strings.Builder
139+
inv, root := clitest.New(t, tc.cmdArgs...)
140+
inv.Stdout = &stdout
141+
clitest.SetupConfig(t, userClient, root)
142+
require.NoError(t, inv.WithContext(ctx).Run(), tc.name)
143+
if tc.assertFn != nil {
144+
tc.assertFn(stdout.String(), userClient)
145+
}
148146
}
149147
}
150148

0 commit comments

Comments
 (0)