Replace our exec with promisify(cp.exec)

Using the built-in is better because it includes stdout and stderr
properties on the error which we will need when checking if the errors
emitted by the CLI are authentication issues.

Author: code-asher

src/download.ts

@@ -1,10 +1,11 @@
 import * as cp from "child_process"
 import { promises as fs } from "fs"
 import * as path from "path"
+import { promisify } from "util"
 import * as vscode from "vscode"
 import * as nodeWhich from "which"
 import { requestResponse } from "./request"
-import { context, debug, exec, extractTar, extractZip, getAssetUrl, onLine, outputChannel, wrapExit } from "./utils"
+import { context, debug, extractTar, extractZip, getAssetUrl, onLine, outputChannel, wrapExit } from "./utils"
 
 /**
  * Return "true" if the binary is found in $PATH.
@@ -22,7 +23,7 @@ export const binaryExists = async (bin: string): Promise<boolean> => {
 export const execCoder = async (command: string): Promise<string> => {
   debug(`Run command: ${command}`)
   const coderBinary = await preflight()
-  const output = await exec(coderBinary + " " + command)
+  const output = await promisify(cp.exec)(coderBinary + " " + command)
   return output.stdout
 }
 

src/utils.test.ts

@@ -8,21 +8,6 @@ import * as utils from "./utils"
 suite("Utils", () => {
   vscode.window.showInformationMessage("Start util tests.")
 
-  test("exec", async () => {
-    assert.deepStrictEqual(await utils.exec("printf stdout"), {
-      stdout: "stdout",
-      stderr: "",
-    })
-    assert.deepStrictEqual(await utils.exec(">&2 printf stderr"), {
-      stdout: "",
-      stderr: "stderr",
-    })
-    await assert.rejects(utils.exec("false"), {
-      name: "Error",
-      message: "Command failed: false\n",
-    })
-  })
-
   suiteSetup(() => {
     // Cleanup anything left over from the last run.
     utils.clean("tests/utils")

src/utils.ts

@@ -32,18 +32,6 @@ export const context = (ctx?: vscode.ExtensionContext): vscode.ExtensionContext
   return _context
 }
 
-/**
- * Run a command and get its stdout and stderr on completion.
- *
- * Use for short-running processes where you need the full output before you can
- * continue.
- */
-export const exec = async (command: string): Promise<{ stdout: string; stderr: string }> => {
-  return new Promise((res, rej) => {
-    cp.exec(command, (err, stdout, stderr) => (err ? rej(err) : res({ stdout, stderr })))
-  })
-}
-
 /**
  * Split a string up to the delimiter.  If the delimiter does not exist the
  * first item will have all the text and the second item will be an empty