From a78589932420220c2144f682704523ea0b62eeca Mon Sep 17 00:00:00 2001 From: xidedix Date: Wed, 9 Aug 2023 00:58:33 +0200 Subject: [PATCH 1/3] fix(@coreui/angular): add missing peerDependencies --- projects/coreui-angular/package.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/projects/coreui-angular/package.json b/projects/coreui-angular/package.json index e9f4aef2..f61594c3 100644 --- a/projects/coreui-angular/package.json +++ b/projects/coreui-angular/package.json @@ -22,10 +22,12 @@ "tslib": "^2.3.0" }, "peerDependencies": { + "@angular/animations": "^16.1.0", "@angular/cdk": "^16.1.0", "@angular/common": "^16.1.0", "@angular/core": "^16.1.0", - "@angular/router": "^16.1.0" + "@angular/router": "^16.1.0", + "rxjs": "^7.8.1" }, "repository": { "type": "git", From f101ac3fff72d888c2fd649f104cec734200baff Mon Sep 17 00:00:00 2001 From: xidedix Date: Wed, 9 Aug 2023 01:32:40 +0200 Subject: [PATCH 2/3] refactor(sidebar-nav): IconDirective imports --- .../sidebar-nav/sidebar-nav-group.component.html | 7 +++---- .../sidebar-nav/sidebar-nav-link.component.ts | 13 +++++++++++-- .../sidebar/sidebar-nav/sidebar-nav.component.ts | 4 ++-- 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav-group.component.html b/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav-group.component.html index 2ee3ca3a..a415cdef 100644 --- a/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav-group.component.html +++ b/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav-group.component.html @@ -2,7 +2,7 @@ [cHtmlAttr]="item.attributes" class="nav-link nav-group-toggle" href> - + {{ item.name }} {{ item.badge.text }} @@ -14,8 +14,7 @@ [groupItems]="true" [navItems]="navItems" [ngStyle]="display" -> - +/> @@ -24,7 +23,7 @@ [cIcon]="item.iconComponent?.content" [customClasses]="item | cSidebarNavIcon" [name]="item.iconComponent?.name" - > + /> diff --git a/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav-link.component.ts b/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav-link.component.ts index 8187c305..4bacab78 100644 --- a/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav-link.component.ts +++ b/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav-link.component.ts @@ -11,7 +11,7 @@ import { INavData } from './sidebar-nav'; import { SidebarNavLinkPipe } from './sidebar-nav-link.pipe'; import { SidebarNavBadgePipe } from './sidebar-nav-badge.pipe'; import { SidebarNavIconPipe } from './sidebar-nav-icon.pipe'; -import { IconModule } from '@coreui/icons-angular' +import { IconDirective } from '@coreui/icons-angular'; @Component({ selector: 'c-sidebar-nav-link-content', @@ -37,7 +37,16 @@ export class SidebarNavLinkContentComponent { templateUrl: './sidebar-nav-link.component.html', providers: [SidebarNavHelper], standalone: true, - imports: [CommonModule, RouterModule, HtmlAttributesDirective, SidebarNavLinkContentComponent, SidebarNavLinkPipe, SidebarNavBadgePipe, SidebarNavIconPipe, IconModule] + imports: [ + CommonModule, + RouterModule, + HtmlAttributesDirective, + IconDirective, + SidebarNavLinkContentComponent, + SidebarNavLinkPipe, + SidebarNavBadgePipe, + SidebarNavIconPipe + ] }) export class SidebarNavLinkComponent implements OnInit, OnDestroy { diff --git a/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav.component.ts b/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav.component.ts index 8ec072ab..28fabd22 100644 --- a/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav.component.ts +++ b/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav.component.ts @@ -33,7 +33,6 @@ import { INavData } from './sidebar-nav'; import { SidebarNavHelper } from './sidebar-nav.service'; import { SidebarNavGroupService } from './sidebar-nav-group.service'; import { HtmlAttributesDirective } from '../../shared'; -import { IconModule } from '@coreui/icons-angular'; import { SidebarNavIconPipe } from './sidebar-nav-icon.pipe'; import { SidebarNavBadgePipe } from './sidebar-nav-badge.pipe'; import { SidebarNavLinkComponent } from './sidebar-nav-link.component'; @@ -41,6 +40,7 @@ import { SidebarNavLabelComponent } from './sidebar-nav-label.component'; import { SidebarNavTitleComponent } from './sidebar-nav-title.component'; import { SidebarNavDividerComponent } from './sidebar-nav-divider.component'; import { SidebarNavItemClassPipe } from './sidebar-nav-item-class.pipe'; +import { IconDirective } from '@coreui/icons-angular'; @Component({ selector: 'c-sidebar-nav-group', @@ -50,10 +50,10 @@ import { SidebarNavItemClassPipe } from './sidebar-nav-item-class.pipe'; standalone: true, imports: [ HtmlAttributesDirective, + IconDirective, NgTemplateOutlet, NgIf, NgClass, - IconModule, SidebarNavIconPipe, SidebarNavBadgePipe, forwardRef(() => SidebarNavComponent), From 577a894ed71eef7c4c82a25152a3749a7f26f55c Mon Sep 17 00:00:00 2001 From: xidedix Date: Wed, 9 Aug 2023 01:38:33 +0200 Subject: [PATCH 3/3] chore: ship v4.5.14 --- CHANGELOG.md | 8 ++++++++ package-lock.json | 18 +++++++++--------- package.json | 4 ++-- projects/coreui-angular/package.json | 2 +- 4 files changed, 20 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e041730f..ce04283f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,13 @@ ### [@coreui/angular](https://coreui.io/angular/) changelog +#### `4.5.14` + +- fix(@coreui/angular): add missing peerDependencies +- refactor(sidebar-nav): IconDirective imports + +--- + + #### `4.5.13` - chore(dependencies): update diff --git a/package-lock.json b/package-lock.json index ab39e0e6..b9177c1a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "coreui-angular-dev", - "version": "4.5.13", + "version": "4.5.14", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "coreui-angular-dev", - "version": "4.5.13", + "version": "4.5.14", "license": "MIT", "dependencies": { "@angular/animations": "^16.1.8", @@ -40,7 +40,7 @@ "@coreui/icons": "^3.0.1", "@types/jasmine": "~4.3.5", "@types/lodash-es": "^4.17.8", - "@types/node": "^18.17.3", + "@types/node": "^18.17.4", "@typescript-eslint/eslint-plugin": "^5.62.0", "@typescript-eslint/parser": "^5.62.0", "eslint": "^8.46.0", @@ -3917,9 +3917,9 @@ "dev": true }, "node_modules/@types/node": { - "version": "18.17.3", - "resolved": "https://registry.npmjs.org/@types/node/-/node-18.17.3.tgz", - "integrity": "sha512-2x8HWtFk0S99zqVQABU9wTpr8wPoaDHZUcAkoTKH+nL7kPv3WUI9cRi/Kk5Mz4xdqXSqTkKP7IWNoQQYCnDsTA==", + "version": "18.17.4", + "resolved": "https://registry.npmjs.org/@types/node/-/node-18.17.4.tgz", + "integrity": "sha512-ATL4WLgr7/W40+Sp1WnNTSKbgVn6Pvhc/2RHAdt8fl6NsQyp4oPCi2eKcGOvA494bwf1K/W6nGgZ9TwDqvpjdw==", "dev": true }, "node_modules/@types/qs": { @@ -6227,9 +6227,9 @@ } }, "node_modules/electron-to-chromium": { - "version": "1.4.485", - "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.485.tgz", - "integrity": "sha512-1ndQ5IBNEnFirPwvyud69GHL+31FkE09gH/CJ6m3KCbkx3i0EVOrjwz4UNxRmN9H8OVHbC6vMRZGN1yCvjSs9w==" + "version": "1.4.488", + "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.488.tgz", + "integrity": "sha512-Dv4sTjiW7t/UWGL+H8ZkgIjtUAVZDgb/PwGWvMsCT7jipzUV/u5skbLXPFKb6iV0tiddVi/bcS2/kUrczeWgIQ==" }, "node_modules/emoji-regex": { "version": "8.0.0", diff --git a/package.json b/package.json index 56d0b4f6..85dd768a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "coreui-angular-dev", - "version": "4.5.13", + "version": "4.5.14", "description": "CoreUI Components Library for Angular", "copyright": "Copyright 2023 creativeLabs Łukasz Holeczek", "license": "MIT", @@ -67,7 +67,7 @@ "@coreui/icons": "^3.0.1", "@types/jasmine": "~4.3.5", "@types/lodash-es": "^4.17.8", - "@types/node": "^18.17.3", + "@types/node": "^18.17.4", "@typescript-eslint/eslint-plugin": "^5.62.0", "@typescript-eslint/parser": "^5.62.0", "eslint": "^8.46.0", diff --git a/projects/coreui-angular/package.json b/projects/coreui-angular/package.json index f61594c3..024fabc7 100644 --- a/projects/coreui-angular/package.json +++ b/projects/coreui-angular/package.json @@ -1,6 +1,6 @@ { "name": "@coreui/angular", - "version": "4.5.13", + "version": "4.5.14", "description": "CoreUI for Angular UI components library", "copyright": "Copyright 2023 creativeLabs Łukasz Holeczek", "license": "MIT",