chore: perform several small frontend permissions refactors (coder#16735)

Author: aslilac

enterprise/coderd/groups.go

@@ -167,8 +167,6 @@ func (api *API) patchGroup(rw http.ResponseWriter, r *http.Request) {
 			})
 			return
 		}
-		// TODO: It would be nice to enforce this at the schema level
-		// but unfortunately our org_members table does not have an ID.
 		_, err := database.ExpectOne(api.Database.OrganizationMembers(ctx, database.OrganizationMembersParams{
 			OrganizationID: group.OrganizationID,
 			UserID:         uuid.MustParse(id),

site/e2e/constants.ts

@@ -20,10 +20,10 @@ export const defaultPassword = "SomeSecurePassword!";
 
 // Credentials for users
 export const users = {
-	admin: {
-		username: "admin",
+	owner: {
+		username: "owner",
 		password: defaultPassword,
-		email: "admin@coder.com",
+		email: "owner@coder.com",
 	},
 	templateAdmin: {
 		username: "template-admin",
@@ -41,7 +41,7 @@ export const users = {
 		username: "auditor",
 		password: defaultPassword,
 		email: "auditor@coder.com",
-		roles: ["Template Admin", "Auditor"],
+		roles: ["Auditor"],
 	},
 	member: {
 		username: "member",

site/e2e/helpers.ts

@@ -67,7 +67,7 @@ export type LoginOptions = {
 	password: string;
 };
 
-export async function login(page: Page, options: LoginOptions = users.admin) {
+export async function login(page: Page, options: LoginOptions = users.owner) {
 	const ctx = page.context();
 	// biome-ignore lint/suspicious/noExplicitAny: reset the current user
 	(ctx as any)[Symbol.for("currentUser")] = undefined;

site/e2e/setup/addUsersAndLicense.spec.ts

@@ -16,16 +16,16 @@ test("setup deployment", async ({ page }) => {
 	}
 
 	// Setup first user
-	await page.getByLabel(Language.emailLabel).fill(users.admin.email);
-	await page.getByLabel(Language.passwordLabel).fill(users.admin.password);
+	await page.getByLabel(Language.emailLabel).fill(users.owner.email);
+	await page.getByLabel(Language.passwordLabel).fill(users.owner.password);
 	await page.getByTestId("create").click();
 
 	await expectUrl(page).toHavePathName("/workspaces");
 	await page.getByTestId("button-select-template").isVisible();
 
 	for (const user of Object.values(users)) {
 		// Already created as first user
-		if (user.username === "admin") {
+		if (user.username === "owner") {
 			continue;
 		}
 

site/e2e/tests/auditLogs.spec.ts

@@ -13,62 +13,63 @@ test.describe.configure({ mode: "parallel" });
 
 test.beforeEach(async ({ page }) => {
 	beforeCoderTest(page);
-	await login(page, users.auditor);
 });
 
-async function resetSearch(page: Page) {
+async function resetSearch(page: Page, username: string) {
 	const clearButton = page.getByLabel("Clear search");
 	if (await clearButton.isVisible()) {
 		await clearButton.click();
 	}
 
 	// Filter by the auditor test user to prevent race conditions
-	const user = currentUser(page);
 	await expect(page.getByText("All users")).toBeVisible();
-	await page.getByPlaceholder("Search...").fill(`username:${user.username}`);
+	await page.getByPlaceholder("Search...").fill(`username:${username}`);
 	await expect(page.getByText("All users")).not.toBeVisible();
 }
 
 test("logins are logged", async ({ page }) => {
 	requiresLicense();
 
 	// Go to the audit history
+	await login(page, users.auditor);
 	await page.goto("/audit");
+	const username = users.auditor.username;
 
 	const user = currentUser(page);
-	const loginMessage = `${user.username} logged in`;
+	const loginMessage = `${username} logged in`;
 	// Make sure those things we did all actually show up
-	await resetSearch(page);
+	await resetSearch(page, username);
 	await expect(page.getByText(loginMessage).first()).toBeVisible();
 });
 
 test("creating templates and workspaces is logged", async ({ page }) => {
 	requiresLicense();
 
 	// Do some stuff that should show up in the audit logs
+	await login(page, users.templateAdmin);
+	const username = users.templateAdmin.username;
 	const templateName = await createTemplate(page);
 	const workspaceName = await createWorkspace(page, templateName);
 
 	// Go to the audit history
+	await login(page, users.auditor);
 	await page.goto("/audit");
 
-	const user = currentUser(page);
-
 	// Make sure those things we did all actually show up
-	await resetSearch(page);
+	await resetSearch(page, username);
 	await expect(
-		page.getByText(`${user.username} created template ${templateName}`),
+		page.getByText(`${username} created template ${templateName}`),
 	).toBeVisible();
 	await expect(
-		page.getByText(`${user.username} created workspace ${workspaceName}`),
+		page.getByText(`${username} created workspace ${workspaceName}`),
 	).toBeVisible();
 	await expect(
-		page.getByText(`${user.username} started workspace ${workspaceName}`),
+		page.getByText(`${username} started workspace ${workspaceName}`),
 	).toBeVisible();
 
 	// Make sure we can inspect the details of the log item
 	const createdWorkspace = page.locator(".MuiTableRow-root", {
-		hasText: `${user.username} created workspace ${workspaceName}`,
+		hasText: `${username} created workspace ${workspaceName}`,
 	});
 	await createdWorkspace.getByLabel("open-dropdown").click();
 	await expect(
@@ -83,18 +84,19 @@ test("inspecting and filtering audit logs", async ({ page }) => {
 	requiresLicense();
 
 	// Do some stuff that should show up in the audit logs
+	await login(page, users.templateAdmin);
+	const username = users.templateAdmin.username;
 	const templateName = await createTemplate(page);
 	const workspaceName = await createWorkspace(page, templateName);
 
 	// Go to the audit history
+	await login(page, users.auditor);
 	await page.goto("/audit");
-
-	const user = currentUser(page);
-	const loginMessage = `${user.username} logged in`;
-	const startedWorkspaceMessage = `${user.username} started workspace ${workspaceName}`;
+	const loginMessage = `${username} logged in`;
+	const startedWorkspaceMessage = `${username} started workspace ${workspaceName}`;
 
 	// Filter by resource type
-	await resetSearch(page);
+	await resetSearch(page, username);
 	await page.getByText("All resource types").click();
 	const workspaceBuildsOption = page.getByText("Workspace Build");
 	await workspaceBuildsOption.scrollIntoViewIfNeeded({ timeout: 5000 });
@@ -107,7 +109,7 @@ test("inspecting and filtering audit logs", async ({ page }) => {
 	await expect(page.getByText("All resource types")).toBeVisible();
 
 	// Filter by action type
-	await resetSearch(page);
+	await resetSearch(page, username);
 	await page.getByText("All actions").click();
 	await page.getByText("Login", { exact: true }).click();
 	// Logins should be visible

site/e2e/tests/deployment/general.spec.ts

@@ -16,7 +16,7 @@ test("experiments", async ({ page }) => {
 	const availableExperiments = await API.getAvailableExperiments();
 
 	// Verify if the site lists the same experiments
-	await page.goto("/deployment/general", { waitUntil: "networkidle" });
+	await page.goto("/deployment/overview", { waitUntil: "domcontentloaded" });
 
 	const experimentsLocator = page.locator(
 		"div.options-table tr.option-experiments ul.option-array",

site/e2e/tests/roles.spec.ts

@@ -82,8 +82,8 @@ test.describe("roles admin settings access", () => {
 		]);
 	});
 
-	test("admin can see admin settings", async ({ page }) => {
-		await login(page, users.admin);
+	test("owner can see admin settings", async ({ page }) => {
+		await login(page, users.owner);
 		await page.goto("/", { waitUntil: "domcontentloaded" });
 
 		await hasAccessToAdminSettings(page, [

site/src/@types/storybook.d.ts

@@ -6,7 +6,7 @@ import type {
 	SerpentOption,
 	User,
 } from "api/typesGenerated";
-import type { Permissions } from "contexts/auth/permissions";
+import type { Permissions } from "modules/permissions";
 import type { QueryKey } from "react-query";
 
 declare module "@storybook/react" {

site/src/api/queries/organizations.ts

@@ -9,7 +9,7 @@ import {
 	type OrganizationPermissionName,
 	type OrganizationPermissions,
 	organizationPermissionChecks,
-} from "modules/management/organizationPermissions";
+} from "modules/permissions/organizations";
 import type { QueryClient } from "react-query";
 import { meKey } from "./users";
 

site/src/contexts/auth/AuthProvider.tsx

@@ -10,6 +10,7 @@ import {
 import type { UpdateUserProfileRequest, User } from "api/typesGenerated";
 import { displaySuccess } from "components/GlobalSnackbar/utils";
 import { useEmbeddedMetadata } from "hooks/useEmbeddedMetadata";
+import { type Permissions, permissionChecks } from "modules/permissions";
 import {
 	type FC,
 	type PropsWithChildren,
@@ -18,7 +19,6 @@ import {
 	useContext,
 } from "react";
 import { useMutation, useQuery, useQueryClient } from "react-query";
-import { type Permissions, permissionChecks } from "./permissions";
 
 export type AuthContextValue = {
 	isLoading: boolean;