Fix Autoscaling for worker nodes with invalid ProviderID

maksim-paskal · maksim-paskal · commit 17105a00cb2f · 2024-04-16T14:23:44.000+01:00
This change fixes a bug that arises when the user's cluster includes worker nodes not from Hetzner Cloud, such as a Hetzner Dedicated server or any server resource other than Hetzner. It also corrects the behavior when a server has been physically deleted from Hetzner Cloud.

Signed-off-by: Maksim Paskal &lt;paskal.maksim@gmail.com&gt;
diff --git a/cluster-autoscaler/cloudprovider/hetzner/hetzner_servers_cache.go b/cluster-autoscaler/cloudprovider/hetzner/hetzner_servers_cache.go
@@ -18,7 +18,6 @@ package hetzner
 
 import (
 	"context"
-	"errors"
 	"strconv"
 	"sync"
 	"time"
@@ -136,7 +135,8 @@ func (m *serversCache) getServer(nodeIdOrName string) (*hcloud.Server, error) {
 		}
 	}
 
-	return nil, errors.New("server not found")
+	// return nil if server not found
+	return nil, nil
 }
 
 func (m *serversCache) getServersByNodeGroupName(nodeGroup string) ([]*hcloud.Server, error) {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ package hetzner`
`18`	`18`
`19`	`19`	`import (`
`20`	`20`	`"context"`
`21`		`- "errors"`
`22`	`21`	`"strconv"`
`23`	`22`	`"sync"`
`24`	`23`	`"time"`
`@@ -136,7 +135,8 @@ func (m serversCache) getServer(nodeIdOrName string) (hcloud.Server, error) {`
`136`	`135`	`}`
`137`	`136`	`}`
`138`	`137`
`139`		`- return nil, errors.New("server not found")`
	`138`	`+ // return nil if server not found`
	`139`	`+ return nil, nil`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`func (m serversCache) getServersByNodeGroupName(nodeGroup string) ([]hcloud.Server, error) {`