This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Commit 4fb525b
Change variable name defining path to ChromeDriver executable
1. Why is this change necessary?
Current environment variable in ChromeDriver.php uses '.', whilst valid according to the specification, this will not work using a bash shell (probably the most commonly used)
2. How does it address the issue?
'.' replaced with '_'. This is usable in bash (including cygwin)
Original code still there, only attempts new variable if original does not exist
3. What are the side effects?
None, previous name will still work, new name only used if original name does not exist1 parent 5dbadd6 commit 4fb525b
1 file changed
+9
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
23 | 26 | | |
| 27 | + | |
| 28 | + | |
24 | 29 | | |
25 | 30 | | |
26 | 31 | | |
27 | 32 | | |
28 | 33 | | |
29 | 34 | | |
30 | | - | |
| 35 | + | |
31 | 36 | | |
32 | | - | |
33 | | - | |
| 37 | + | |
34 | 38 | | |
35 | | - | |
| 39 | + | |
36 | 40 | | |
37 | 41 | | |
0 commit comments