[CF 6148] v2 - CI: Add task that runs pgindent

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/6148

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAGECzQQJgGqwkgHWdH8TxVKg4Gdb-PjK_F0+PpzjB4JUL_87yA@mail.gmail.com
Author(s): Jelte Fennema-Nio

Author: Commitfest Bot

.cirrus.star

@@ -96,6 +96,7 @@ def compute_environment_vars():
 
     operating_systems = [
       'compilerwarnings',
+      'formattingcheck',
       'freebsd',
       'linux',
       'macos',

.cirrus.tasks.yml

@@ -1021,3 +1021,40 @@ task:
 
   always:
     upload_caches: ccache
+
+
+# Check that code follows formatting standards
+task:
+  name: FormattingCheck
+
+  env:
+    CPUS: 2
+    IMAGE_FAMILY: pg-ci-bookworm
+
+  <<: *linux_task_template
+
+  depends_on: SanityCheck
+  only_if: $CI_FORMATTINGCHECK_ENABLED
+  allow_failures: true
+
+  create_user_script: |
+    useradd -m postgres
+    chown -R postgres:postgres .
+
+  # Configure and build pg_bsd_indent
+  configure_script: |
+    su postgres <<-EOF
+      meson setup --auto-features=disabled build
+    EOF
+
+  build_pg_bsd_indent_script: |
+    su postgres <<-EOF
+      ninja -C build src/tools/pg_bsd_indent/pg_bsd_indent
+    EOF
+
+  # Check C code formatting with pgindent
+  check_pgindent_script: |
+    su postgres <<-EOF
+      export PATH="$(pwd)/build/src/tools/pg_bsd_indent:\$PATH"
+      src/tools/pgindent/pgindent --check --diff src contrib
+    EOF

src/backend/tcop/postgres.c

@@ -5218,8 +5218,8 @@ enable_statement_timeout(void)
 	if (StatementTimeout > 0
 		&& (StatementTimeout < TransactionTimeout || TransactionTimeout == 0))
 	{
-		if (!get_timeout_active(STATEMENT_TIMEOUT))
-			enable_timeout_after(STATEMENT_TIMEOUT, StatementTimeout);
+if (!get_timeout_active(STATEMENT_TIMEOUT))
+	enable_timeout_after(STATEMENT_TIMEOUT, StatementTimeout);
 	}
 	else
 	{