|
From: T J <tj...@gm...> - 2010-02-15 23:59:41
|
On Sun, Feb 14, 2010 at 2:49 PM, T J <tj...@gm...> wrote: > I ran across: > > http://old.nabble.com/half-filled-markers-td24003576.html > > The name "fillstyle" can give the wrong impression about what is being > filled. For example, see the comment here: > > http://www.mail-archive.com/mat...@li.../msg13074.html > > It's probably too late, but would "markerfillstyle" be a better name for this? > > Also, the current implementation fills half of the marker with the > markerfacecolor and doesn't fill the marker at all for the other half. > I think a neat (and simple) feature would be for users to specify two > colors. Perhaps 'markerfacecolor2'. The change to the code is > minimal, but the functionality it brings is quite flexible. > markerfacecolor2 can default to 'none' to maintain current > functionality. > > Should I file a ticket for this? > I went ahead and implemented this. The user can now specify 'markercoloralt'. In the process, I finished the "half-marker" code for all remaining filled_markers. The diff is attached, which also includes a fix for bug #560720: https://sourceforge.net/tracker/?func=detail&aid=2952236&group_id=80706&atid=560720 Please comment. If there are no comments in a few days, I'll file a ticket. A picture demonstrating this functionality is attached. Demos for all filled markers can be obtained here: http://www.filedropper.com/filledmarkers Note, the diff contains the script used to generate the pictures. More generally, I wonder if there should be a 'markerangle' keyword. I can probably push through and implement this, but I'd like to hear what people think about it. |