diff options
| author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2016-07-21 00:28:18 +0300 |
|---|---|---|
| committer | Orgad Shaneh <orgads@gmail.com> | 2016-07-22 10:12:59 +0000 |
| commit | 516161c875bb059b1b3db534e6575c88050b31b1 (patch) | |
| tree | 35bb8313626484183bf0407f36f471caaf577883 /src/plugins/git/commitdata.cpp | |
| parent | 539e33da0289dcb66f71734ba2ac06f6ec910819 (diff) | |
Git: De-noise
* Remove QLatin1{String|Char} where possible
* Use initializer lists for QStringList
Change-Id: I8479f87f4fc909b5d74d854956885564209538e4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Diffstat (limited to 'src/plugins/git/commitdata.cpp')
| -rw-r--r-- | src/plugins/git/commitdata.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/plugins/git/commitdata.cpp b/src/plugins/git/commitdata.cpp index 8cb0cbee68a..3ba792ae501 100644 --- a/src/plugins/git/commitdata.cpp +++ b/src/plugins/git/commitdata.cpp @@ -54,9 +54,9 @@ QString GitSubmitEditorPanelData::authorString() const if (email.isEmpty()) return rc; - rc += QLatin1String(" <"); + rc += " <"; rc += email; - rc += QLatin1Char('>'); + rc += '>'; return rc; } @@ -114,7 +114,7 @@ bool CommitData::checkLine(const QString &stateInfo, const QString &file) { QTC_ASSERT(stateInfo.count() == 2, return false); - if (stateInfo == QLatin1String("??")) { + if (stateInfo == "??") { files.append(qMakePair(FileStates(UntrackedFile), file)); return true; } @@ -143,7 +143,7 @@ bool CommitData::checkLine(const QString &stateInfo, const QString &file) if (yState != EmptyFileState) { QString newFile = file; if (xState & (RenamedFile | CopiedFile)) - newFile = file.mid(file.indexOf(QLatin1String(" -> ")) + 4); + newFile = file.mid(file.indexOf(" -> ") + 4); files.append(qMakePair(yState, newFile)); } @@ -159,20 +159,20 @@ bool CommitData::checkLine(const QString &stateInfo, const QString &file) \endcode */ bool CommitData::parseFilesFromStatus(const QString &output) { - const QStringList lines = output.split(QLatin1Char('\n')); + const QStringList lines = output.split('\n'); foreach (const QString &line, lines) { if (line.isEmpty()) continue; - if (line.startsWith(QLatin1String("## "))) { + if (line.startsWith("## ")) { // Branch indication: panelInfo.branch = line.mid(3); continue; } - QTC_ASSERT(line.at(2) == QLatin1Char(' '), continue); + QTC_ASSERT(line.at(2) == ' ', continue); QString file = line.mid(3); - if (file.startsWith(QLatin1Char('"'))) + if (file.startsWith('"')) file.remove(0, 1).chop(1); if (!checkLine(line.mid(0, 2), file)) return false; |