diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2025-01-22 16:46:35 +0100 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2025-01-24 07:27:52 +0000 |
| commit | 9fc33449def36eeb83d0f3110a760605c2421236 (patch) | |
| tree | 447ee4131effb47ef6c4bdd1d535d0a278e97765 /src/plugins/git/gitplugin.cpp | |
| parent | 9bd24b700077472c41a042a02260ad0e0729e990 (diff) | |
GitClient: Get rid of gitVersion()
We assume the minimum required version is 2.13.
Change-Id: I8ed8b199700243182d1b55b936631865fe7e462e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Diffstat (limited to 'src/plugins/git/gitplugin.cpp')
| -rw-r--r-- | src/plugins/git/gitplugin.cpp | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/src/plugins/git/gitplugin.cpp b/src/plugins/git/gitplugin.cpp index 3b557b1d580..1e4d2097653 100644 --- a/src/plugins/git/gitplugin.cpp +++ b/src/plugins/git/gitplugin.cpp @@ -44,7 +44,6 @@ #include <utils/action.h> #include <utils/algorithm.h> -#include <utils/async.h> #include <utils/commandline.h> #include <utils/fileutils.h> #include <utils/infobar.h> @@ -134,8 +133,6 @@ public: GitLogEditorWidgetT() : GitLogEditorWidget(new Editor) {} }; -static const QVersionNumber minimumRequiredVersion{1, 9}; - // GitPlugin class GitPluginPrivate final : public VersionControlBase @@ -295,7 +292,6 @@ public: void cleanCommitMessageFile(); void cleanRepository(const FilePath &directory); void applyPatch(const FilePath &workingDirectory, QString file = {}); - void updateVersionWarning(); void instantBlameOnce(); @@ -1374,26 +1370,6 @@ void GitPluginPrivate::startCommit(CommitType commitType) openSubmitEditor(m_commitMessageFileName, data); } -void GitPluginPrivate::updateVersionWarning() -{ - QPointer<IDocument> curDocument = EditorManager::currentDocument(); - if (!curDocument) - return; - Utils::onResultReady(gitClient().gitVersion(), this, [curDocument](const QVersionNumber &version) { - if (!curDocument || version.isNull() || version >= minimumRequiredVersion) - return; - InfoBar *infoBar = curDocument->infoBar(); - Id gitVersionWarning("GitVersionWarning"); - if (!infoBar->canInfoBeAdded(gitVersionWarning)) - return; - infoBar->addInfo( - InfoBarEntry(gitVersionWarning, - Tr::tr("Unsupported version of Git found. Git %1 or later required.") - .arg(minimumRequiredVersion.toString()), - InfoBarEntry::GlobalSuppression::Enabled)); - }); -} - void GitPluginPrivate::instantBlameOnce() { m_instantBlame.once(); @@ -1707,8 +1683,6 @@ void GitPluginPrivate::updateActions(VersionControlBase::ActionState as) m_commandLocator->setEnabled(repositoryEnabled); if (!enableMenuAction(as, m_menuAction)) return; - if (repositoryEnabled) - updateVersionWarning(); // Note: This menu is visible if there is no repository. Only // 'Create Repository'/'Show' actions should be available. const QString fileName = Utils::quoteAmpersands(state.currentFileName()); |