diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-10-06 19:34:47 +0200 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-10-06 18:16:23 +0000 |
| commit | 28c507eccb789e53a748784e9ec2de100b56e608 (patch) | |
| tree | c51d49fb32aee97bcc7ec1c7f1a3ae704900704c /plugins/fossil/fossilcommitwidget.cpp | |
| parent | 7ffdada4a3a0ce02371135813015aeb838c89c76 (diff) | |
Simplify data structures
Do some cleanup.
Change-Id: If40fefbdb646f0eb434539f8306421a40e47a3ee
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'plugins/fossil/fossilcommitwidget.cpp')
| -rw-r--r-- | plugins/fossil/fossilcommitwidget.cpp | 24 |
1 files changed, 7 insertions, 17 deletions
diff --git a/plugins/fossil/fossilcommitwidget.cpp b/plugins/fossil/fossilcommitwidget.cpp index d53ac59..beef90f 100644 --- a/plugins/fossil/fossilcommitwidget.cpp +++ b/plugins/fossil/fossilcommitwidget.cpp @@ -33,11 +33,9 @@ #include <utils/completingtextedit.h> #include <utils/qtcassert.h> -#include <QSyntaxHighlighter> -#include <QTextEdit> - -#include <QRegularExpression> #include <QDir> +#include <QRegularExpression> +#include <QSyntaxHighlighter> namespace Fossil { namespace Internal { @@ -101,7 +99,7 @@ void FossilCommitWidget::setFields(const QString &repoPath, const BranchInfo &br const QStringList &tags, const QString &userName) { m_commitPanelUi.localRootLineEdit->setText(QDir::toNativeSeparators(repoPath)); - m_commitPanelUi.currentBranchLineEdit->setText(branch.name()); + m_commitPanelUi.currentBranchLineEdit->setText(branch.name); const QString tagsText = tags.join(", "); m_commitPanelUi.currentTagsLineEdit->setText(tagsText); m_commitPanelUi.authorLineEdit->setText(userName); @@ -111,29 +109,21 @@ void FossilCommitWidget::setFields(const QString &repoPath, const BranchInfo &br QString FossilCommitWidget::newBranch() const { - const QString branchName = m_commitPanelUi.branchLineEdit->text().trimmed(); - return branchName; + return m_commitPanelUi.branchLineEdit->text().trimmed(); } QStringList FossilCommitWidget::tags() const { QString tagsText = m_commitPanelUi.tagsLineEdit->text().trimmed(); if (tagsText.isEmpty()) - return QStringList(); + return {}; - tagsText.replace(',', ' '); - const QStringList tags = tagsText.split(' ', Qt::SkipEmptyParts); - return tags; + return tagsText.replace(',', ' ').split(' ', Qt::SkipEmptyParts); } QString FossilCommitWidget::committer() const { - const QString author = m_commitPanelUi.authorLineEdit->text(); - if (author.isEmpty()) - return QString(); - - const QString user = author; - return user; + return m_commitPanelUi.authorLineEdit->text(); } bool FossilCommitWidget::isPrivateOptionEnabled() const |