diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-01-20 11:23:31 +0100 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2022-01-20 11:04:26 +0000 |
| commit | 2e3d32cc1bcdd946c1f377ba0abe75044317e0c8 (patch) | |
| tree | 53cfeb3801b01a174e920096f3594f4e7d58fbf3 /src/plugins/python/pythoneditor.cpp | |
| parent | c819c90368c43e965d9018bbc6bc80ed4ca83c40 (diff) | |
PythonEditor: Fix a leak of console process on shutdown
Give a parent for console process in order to delete it
on shutdown. In case the console process was started
and the user closed the Creator we were leaking
console process instance together with its process.
Connect to ConsoleProcess::finished() instead of stubStopped().
There is no point to keep the console open when the process
finished (it forces the user to manually close the stub
window by pressing enter).
Change-Id: I3f14e940f39b32e11bde276e80f3cb630b13d8f7
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/python/pythoneditor.cpp')
| -rw-r--r-- | src/plugins/python/pythoneditor.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/python/pythoneditor.cpp b/src/plugins/python/pythoneditor.cpp index f0e8acab46e..c3e9ec0c51c 100644 --- a/src/plugins/python/pythoneditor.cpp +++ b/src/plugins/python/pythoneditor.cpp @@ -63,9 +63,9 @@ static QAction *createAction(QObject *parent, ReplType type) break; } - QObject::connect(action, &QAction::triggered, parent, [type] { + QObject::connect(action, &QAction::triggered, parent, [type, parent] { Core::IDocument *doc = Core::EditorManager::currentDocument(); - openPythonRepl(doc ? doc->filePath() : Utils::FilePath(), type); + openPythonRepl(parent, doc ? doc->filePath() : Utils::FilePath(), type); }); return action; } |