aboutsummaryrefslogtreecommitdiffstats
path: root/src/libs/utils/plaintextedit
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Utils: Also clear formats when clearing a layout"David Schulz2025-10-011-1/+0
| | | | | | | | | This reverts commit ec76c500996842c821af6ce5bfbf00942bf2238b. It is also fixed by correctly updating blocks while handling document changes in decf008e1562ea9ab72c2642ee49002e1c13c986 Change-Id: Ic81f71bc772616aff016bcf0bc86c8a1c325252a Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: fix layout update ranges on document changes againDavid Schulz2025-10-012-2/+2
| | | | | | | | | | | | | amends 37545e6d0060d644edf75995201cfb49f2126855 The assumption that from always points at the first character that differs was wrong. The range can start with unmodified content. So in total it is not save to base the end position for clear layouts on the diff between added and removed characters, but we always need to clear layout from 'from' to 'from + charsAdded'. Change-Id: I5ad2678818b089f1ab722006bc1cb9e9ae9ec196 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: use QTC_ASSERT instead of Q_ASSERT or removeDavid Schulz2025-09-301-2/+1
| | | | | Change-Id: Ia65b241fecd56c21864c89a10b66ed4d6d1ae8a8 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: fix layout update ranges on document changesDavid Schulz2025-09-302-5/+7
| | | | | | | Fixes an issue with missing highlights in lines. Change-Id: I38d6b23dae4327c8e215865f369ec2cf3c58e14e Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Tweak compressing scrollbar updatesChristian Stenger2025-09-251-1/+6
| | | | | | | | | | | In case there is an updated scheduled already when updating the top block of the widget we might end up with an uninitialized scrollbar on first open. Fixes jumping to correct line when using git blame. Amends 3b5dd15562bdc9660395dc9d014f5374a32ebb1c. Change-Id: I339519259c354c3f473331e1d3dfe1a8876123ae Reviewed-by: David Schulz <david.schulz@qt.io>
* Utils: fix scrolling to end of documentDavid Schulz2025-09-251-2/+5
| | | | | Change-Id: I6346fede81ece0bcce8a1ca8068aac5b69e34c15 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: avoid using QFontMetricsF::lineSpacing for block offsetDavid Schulz2025-09-242-1/+11
| | | | | | | | | | | | QScriptLine that is used in the QTextLayout implementation only takes positive leading into account when calculating the line height. If we assume the QFontMetricsF::lineSpacing as the offset for unlayouted blocks we get a lot unnecessary updates during the layout process. So provide a static function in PlainTextDocumentLayout that provides a lineSpacing that is closer to the lineSpacing in a plain text document. Change-Id: I0ee114cf29f8a2fcbd5a2efe3fcea636a98c7739 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: ensure the offset cache is cleared after block size changesDavid Schulz2025-09-244-12/+23
| | | | | | | | | | If the size of a layouted block is different than our assumed block size we need to make sure that the offset cache is cleared for all items that follow this block, otherwise the adjust scrollbar call uses wrong offsets wich results in wrong scrollbar ranges. Change-Id: I245e12e2b1b2c7822079f61e42b5bf18f617a168 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: compress scrollbar updatesDavid Schulz2025-09-241-4/+15
| | | | | | | | | Push an update of the scrollbar to the end of the eventloop to avoid updating the scrollbar multiple times for multiple document changes in a single loop iteration. Change-Id: Ia08ff7c047278e5cfa6eeb492bb132949df52040 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Also clear formats when clearing a layoutDavid Schulz2025-09-151-0/+1
| | | | | | | | Layouts are potentially reused from vanished blocks so we need to make sure the Formats are also cleared in the reused layout. Change-Id: I87620d3628f34b5576757a7a6941e9ba4478e5d4 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: fix clearing layout data after document changesDavid Schulz2025-09-152-2/+4
| | | | | | Fixes: QTCREATORBUG-33308 Change-Id: I1f5f86ec14932d00f2bb8815cbc299ed01c11486 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: Fix TextEditorLayout::findBlockByLineNumberDavid Schulz2025-09-121-6/+5
| | | | | | | | The result was always a block in front of the block for the line number. This fixes flickering while scrolling by pixel via a touchpad. Change-Id: I90e12f2034d8f3d05380f8155dc7abc69c45d043 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: remove unreachable codeDavid Schulz2025-09-121-7/+0
| | | | | Change-Id: I5e8d71fd6458a6e33f054a47e40ff83e2176f1ff Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: improve page up/down in plain text editDavid Schulz2025-09-111-88/+19
| | | | | | | | | | Just increasing the scrollbar by page step and moving the cursor to the closest previous vertical offset is way cleaner than the previous aproach. Fixes: QTCREATORBUG-33447 Change-Id: I8c6fcfabd263d11ac088f93d34967c2a0682e61b Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Set pagestep to a multiple of line heightDavid Schulz2025-09-111-1/+2
| | | | | | | | This will usually result in having the same block offset after increasing the scrollbar value by page step. Change-Id: I6e16dd52af2f6c0269b07329085b37dfaf565c94 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Fix crash in editor layoutChristian Stenger2025-09-111-1/+1
| | | | | | | Do not access uncached offsets. Change-Id: I9234cc0da486526d091c42d2f5c40849e4eb5dd1 Reviewed-by: David Schulz <david.schulz@qt.io>
* Utils: Suppress compiler warning about signednessChristian Kandeler2025-09-081-1/+1
| | | | | Change-Id: I5698b41906f4571eb9cf303d8f0f0a245161ea53 Reviewed-by: David Schulz <david.schulz@qt.io>
* TextEditor: Fix embedded Widget positioningMarcus Tillmanns2025-09-084-8/+18
| | | | | Change-Id: If3267f6fca4a2abbcb4d4917653f814209283ea4 Reviewed-by: David Schulz <david.schulz@qt.io>
* Utils: introduce additional layout items per block layoutDavid Schulz2025-08-286-161/+591
| | | | | Change-Id: Idceed0491f610637d38defece1643686f95151d5 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: fix setTopBlock for blocks close to the bottom of the fileDavid Schulz2025-08-251-5/+8
| | | | | | | | | This ensures we do not set the top block number to a value that is not reachable with the current scrollbar max value. Fixes: QTCREATORBUG-33319 Change-Id: I150c4ba420416b059302848437fc5041e1dcdc0e Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: fix moving cursor over folded blocksDavid Schulz2025-08-221-1/+3
| | | | | | | | | The text cursor schould not be set to invisible blocks as it automatically set them visible which causes a fold area to expand. Change-Id: I9be186b1a0515cd591c2eeabaac62bcc565ac873 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: fix moving cursor up/down with selection on first/last lineDavid Schulz2025-08-181-2/+8
| | | | | Change-Id: Iafd1d9e7475a6b877fb87fbd875942259021b687 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: share common code between moving cursor up and downDavid Schulz2025-08-181-25/+10
| | | | | Change-Id: I9870b33567c596ba14fa3ce74ab008cd4076adbc Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: fix vertical text cursor movementDavid Schulz2025-08-181-2/+8
| | | | | | Fixes: QTCREATORBUG-33321 Change-Id: I1c2e71a1972cb5d02a8a04a8fd0a01436e620334 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Utils: Fix MSVC warningOrgad Shaneh2025-07-301-1/+1
| | | | | | | warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data Change-Id: I86cdd3ffe75759b5761f9ac33a120b1c2ec52068 Reviewed-by: hjk <hjk@qt.io>
* Utils: replace another unique_ptr::release with resetDavid Schulz2025-07-231-1/+1
| | | | | | | in that case the managed layout should deleted as well Change-Id: I33a86335204bf784022c7a8a4af67aeba870dfe9 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Utils: fix leaking block layoutDavid Schulz2025-07-211-1/+1
| | | | | Change-Id: I960a6d2d005e1c9813ee11df015c594d64b4f5c8 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Editor: use one layout per editor instead of per documentDavid Schulz2025-07-186-254/+839
| | | | | | | | | This allows to wrap one document differently in editors with a different width. In the future this will allow us also to display additional information in just a single editor. Change-Id: Ie1a07517be8756c473207e0db58f7d9924fdb5b1 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Merge remote-tracking branch 'origin/17.0'Eike Ziller2025-07-022-128/+125
|\ | | | | | | | | | | | | | | | | | | Conflicts: cmake/QtCreatorIDEBranding.cmake qbs/modules/qtc/qtc.qbs src/plugins/coreplugin/plugininstallwizard.cpp src/plugins/coreplugin/textdocument.cpp Change-Id: I6c8d13a019f1e7142856037481172889f69ae971
| * Doc: Fix QDoc warnings for PlainTextDocumentLayout and PlainTextEditLeena Miettinen2025-06-231-128/+119
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add the Utils namespace to \class commands and \property commands to show the docs - Remove \since commands because they refer to Qt versions - Use \inmodule QtCreator - Remove \reimp commands or replace them with \overload - Marks some docs \internal - Add \c formatting for references to functions that are not documented - Consistently format true and false with \c - Replaced references to code snippets in the Qt module docs with hard-coded snippets - Fix other minor issues Change-Id: I63da28c137145d65c6455540fa55d4dc5761318c Reviewed-by: David Schulz <david.schulz@qt.io>
| * DiffEditor: fix jumping to selected file from toolbar dropdownDavid Schulz2025-06-192-0/+6
| | | | | | | | | | Change-Id: I968ddc798c6f66072947031bab2dd3855a99bdee Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* | Merge remote-tracking branch 'origin/17.0'Eike Ziller2025-06-171-1/+1
|\| | | | | | | | | | | | | | | Conflicts: cmake/QtCreatorIDEBranding.cmake qbs/modules/qtc/qtc.qbs Change-Id: Iac555437405e993475736232b3cf2402cf9fe8ed
| * Editor: fix artifacts when scrolling horizontallyDavid Schulz2025-06-051-1/+1
| | | | | | | | | | | | | | ... while the topline is only partially visible. Change-Id: I21d0f576c70f91dd804cb71cf60f62c06f11fe77 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* | Merge remote-tracking branch 'origin/17.0'Eike Ziller2025-06-041-5/+12
|\| | | | | | | | | | | | | Conflicts: tests/auto/utils/unarchiver/unarchiver.qbs Change-Id: Id20ff632e87c22147fb2f7a355cf7cc00ff5086c
| * Utils: fix expected block heightDavid Schulz2025-06-021-5/+12
| | | | | | | | | | | | | | | | | | | | | | The assumtion that QFontMetrics::lineSpacing is equal to the height of a text layout with a single line is wrong. In the layouting process the height is rounded up, but in QFontMetrics::lineSpacing it is rounded to the closest integer. Fixes: QTCREATORBUG-32979 Change-Id: Ic0dc9016d0e9cdca0691b3fc3f88868b11b8950a Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | Merge remote-tracking branch 'origin/17.0'Eike Ziller2025-05-261-1/+1
|\| | | | | | | | | | | | | | | Conflicts: cmake/QtCreatorIDEBranding.cmake qbs/modules/qtc/qtc.qbs Change-Id: If5ab8dda785255d168d7765f33da2b4fe3817183
| * UI text: Fix caps, punctuation, and wordingLeena Miettinen2025-05-221-1/+1
| | | | | | | | | | | | Change-Id: I07eeafe159154505c50686a879ca1e9227cd80f5 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* | PlainTextEdit: avoid layouting invisible blocksDavid Schulz2025-05-221-13/+9
|/ | | | | Change-Id: I983e4c74a9a2d5c271056a75a5301e566076f524 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Silence warning about unused parameterChristian Stenger2025-05-131-1/+1
| | | | | | | Amends 333beeb8223fad146ee78bc646640d529d3f01d2. Change-Id: I8b071904691e086dc0e35b10ff8ec854c0bc586a Reviewed-by: David Schulz <david.schulz@qt.io>
* Utils: do not reset documentLayoutPtr on relayoutDocumentDavid Schulz2025-05-131-9/+7
| | | | | | | | The code paths that changes the document layout already resets the member. Change-Id: I6045ff9c9da2c7e14811234a33c43b670973786f Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: enable per pixel scrolling in PlainTextEditDavid Schulz2025-05-131-75/+113
| | | | | Change-Id: Id693de1d3a5f2f272523d7f8608901a505687ce4 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Ensure PlainTextEdit accessibilityDavid Schulz2025-05-132-0/+632
| | | | | | | Fixes: QTCREATORBUG-32897 Change-Id: I2d15470f4c81f179b9ac29977bb45bbf7f8f0219 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* TextEditor: use Tr::tr for imported PlainTextEditEike Ziller2025-05-131-11/+13
| | | | | | Change-Id: I9ac45bb3ce0c5e3a7d75fd191d3b1c5d8d9f2b08 Reviewed-by: David Schulz <david.schulz@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Utils: Minor adaption after change to plaintextedit forkChristian Stenger2025-04-301-1/+1
| | | | | | | | | | Accessing the cursorRect function is needed in some cases for the Squish tests. Amends cfc26cdf79b94888c1759636eff548b2378f93f3. Change-Id: I58e602c1b4c4ab918166ffa758f0675203619d81 Reviewed-by: David Schulz <david.schulz@qt.io> Reviewed-by: hjk <hjk@qt.io>
* Editor: fix squish testsDavid Schulz2025-04-292-1/+7
| | | | | | | | | | | | Changing the base of TextEditor::TextEditorWidget from QPlainTextEdit to Utils::PlainTextEdit made some functions of the base class inaccessible for squish. So we need to use the properties or make the used functions available via Q_PROPERTY. Fixes: QTCREATORBUG-32776 Change-Id: Ie3c45b2de958a9b82a4b4323558830c993187c52 Reviewed-by: Christian Stenger <christian.stenger@qt.io> Reviewed-by: David Schulz <david.schulz@qt.io>
* PlainTextEdit: Comment out some no-op code to avoid warningshjk2025-04-161-0/+2
| | | | | | | | .../src/libs/utils/plaintextedit/widgettextcontrol.cpp:2064:13: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] .../src/libs/utils/plaintextedit/widgettextcontrol.cpp:2063:19: warning: unused variable 'window' [-Wunused-variable] Change-Id: Ic6dc6c369d694c4876d88e126f7103f91fa4745e Reviewed-by: David Schulz <david.schulz@qt.io>
* Editor: optimize clearing layouts after edit width changeDavid Schulz2025-04-161-1/+11
| | | | | Change-Id: Ic3f700c48f05e2d231021379a5e154b23c2d1858 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Fix warning for ';'Marco Bubke2025-04-152-22/+22
| | | | | | | | The macro already contain a ';'. Removing the argument or [[maybe_unused]] would maybe even a better approach. Change-Id: I31750d10a4f252c667e7c0e5e13bf1085dbe11a2 Reviewed-by: hjk <hjk@qt.io>
* Utils: Fix warningsMarcus Tillmanns2025-04-082-2/+4
| | | | | Change-Id: Ibc8eb9b5aac4329cc38f4e8e0421d17d8628d2bf Reviewed-by: David Schulz <david.schulz@qt.io>
* Editor: Fork QPlainTextEditDavid Schulz2025-04-026-0/+7445
The layout of a text editor is part of the document and not the editor. This results in not being able to position blocks differently in multiple editors. As a first step fork QPlainTextEdit with all the private dependencies. Change-Id: Ie2da2613a966fe1958b6dbade4b7ff40e8858f62 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-17 16:48:13 +0000