aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/debugger/debuggersourcepathmappingwidget.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Utils: Remove unneeded include from aspect.hhjk2025-08-201-1/+2
| | | | | | | Add it where needed. Change-Id: Id01d7d18c74dcdc6bd67bd0675d1921e3bb211e6 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* Centralize Settings storage a bithjk2025-07-041-12/+12
| | | | | | | | | | | | | | Until now, the plugin manager effectively owned the settings, with forwarded access from ICore and three places in Utils getting settings injected. This here moves the storage to Utils, removing the need for injection, as all users depend on Utils. Syntax-wise this changes access to use references instead of pointers. Change-Id: If63258fbe37da2ad3dcf78f8c2eedb61753e7cc8 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Debugger: Transform a few fields of DebuggerRunParametersJarek Kobus2025-01-131-1/+1
| | | | | | | | | Transform debugInfoLocation, debugSourceLocation and qtSourceLocation. Task-number: QTCREATORBUG-29168 Change-Id: Ia8c93092d1e8ad937d9aa0ab4b4208609772e9be Reviewed-by: hjk <hjk@qt.io>
* Utils: Rename FilePath::toString() into toUrlishString()hjk2025-01-101-5/+5
| | | | | | | | | | | | | | | | toString() is almost always the wrong conversion, but unfortunately too easy to find and often even working at least for local setup. This here raises the bar as the non-availability of the "obvious" toString() hopefully helps people to think about the semantics of the needed conversion and choose the right toXXX() function. The chosen new name is intentional ugly to reduce the likelihood that this (still almost always wrong) function is used out of convenience. Change-Id: I57f1618dd95ef2629d7d978688d130275e096c0f Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: Remove parent argument from FileUtils dialogshjk2025-01-061-1/+1
| | | | | | | | | Some were using ICore::dialogParent() directly and the 'nullptr' users were using that implicitly, but quite a few actually effectively changed now from some local widget to (implicit) ICore::dialogParent(). Change-Id: Ibb2767b1289221dd26757361235ee88df4a1695e Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Remove #include <utils/fileutils.h> from most header fileshjk2024-07-261-0/+1
| | | | | | | | | | It has some platform specific warts, filepath.h is somewhat cheaper and less ugly overall. Partially clean up surroundings Change-Id: Ida1fd470ec020f69c446109427f92a08e879789f Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* Utils: Make Aspect::addToLayout() consthjk2024-07-081-1/+1
| | | | | | | | | | | It's conceptionally const, and would be useful to use as such, but the current implementations often modifie mutable state. To ease the transition pain, rename the previous non-const version to addToLayoutImpl() and call it after const_cast'ing. Change-Id: Ic8ca38e40f5df69c3d11121f96ea37648cf4feb7 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* Utils: Rename PathChooser::rawFilePath() to unxepandedFilePath()hjk2024-06-191-1/+1
| | | | | | | | That's what the implementation does, and judging from the using code wasn't quite clear. Change-Id: I4ca776ba4da83a36162adad2dd595eb39eb0f43d Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Use LayoutBuilder V2hjk2024-05-271-1/+1
| | | | | | | | | | | | This puts the implementation introduced in acf1ecb47fdf into use, after significant simplifications in the class hierarchy. CRTP is not used anymore, and the new tag based dispatch is also used for Layout::addItem, effectively reducing the number of different code paths. The Lua based settings access is disabled for now. Change-Id: Idb6d1a25675378757c5267bdb630bcd4c1f52d34 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Utils: Fix build with MSVC with C++20Eike Ziller2024-02-281-1/+1
| | | | | | | | | | | | | | | | | Rename process.h back to qtcprocess.h MSVC's "threads" standard header includes <process.h>, and that ends up including our process.h from Utils. There already was a hacky workaround in place for a similar issue with MINGW, but that doesn't work with MSVC because that doesn't have Simply use a name that doesn't conflict. Change-Id: I1159cd2096b4f2dbc4a1728d0131dd6edd30ebd3 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: hjk <hjk@qt.io>
* Debugger: Update internal buffer before checking dirtynesshjk2023-10-161-0/+6
| | | | | | Fixes: QTCREATORBUG-29746 Change-Id: I63f3c5bd2c628b42ba23dd19d80a410dbca8cfc1 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* All: Remove some unneeded #includeshjk2023-09-271-1/+0
| | | | | Change-Id: If9a8fb5e0b32424e3b37ecf3adefc060f86b3630 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* Utils, all: Standardize on QtcSettingshjk2023-09-271-6/+6
| | | | | Change-Id: Id222016f15b1c3bfe6710fe5d0297666d4565ef1 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* Utils: Rename the new Storage to Storehjk2023-08-241-2/+2
| | | | | | | | | Apparently that's what the young people on the web use for such a thing. Change-Id: I75d5396ff3cb3c26efd6008b5f2261354c4f7896 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io> Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Use Utils::Storage instead of QVariantMap in a few placeshjk2023-08-231-2/+2
| | | | | Change-Id: I02833cf2bc3caaadc22ff93ae530e4aebe4c3868 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* Utils: Base AspectContainer on BaseAspecthjk2023-08-091-2/+2
| | | | | | Change-Id: I78b11727af6e465da5731ba36bbae476d11d11ee Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* Debugger: Register common aspectshjk2023-07-211-2/+2
| | | | | Change-Id: Iaa43758bdf0e5060830213ae744a2d0baedf6c15 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Let aspect transition functions indicate there was a changehjk2023-07-201-1/+3
| | | | | | | | Helps to make it easier to reason about the necessity of emitting *changed signals. Change-Id: Ieab29b25f5cc2799e193417b9cab02c99501c60a Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* Debugger: Move CommonOptionsPage to new settings schemehjk2023-07-201-1/+1
| | | | | Change-Id: I851931d3b0536659dc2e53a67b9879caad2f3166 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Introduce a staging area for gui valueshjk2023-07-181-4/+4
| | | | | | | | | | | | | | | | Accessing gui elements is very aspect-specific, whereas the rules when and how values are synchronized are rather general. Splitting the two concepts and having a permanent 'buffer' area that is synchronized with the gui elements if and only if they have been created helps to keep the boilerplate needed per-aspect at a minimum. This value could also serve as "model" in case we wanted to allow multiple "views" in different places of the gui onto that aspect. Change-Id: I34832512b99c53cb0e4df437ee9b4c5d17a2ad8f Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Make aspect settings access implicithjk2023-07-071-4/+4
| | | | | | | | | | | | Generally, aspects should use fromMap/toMap, but some older pages use {from,to}Settings with always the same ICore::settings(). To make that less intrusive on the user code side, make that globally implicit. Task-number: QTCREATORBUG-29167 Change-Id: I29a8e23a31eb8061bb143e93931a07c6741eb7f9 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Utils: Rework aspect implementationhjk2023-06-291-13/+6
| | | | | | | | | | This avoids some repetition and could be a step towards having type storage in (or rather accessible from) the base, so we can have aspects for more complex data (treemodels...) that are not easily converted to QVariant. Change-Id: I9797b3d5646195705212db1830d2b415291ac651 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Debugger: Fix automatic source mapping for QtEike Ziller2023-06-161-33/+4
| | | | | | | | | | | | | | | - The QtVersion::sourcePath() was wrong because QT_INSTALL_PREFIX/src doesn't return the right path. Work around by checking if sources are found, and otherwise trying the location that we know the installers to put them. - Pass the sourcePath along to the debugger run control, and use that instead of looking for qmake in the PATH (which fails because it is not in PATH). Fixes: QTCREATORBUG-28950 Change-Id: Iffa262d6c87dbc979c449d43cd4a85e1320bcd37 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: David Schulz <david.schulz@qt.io>
* Utils: Rename qtcprocess.{cpp,h} -> process.{cpp,h}Jarek Kobus2023-05-041-1/+1
| | | | | | | | Follows QtcProcess -> Process rename. Change-Id: I97235a9a40cb7fd52944515b7ab878d96528f919 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Utils: Rename QtcProcess -> ProcessJarek Kobus2023-05-041-1/+1
| | | | | | | | Task-number: QTCREATORBUG-29102 Change-Id: Ibc264f9db6a32206e4097766ee3f7d0b35225a5c Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: hjk <hjk@qt.io>
* Layouting: Make aspects operate on parent items, not LayoutBuilderhjk2023-05-031-2/+2
| | | | | | | LayoutBuilder is meant to be an implementation detail nowadays. Change-Id: I777ab934d3d405873e819eeddd27428d8c652f9a Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* LayoutBuilder: Reworkhjk2023-05-031-1/+1
| | | | | | | | | | | | | | | Everying is a LayoutItem now, and everything is split into a proper setup and execution phase. Execution happens only via LayoutBuilder (directly or via convenience wrappers in LayoutItem). No direct access to the widget in creation, funnel out is via the new bindTo() facility. Change-Id: I7eb38fd736ae57a68f9a72a6add5c767da82b49f Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Utils: Remove one LayoutBuilder::addRow() overloadhjk2023-04-251-1/+1
| | | | | | | | | | The flexibility here is getting in the way later when trying to remove the dependency on aspects. Change-Id: I7221e80f2067292c7c80aead8f6d739fb7878f7e Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: Flatten LayoutBuilder related hierarchieshjk2023-01-201-1/+1
| | | | | | | | | Originally the idea was to only expose LayoutBuilder, but we are getting more and more related items. Be consequent now, and have everything in Utils::Layouting, but not in nested classes. Change-Id: Ic0f98595882e5c60a25c30ec52df4a0ea79bc0ca Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Utils: Rename QtcProcess::readAllStandard* to readAllRawStandard*hjk2023-01-101-1/+1
| | | | | | | | | | | | ... and re-use the old QtcProcess::readAllStandard* names for a QString-returning 'decoded' version. For now, only use that in 'full Utf8' cases, to stay bug-compatible, the plan is, however, to employ the QTextCodecs we have already in the channel buffers. That will be one-by-one, though. Change-Id: Id209e0671920d4ea4197918e872f441254112d52 Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Remove GPL-3.0+ from license identifiersKai Köhne2023-01-061-1/+1
| | | | | | | | | | | | | | | Since we also license under GPL-3.0 WITH Qt-GPL-exception-1.0, this applies only to a hypothetical newer version of GPL, that doesn't exist yet. If such a version emerges, we can still decide to relicense... While at it, replace (deprecated) GPL-3.0 with more explicit GPL-3.0-only Change was done by running find . -type f -exec perl -pi -e "s/LicenseRef-Qt-Commercial OR GPL-3.0\+ OR GPL-3.0 WITH Qt-GPL-exception-1.0/LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0/g" {} \; Change-Id: I5097e6ce8d10233993ee30d7e25120e2659eb10b Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Utils: Replace PathChooser::{fileP,p}athChanged signalshjk2022-09-061-1/+1
| | | | | | | | | | | | | | | | | ... by a new PathChooser::textChanged signal. They were both emitted in reaction to the underlying line edit's textChanged() signal. Use 'textChanged()' as name to mimic/match the Qt side. This also makes it more clear on the user code side, when this happens. Some textChanged() consumers should probably use editingFinished() instead, but that's left for later changes. Change-Id: Ib07347f616cbf1c5d09bc2f8671ca860d185d1f9 Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Use SPDX license identifiersLucie Gérard2022-08-261-24/+2
| | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. Task-number: QTBUG-67283 Change-Id: I708fd1f9f2b73d60f57cc3568646929117825813 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Debugger: Convert to Tr::trhjk2022-07-081-21/+18
| | | | | Change-Id: I5d2475c790851c68f9997ac6af72b5eaca58482d Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Replace more used of PathChooser::pathChanged by filePathChangedhjk2022-07-011-1/+1
| | | | | | Change-Id: I0f92be6fcfd0a5319ad9f5d3681266966e40705e Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* DebuggerSourcePathMappingWidget: Don't call waitForStarted()Jarek Kobus2022-06-301-5/+0
| | | | | | | This is unneeded when followed by waitForFinished(). Change-Id: I7dbc7c8ddb3ab52513420aae1bada2a7260ad687 Reviewed-by: hjk <hjk@qt.io>
* Utils: Hide some uses of FilePath::rawPath()hjk2022-06-301-1/+1
| | | | | | | | | | | | This basically inlines the current rawPath() implementation on the user code side, keeping behavior the same. Baby steps towards the originally intended swap of rawPath() and rawFilePath() implementations. Change-Id: Ib61887bfdc4485a17856c0dbc7c7c5dba7c3e0e3 Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
* Debugger: Use QtcProcess::stop instead of stopProcesshjk2022-06-161-1/+0
| | | | | | | | Less synchronous in cases where it is not needed. Change-Id: Ia07e6d293c7f5e6dfb81b06c0ffb6d5d651b88b3 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io> Reviewed-by: David Schulz <david.schulz@qt.io>
* Merge remote-tracking branch 'origin/7.0'Eike Ziller2022-03-111-1/+2
|\ | | | | | | | | | | | | | | | | Conflicts: cmake/QtCreatorIDEBranding.cmake qbs/modules/qtc/qtc.qbs qtcreator_ide_branding.pri Change-Id: Ic02df53b880d0861d9d9ea0df3e0d381ae99f350
| * Debugger: update source path mappingsDavid Schulz2022-03-091-1/+2
| | | | | | | | | | | | | | | | Add latest mingw qt build folder. Task-number: QTCREATORBUG-27143 Change-Id: I8e5beb21621c681e440d761e2f42635582bdb549 Reviewed-by: Cristian Adam <cristian.adam@qt.io>
* | ProjectExplorer: Drop #include <qtcprocess.h> from runcontrol.hhjk2022-02-181-0/+1
|/ | | | | | | Recompiles only ~500 instead of ~630 after touching qtcprocess.h. Change-Id: If0256f27b2b9a1665cd76a65fedb7adb38a07bac Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* Debugger: Use FilePath in debuggersourcepathmappingwidget.cpphjk2021-09-291-12/+11
| | | | | Change-Id: I83f9cd55ab4c77609fbd3d2ae0d851de3c5145a3 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Use more FileUtils based file dialogshjk2021-08-191-2/+2
| | | | | Change-Id: I1e7ec0493c26afe58e17afb8923a2b1023f6dcd4 Reviewed-by: David Schulz <david.schulz@qt.io>
* Use refactored ProcessModeJarek Kobus2021-08-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch needs to be applied together with the parent change. There are 3 basic cases: 1. The user doesn't write anything to the write channel: You don't need to call closeWriteChannel manually anymore. By default the QtcProcess you create is in ProcessMode::Reader mode. Internally it opens the process in ReadOnly mode and closes the write channel just after starting. 2. The user writes some initial data (after being started) and then closes the write channel: All what is needed now it to set the write data (QtcProcess::setWriteData) before calling start. You also use the default ProcessMode::Reader mode. Internally it opens the process in ReadWrite mode and writes the writeData asynchonously when the process already started. After writing the data it closes the write channel automatically. 3. The user writes the data also after calling start. All you need now is to create a process with ProcessMode::Writer mode. In this mode the write channel is not closed. Internally it opens the process in ReadWrite mode as some writers also read the data from the process. All the code base is adapted here to the above rules. Change-Id: Id103019d1d71a3012fd1eade226fe96b9aaa48c2 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Make findQtInstallPath remote-awarehjk2021-05-031-7/+4
| | | | | Change-Id: I3df662a182c079725e616776befead30265f22b3 Reviewed-by: David Schulz <david.schulz@qt.io>
* Debugger: Use an aspect for the source path mappinghjk2021-03-091-15/+152
| | | | | | | More in line with the other settings. Change-Id: I86494f1955120cddda7d2f2eec8ba0fdbfd99585 Reviewed-by: David Schulz <david.schulz@qt.io>
* remove pointless process state checkingOswald Buddenhagen2021-02-081-1/+1
| | | | | | | | | | | | | | | | | | | | this partially reverts ddefe062c7 - contrary to what that commit's message suggests, the process state doesn't just change out of the blue, making waitForFinished() return false. that requires the process being reaped, which may happen only if the event loop runs or one of the I/O-related waitFor*() functions is called on that process. note that the first condition in SynchronousProcess::stopProcess() was actually bogus, as it makes obviously no sense whatsoever to insist that the process is still running after waitForFinished() returned success. qtpromaker was also plain broken - it would always terminate prematurely due to thinking that the sub-process failed. Change-Id: I44f332a6784ccc7e732ee868e38218f746141129 Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Debugger: Fix source mapping on WindowsOrgad Shaneh2020-11-121-1/+2
| | | | | | | | | | Path separators should be translated to '/'. That's probably was the intention for originally using QDir::cleanPath(), which was removed in b7c72f8621. Change-Id: Id7fdbc1e430b7d52da1bd7406fcfd777326bf593 Reviewed-by: hjk <hjk@qt.io>
* Debugger: Do not discard macros when clicking on source mappingOrgad Shaneh2020-10-301-2/+1
| | | | | | Fixes: QTCREATORBUG-24816 Change-Id: I7e541d3edb7601cf91064ba30059e4a8f0aa6064 Reviewed-by: hjk <hjk@qt.io>
* Utils/ProjectExplorer: Move re-usabled bits of aspects to Utilshjk2020-09-231-4/+3
| | | | | | | | | | | Classes involved are BaseAspect and some derived classes, LayoutBuilder and VariableChooser. This is mostly mechanical, with various include/using changes to make it compile. Change-Id: I624a457f3555f102e541c4c71e33a9423af32250 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-17 15:59:14 +0000