diff options
| author | Pekka Vuorela <pvuorela@iki.fi> | 2025-11-04 09:32:10 +0200 |
|---|---|---|
| committer | Pekka Vuorela <pvuorela@iki.fi> | 2025-11-06 17:36:43 +0200 |
| commit | ced6584c65498661db5012602b0465e293476da0 (patch) | |
| tree | b10b8599bbfbeefa41f8ba84590b8b4aca531c76 /examples/qtmail/qmailcomposer.cpp | |
| parent | 7e135a5c9305e889003b8c2cebb41633aaba012c (diff) | |
Avoid some more compiler warnings
- Missed earlier one QMessageBox deprecation from separate file
- LongStream now doing consistent open() check in all code paths.
Also removed unused member variable 'c' and moved internal constants
to .cpp.
- imapstrategy.h / ImapMessageListStrategy::selectedSectionsAppend()
was dead code due to derived class ImapFetchSelectedMessagesStrategy
having similar named method with extra parameter and default value.
- ImapService was triggering a couple of -Woverloaded-virtual
warnings due to having extra methods with same name as base class.
These were really used internally so simpler as different named private.
- ImapProtocol / QString::lastIndexOf() was complaining about unused
return value. Using that should be even simpler than accessing regexp
match.
- Some small random warnings on unused parameters, missed switch case etc.
Change-Id: I243c09ab2d551fe2f8be18f1b3a4df2e3d84b55c
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: <matti.viljanen@kapsi.fi>
Diffstat (limited to 'examples/qtmail/qmailcomposer.cpp')
| -rw-r--r-- | examples/qtmail/qmailcomposer.cpp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/examples/qtmail/qmailcomposer.cpp b/examples/qtmail/qmailcomposer.cpp index 35a58c5e..e9eaf97a 100644 --- a/examples/qtmail/qmailcomposer.cpp +++ b/examples/qtmail/qmailcomposer.cpp @@ -319,6 +319,7 @@ QString QMailComposerFactory::defaultKey( QMailMessage::MessageType type ) */ QList<QMailMessage::MessageType> QMailComposerFactory::messageTypes( const QString& key ) { + Q_UNUSED(key) return composerInterface()->messageTypes(); } @@ -329,6 +330,7 @@ QList<QMailMessage::MessageType> QMailComposerFactory::messageTypes( const QStri */ QString QMailComposerFactory::name(const QString &key, QMailMessage::MessageType type) { + Q_UNUSED(key) return composerInterface()->name(type); } @@ -339,6 +341,7 @@ QString QMailComposerFactory::name(const QString &key, QMailMessage::MessageType */ QString QMailComposerFactory::displayName(const QString &key, QMailMessage::MessageType type) { + Q_UNUSED(key) return composerInterface()->displayName(type); } @@ -349,6 +352,7 @@ QString QMailComposerFactory::displayName(const QString &key, QMailMessage::Mess */ QIcon QMailComposerFactory::displayIcon(const QString &key, QMailMessage::MessageType type) { + Q_UNUSED(key) return composerInterface()->displayIcon(type); } @@ -358,7 +362,6 @@ QIcon QMailComposerFactory::displayIcon(const QString &key, QMailMessage::Messag */ QMailComposerInterface *QMailComposerFactory::create( const QString& key, QWidget *parent ) { - Q_UNUSED(parent); + Q_UNUSED(key) return new EmailComposerInterface(parent); } - |