diff options
| author | Pekka Vuorela <pvuorela@iki.fi> | 2025-11-04 09:32:10 +0200 |
|---|---|---|
| committer | Pekka Vuorela <pvuorela@iki.fi> | 2025-11-06 17:36:43 +0200 |
| commit | ced6584c65498661db5012602b0465e293476da0 (patch) | |
| tree | b10b8599bbfbeefa41f8ba84590b8b4aca531c76 /examples/serverobserver/serverobserver.cpp | |
| parent | 7e135a5c9305e889003b8c2cebb41633aaba012c (diff) | |
Avoid some more compiler warnings
- Missed earlier one QMessageBox deprecation from separate file
- LongStream now doing consistent open() check in all code paths.
Also removed unused member variable 'c' and moved internal constants
to .cpp.
- imapstrategy.h / ImapMessageListStrategy::selectedSectionsAppend()
was dead code due to derived class ImapFetchSelectedMessagesStrategy
having similar named method with extra parameter and default value.
- ImapService was triggering a couple of -Woverloaded-virtual
warnings due to having extra methods with same name as base class.
These were really used internally so simpler as different named private.
- ImapProtocol / QString::lastIndexOf() was complaining about unused
return value. Using that should be even simpler than accessing regexp
match.
- Some small random warnings on unused parameters, missed switch case etc.
Change-Id: I243c09ab2d551fe2f8be18f1b3a4df2e3d84b55c
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: <matti.viljanen@kapsi.fi>
Diffstat (limited to 'examples/serverobserver/serverobserver.cpp')
| -rw-r--r-- | examples/serverobserver/serverobserver.cpp | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/examples/serverobserver/serverobserver.cpp b/examples/serverobserver/serverobserver.cpp index 64a7772d..56051b47 100644 --- a/examples/serverobserver/serverobserver.cpp +++ b/examples/serverobserver/serverobserver.cpp @@ -99,8 +99,7 @@ RowWidget::RowWidget(QSharedPointer<QMailActionInfo> action, QWidget *parent) QString RowWidget::requestTypeToString(QMailServerRequestType t) { - switch (t) - { + switch (t) { case AcknowledgeNewMessagesRequestType: return tr("Acknowledging new messages"); case TransmitMessagesRequestType: @@ -147,12 +146,10 @@ QString RowWidget::requestTypeToString(QMailServerRequestType t) return tr("Listing actions"); case ProtocolRequestRequestType: return tr("Direct protocol request"); - // No default, to get warning when requests added + default: + qWarning() << "Did not handle:" << t; + return tr("Unknown/handled request."); } - - qWarning() << "Did not handle:" << t; - Q_ASSERT(false); - return tr("Unknown/handled request."); } void RowWidget::sendCancel() |