diff options
| author | Pekka Vuorela <pvuorela@iki.fi> | 2025-11-12 11:13:21 +0200 |
|---|---|---|
| committer | Pekka Vuorela <pvuorela@iki.fi> | 2025-11-12 16:33:27 +0200 |
| commit | de24e206b396395e4c73172371e488dbb1858e45 (patch) | |
| tree | 011487ae5ef413523b467ffd4f6bcc8166b91356 /examples | |
| parent | cbe4896d8017f27dd30333fe229dcaa440e2e147 (diff) | |
Remove qwidgets support from qmfmessageserver
This has little real life value. Any environment and apps starting to
use the framework will or should have their own UI style. Predefined
forms for some protocol configuration editing unlikely fits the rest.
Moreover the support has been opt-out instead of opt-in,
QMF_NO_MESSAGE_SERVICE_EDITOR which the _app_ has needed defined
according to how the library has been built. Should have been some
config.h provided by the framework according to how it's compiled.
QMailMessageServiceConfigurator class without the editor makes little
sense so removed altogether.
There's qtmail example that was using this. For now just left some
TODO comments to reimplement the account configuration.
Unknown how the example works these days in general.
Change-Id: I4122e2524a61797753999e67ecec36cb46213a7b
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Diffstat (limited to 'examples')
| -rw-r--r-- | examples/qtmail/CMakeLists.txt | 4 | ||||
| -rw-r--r-- | examples/qtmail/accountsettings.cpp | 10 | ||||
| -rw-r--r-- | examples/qtmail/editaccount.h | 2 | ||||
| -rw-r--r-- | examples/qtmail/qtmail.pro | 4 | ||||
| -rw-r--r-- | examples/serverobserver/CMakeLists.txt | 2 |
5 files changed, 14 insertions, 8 deletions
diff --git a/examples/qtmail/CMakeLists.txt b/examples/qtmail/CMakeLists.txt index f5f25e35..b6851df6 100644 --- a/examples/qtmail/CMakeLists.txt +++ b/examples/qtmail/CMakeLists.txt @@ -6,7 +6,7 @@ set(HEADERS readmail.h writemail.h accountsettings.h - editaccount.h + #editaccount.h statusmonitorwidget.h statusbar.h statusmonitor.h @@ -27,7 +27,7 @@ set(SRC readmail.cpp writemail.cpp accountsettings.cpp - editaccount.cpp + #editaccount.cpp statusmonitorwidget.cpp statusbar.cpp statusmonitor.cpp diff --git a/examples/qtmail/accountsettings.cpp b/examples/qtmail/accountsettings.cpp index e99b50dd..1ee76ea6 100644 --- a/examples/qtmail/accountsettings.cpp +++ b/examples/qtmail/accountsettings.cpp @@ -32,7 +32,7 @@ ****************************************************************************/ #include "accountsettings.h" -#include "editaccount.h" +//#include "editaccount.h" #include "statusbar.h" #include <qmailaccountlistmodel.h> #include <qmaillog.h> @@ -275,17 +275,21 @@ void AccountSettings::editAccount(QMailAccount *account) account->setStatus(QMailAccount::UserRemovable, true); } - QDialog *editAccountView; + int ret = QDialog::Rejected; bool wasPreferred(account->status() & QMailAccount::PreferredSender); +#if 0 // editor support removed from qmfmessageserver. need to reimplement config on app side + QDialog *editAccountView; + EditAccount *e = new EditAccount(this, "EditAccount"); e->setAccount(account, &config); editAccountView = e; editAccountView->setMinimumSize(QSize(400,400)); - int ret = editAccountView->exec(); + ret = editAccountView->exec(); delete editAccountView; +#endif if (ret == QDialog::Accepted) { QMailAccountId previousPreferredId; diff --git a/examples/qtmail/editaccount.h b/examples/qtmail/editaccount.h index e94e7b95..ed547d54 100644 --- a/examples/qtmail/editaccount.h +++ b/examples/qtmail/editaccount.h @@ -49,6 +49,8 @@ QT_END_NAMESPACE class QMailAccountConfiguration; class QMailAccount; +// FIXME the class here depends on qmfmessageserver editor support which got removed. +// The account configuration needs to be reimplemented on the app side class EditAccount : public QDialog { Q_OBJECT diff --git a/examples/qtmail/qtmail.pro b/examples/qtmail/qtmail.pro index deaa10a4..b8e48b08 100644 --- a/examples/qtmail/qtmail.pro +++ b/examples/qtmail/qtmail.pro @@ -16,7 +16,7 @@ HEADERS += emailclient.h \ readmail.h \ writemail.h \ accountsettings.h \ - editaccount.h \ + #editaccount.h \ statusmonitorwidget.h \ statusbar.h \ statusmonitor.h \ @@ -37,7 +37,7 @@ SOURCES += emailclient.cpp \ readmail.cpp \ writemail.cpp \ accountsettings.cpp \ - editaccount.cpp \ + #editaccount.cpp \ statusmonitorwidget.cpp \ statusbar.cpp \ statusmonitor.cpp \ diff --git a/examples/serverobserver/CMakeLists.txt b/examples/serverobserver/CMakeLists.txt index 8d9cc4e7..a7ab9e2a 100644 --- a/examples/serverobserver/CMakeLists.txt +++ b/examples/serverobserver/CMakeLists.txt @@ -7,4 +7,4 @@ add_executable(serverobserver ${SRC}) target_include_directories(serverobserver PRIVATE ../../src/libraries/qmfclient ../../src/libraries/qmfclient/support) target_link_libraries(serverobserver - PRIVATE Qt6::Core Qt6::Test QmfClient QmfMessageServer) + PRIVATE Qt6::Core Qt6::Test Qt6::Widgets QmfClient QmfMessageServer) |