diff options
| author | Pekka Vuorela <pvuorela@iki.fi> | 2025-11-04 09:32:10 +0200 |
|---|---|---|
| committer | Pekka Vuorela <pvuorela@iki.fi> | 2025-11-06 17:36:43 +0200 |
| commit | ced6584c65498661db5012602b0465e293476da0 (patch) | |
| tree | b10b8599bbfbeefa41f8ba84590b8b4aca531c76 /src/tools/messageserver/messageserver.cpp | |
| parent | 7e135a5c9305e889003b8c2cebb41633aaba012c (diff) | |
Avoid some more compiler warnings
- Missed earlier one QMessageBox deprecation from separate file
- LongStream now doing consistent open() check in all code paths.
Also removed unused member variable 'c' and moved internal constants
to .cpp.
- imapstrategy.h / ImapMessageListStrategy::selectedSectionsAppend()
was dead code due to derived class ImapFetchSelectedMessagesStrategy
having similar named method with extra parameter and default value.
- ImapService was triggering a couple of -Woverloaded-virtual
warnings due to having extra methods with same name as base class.
These were really used internally so simpler as different named private.
- ImapProtocol / QString::lastIndexOf() was complaining about unused
return value. Using that should be even simpler than accessing regexp
match.
- Some small random warnings on unused parameters, missed switch case etc.
Change-Id: I243c09ab2d551fe2f8be18f1b3a4df2e3d84b55c
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: <matti.viljanen@kapsi.fi>
Diffstat (limited to 'src/tools/messageserver/messageserver.cpp')
| -rw-r--r-- | src/tools/messageserver/messageserver.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/tools/messageserver/messageserver.cpp b/src/tools/messageserver/messageserver.cpp index 3c7c90cc..26dc9ace 100644 --- a/src/tools/messageserver/messageserver.cpp +++ b/src/tools/messageserver/messageserver.cpp @@ -542,7 +542,9 @@ void MessageServer::readLogSettings() const logFile.setFileName(fileName); } if (!logFile.isOpen()) { - logFile.open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Unbuffered); + if (!logFile.open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Unbuffered)) { + qWarning() << "Unable to open log file" << fileName; + } } } else { logFile.close(); |