diff options
| author | Pekka Vuorela <pvuorela@iki.fi> | 2025-12-08 09:50:53 +0200 |
|---|---|---|
| committer | Pekka Vuorela <pvuorela@iki.fi> | 2025-12-11 11:32:13 +0200 |
| commit | e503dedbf6d73dc22a7ed32a78806075da589ae7 (patch) | |
| tree | 273b0df42f5214a554f785c3f6f4a9f8ca36cfa3 /src/tools/messageserver/messageserver.cpp | |
| parent | 15a73fae6aaffbedc287359fba119e57613a2ed1 (diff) | |
Clean up service plugin signal connections - minor API changes
The states and signals were painful to follow due to bad naming
and excessive overloading.
Here:
- Renamed some API to avoid overloading, help readability and
allow new connect() syntax without resolving the overloads.
- updateStatus() signals and slots renamed a bit to make it clearer
what is a signal and what is a slot. And avoiding overloading
QMailMessageService::updateStatus() to simplify signal connection.
- Cleaned up QMailTranport API. It's not doing urls but hostnames
and the signals were especially hard to follow
- Use the new connect() syntax in messageserver side
- Avoiding some protected: / virtual methods when there's nothing
even able to inherit the class.
- At least print SSL errors instead of signal that's not connected
anywhere.
- Some minor simplifications and code style adjustments.
The SSL error handling is still funny but at least a bit easier to track.
Change-Id: If168e15ef068fedee46b9401d695ed5dae7962ba
Reviewed-by: <matti.viljanen@kapsi.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Diffstat (limited to 'src/tools/messageserver/messageserver.cpp')
| -rw-r--r-- | src/tools/messageserver/messageserver.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/messageserver/messageserver.cpp b/src/tools/messageserver/messageserver.cpp index 3e445382..70357171 100644 --- a/src/tools/messageserver/messageserver.cpp +++ b/src/tools/messageserver/messageserver.cpp @@ -155,7 +155,7 @@ bool MessageServer::init() this, &MessageServer::retrievalCompleted); // clean up any temporary messages that were not cleaned up by clients - QTimer::singleShot(0, this, SLOT(cleanupTemporaryMessages())); + QTimer::singleShot(0, this, &MessageServer::cleanupTemporaryMessages); emit handler->actionsListed(QMailActionDataList()); |