diff options
| author | Pekka Vuorela <pvuorela@iki.fi> | 2025-10-15 09:34:53 +0300 |
|---|---|---|
| committer | Pekka Vuorela <pvuorela@iki.fi> | 2025-10-15 14:15:05 +0300 |
| commit | 1368f02f1acb36b5842f44f605fa2ffe70a6ddc1 (patch) | |
| tree | cc3a6312e83b4c52d709965a5609131234d834b1 /src | |
| parent | f6cf9bf837c9edb7fae94cfba255b78cc428c7ca (diff) | |
Remove network status leftover class from SmtpService
Commit 1ff7dd4c878 removed the usage and made SmtpService attempt
fetching the capabilities for 5 minutes before giving up.
Kept a TODO item in different form.
Change-Id: If09e0f78fed7497f6100bc2c8a465cd9c8c9655f
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: <matti.viljanen@kapsi.fi>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/messageservices/smtp/smtpservice.cpp | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/src/plugins/messageservices/smtp/smtpservice.cpp b/src/plugins/messageservices/smtp/smtpservice.cpp index 529f7d48..32356c75 100644 --- a/src/plugins/messageservices/smtp/smtpservice.cpp +++ b/src/plugins/messageservices/smtp/smtpservice.cpp @@ -42,17 +42,6 @@ namespace { const QString serviceKey("smtp"); } -/* TODO: in future, use QNetworkInformation class */ -class NetworkStatusMonitor : public QObject -{ - Q_OBJECT -public: - NetworkStatusMonitor(QObject *parent = nullptr) : QObject(parent) {} - bool isOnline() const { return true; } -Q_SIGNALS: - void onlineStateChanged(bool online); -}; - class SmtpService::Sink : public QMailMessageSink { Q_OBJECT @@ -144,6 +133,8 @@ void SmtpService::onCapabilitiesFetched() { QMailAccount account(_client.account()); if (account.customField("qmf-smtp-capabilities-listed") != "true") { + // TODO: could consider should we give up faster if there's no network connectivity, + // e.g. check status with QNetworkInformation uint timeout = 1000; if (!_capabilityFetchTimeout) { _capabilityFetchTimeout = new QTimer(this); |