| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The related functionality was confusing when setContent() didn't
actually set any content but rather the type of it. Also there are
other setContent() methods around that actually set the content.
Then again calling this contentType() would have collided further
in the inheritance tree by method returning a QMailMessageContentType
which is referring to header fields. Thus switched this to a third
distinct name.
Old setter and getter names provided for backwards compatibility
which should work at least for the very basic cases of setting and
comparing type.
Change-Id: I4c54548f3c2c85096fde64b3221e233dd3feefa3
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: <matti.viljanen@kapsi.fi>
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Wrap some overly long lines
- Honor coding conventions better here and there
- Use nullptr more instead of '0'
- Switch remaining cases of Q_DECL_OVERRIDE and Q_NULLPTR to standard
keywords.
- Removed some unnecessary #includes
- etc.
Change-Id: Ia9a01807da88298a6c1c1bbb22c854743ed19429
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: <matti.viljanen@kapsi.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid data root directly in home directory, rather use QStandardPaths.
For backwards compatibility the old path is still used if it's there
and the new one doesn't exist.
QMail::tempPath() got removed. Evidently it's not much needed and
shouldn't really exist. The qmfclient doesn't use it al all and generally
apps should store their temporary things in their own places.
It's rarely wanted that there would be a common place to store such.
On the contrary, apps should play mostly in their own sandboxes.
TempPath was used on the server side but mostly either wrong or unnecessary:
- requests file is messageserver app specific, shouldn't be visible to
others.
- QMailMessageSource was using it wrong. New messages are added to
database, not temp path.
- LongStream with public cleanupTempFiles() could be dangerous if
it was called by multiple processes and having a common directory.
(Another story whether such an api should even exist though)
- SMTP, IMAP and LongStream can live with more generic locations.
The generic locations for the last ones are borderline whether it
should be TempLocation or CacheLocation. For side: interestingly
the usage is mostly storing content in files to save memory while
Linux world with /tmp as tmpfs has moved to storing files in memory to make
them faster. For now made smtp use temp location as that's a quite simple
usage, while imap and longstream in cache dir as they do have some
more complicated detaches and append usages, and they were earlier
out of the actual /tmp.
Did some simplifications to LongStream and a proper error
case handling to smtp client out of space error while at it.
Change-Id: If52de231082085d804939002371f5a407cd0fecd
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: <matti.viljanen@kapsi.fi>
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The QWidgets side is on its way out but fixing build in the meanwhile
is simple enough. Maybe there's some benefit in having some more
code here using the library.
Not bothering about all the details here.
Change-Id: I4ba71d03a5083623bf3cdb79082d6c77283f06bb
Reviewed-by: <matti.viljanen@kapsi.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Fwd classes were inherited by the actual classes, allowing to #include
only the fwd and not the bigger real class header. Such a compilation time
micro optimization shouldn't really be worth complicating the API.
Thus just moved the enum content to actual classes.
For some backwards compatibility made the Fwd classes typedeffed to the
real ones.
Crypto side didn't even have a proper class, only the Fwd and suppose
all the usage of the code just did include anyway for the whole crypto api.
The QMailFolderFwd::PredefinedFolderId was having a cyclic dependency
when moved to QMailFolder: QMailFolderId ctor variant was depending on
it and QMailFolder was depending on the Id. Moved the predefined id to
the Id class which feels like a better home anyway.
Change-Id: I9a9aa9c407ae90cc11b37179fe417e3a002ce94b
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: <matti.viljanen@kapsi.fi>
|
| |
|
|
|
|
|
| |
Change-Id: I57c6ed78099b3359a16ce807da95325e755f0197
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: <matti.viljanen@kapsi.fi>
|
| |
|
|
|
|
|
| |
Change-Id: Iebfffe7a6d5b2db40f0508ecd7c8ccddfa6665a6
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: <matti.viljanen@kapsi.fi>
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adjust source code where necessary like:
- #include <private/...> cannot be used since
private is the installation path, but not
the path used in the sources,
- fix map definition in qmailservice.xml,
- had to add #include <qmailstore.h> to
qmailserviceaction.h since qt_add_dbus_adaptor
can only include one header,
- add a method using QDBusVariant in
ServiceHandler so the adaptor can call it.
Change-Id: Idbecf4214dffdf523ccd8558370e8d2854b5d99a
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
|
| |
|
|
|
|
|
|
|
|
| |
Any case where the address of an element is taken and stored or
used, must be changed to use QmfList instead of QList, otherwise
non-const operations will cause the reference to become invalid.
Change-Id: Ic0017cb9eddcf27b93d26adb3ea9c71682c4421b
Reviewed-by: Christopher Adams <chris.adams@jolla.com>
Reviewed-by: David Llewellyn-Jones <david.llewellyn-jones@jolla.com>
|
| |
|
|
|
| |
Change-Id: I67eb29e13c5e643ee2f58a0696400e085999c01c
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
|
| |
|
|
|
|
|
| |
MSVC doesn't like #warning apparently.
Change-Id: Ia3f04765c5c34a5325784e7fd7890d8f5542ae8f
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
|
| |
|
|
|
| |
Change-Id: Icce55517963f0cbc35211e9fc6f1a0fc413f5676
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
|
|
|
Change-Id: Id59253e1d121ab0dfcdb59f7018b897f6c1df086
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|