| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Wrap some overly long lines
- Honor coding conventions better here and there
- Use nullptr more instead of '0'
- Switch remaining cases of Q_DECL_OVERRIDE and Q_NULLPTR to standard
keywords.
- Removed some unnecessary #includes
- etc.
Change-Id: Ia9a01807da88298a6c1c1bbb22c854743ed19429
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: <matti.viljanen@kapsi.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has little real life value. Any environment and apps starting to
use the framework will or should have their own UI style. Predefined
forms for some protocol configuration editing unlikely fits the rest.
Moreover the support has been opt-out instead of opt-in,
QMF_NO_MESSAGE_SERVICE_EDITOR which the _app_ has needed defined
according to how the library has been built. Should have been some
config.h provided by the framework according to how it's compiled.
QMailMessageServiceConfigurator class without the editor makes little
sense so removed altogether.
There's qtmail example that was using this. For now just left some
TODO comments to reimplement the account configuration.
Unknown how the example works these days in general.
Change-Id: I4122e2524a61797753999e67ecec36cb46213a7b
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Missed earlier one QMessageBox deprecation from separate file
- LongStream now doing consistent open() check in all code paths.
Also removed unused member variable 'c' and moved internal constants
to .cpp.
- imapstrategy.h / ImapMessageListStrategy::selectedSectionsAppend()
was dead code due to derived class ImapFetchSelectedMessagesStrategy
having similar named method with extra parameter and default value.
- ImapService was triggering a couple of -Woverloaded-virtual
warnings due to having extra methods with same name as base class.
These were really used internally so simpler as different named private.
- ImapProtocol / QString::lastIndexOf() was complaining about unused
return value. Using that should be even simpler than accessing regexp
match.
- Some small random warnings on unused parameters, missed switch case etc.
Change-Id: I243c09ab2d551fe2f8be18f1b3a4df2e3d84b55c
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: <matti.viljanen@kapsi.fi>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Qt6 it's strange to have messageserver5. Could have bumped the
binary there to '6' but maybe we don't really need to highlight the
qt version that much. The '5's were added to allow parallel
installability but that really matters more on libraries etc rather
than the server. We don't want parallel installed daemons fighting who
gets autostarted first.
Also on credential side it shouldn't matter which was the Qt version.
Switching to newer version should still be about the same service.
In practice don't think the names matter too much, and auth success is
ignored so think it should be ok just changing the naming.
Removed the '5's from examples too. No need there.
Left the .pro file binary as it was as that side now mostly serves the
Qt5 builds where we wouldn't benefit much from changing the binary name.
Change-Id: Ie4a843c944caa73b080e3610baee4842500f029b
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: <matti.viljanen@kapsi.fi>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The QWidgets side is on its way out but fixing build in the meanwhile
is simple enough. Maybe there's some benefit in having some more
code here using the library.
Not bothering about all the details here.
Change-Id: I4ba71d03a5083623bf3cdb79082d6c77283f06bb
Reviewed-by: <matti.viljanen@kapsi.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
|
| |
|
|
|
|
|
| |
Change-Id: I57c6ed78099b3359a16ce807da95325e755f0197
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: <matti.viljanen@kapsi.fi>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adjust source code where necessary like:
- #include <private/...> cannot be used since
private is the installation path, but not
the path used in the sources,
- fix map definition in qmailservice.xml,
- had to add #include <qmailstore.h> to
qmailserviceaction.h since qt_add_dbus_adaptor
can only include one header,
- add a method using QDBusVariant in
ServiceHandler so the adaptor can call it.
Change-Id: Idbecf4214dffdf523ccd8558370e8d2854b5d99a
Reviewed-by: Pekka Vuorela <pvuorela@iki.fi>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
messageserver.pri not used anywhere.
Neither PLUGIN_INTERNAL definition is no longer used anywhere.
The common.pri isn't too good a common file as it's mostly included
outside the src tree, only src/tools/messageserver uses it from the
actual sources. Hence removing QMF_ENABLE_LOGGING shouldn't affect
anything since it's used only in the libqmfclient for one thing.
To use that properly one has needed the definition value passed
externally.
The win/mac special case release mode I didn't understand too well
and neither did qtbase run_pro2cmake.py I was testing to proceed with
cmake build. Unsure was that CONFIG_WIN working even in qt5 or was that
some earlier thing.
The mac bundle would have been used only for unit tests and such, so
feels pointless. As neither target now even works because of d-bus ipc,
let's just remove this part.
Removing these makes the common.pri even more pointless so just moved
the INSTALL=target to few places that were using the common.pri
Change-Id: Ibfe6da554e0d452e09d08e184e22508c1af958e0
Reviewed-by: Damien Caliste <dcaliste@free.fr>
Reviewed-by: Christopher Adams <chris.adams@qinetic.com.au>
|
| |
|
|
|
|
| |
Change-Id: I7aacfd91f7ec77dc50026820dd4379a4e42c5d53
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
Reviewed-by: Christopher Adams <chris.adams@jollamobile.com>
|
| |
|
|
|
| |
Change-Id: I67eb29e13c5e643ee2f58a0696400e085999c01c
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
|
| |
|
|
|
| |
Change-Id: Iac431ae2d56c2b9fd419651e6cb28c455db55259
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
|
| |
|
|
|
| |
Change-Id: Icce55517963f0cbc35211e9fc6f1a0fc413f5676
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QmfMessageServer.
This was not possible prior to now due to Qt 4 support hanging around like the
undead vampire it is, but now we purged it with fire and light, and the build
system looks a lot less like a stinky, decomposed corpse.
There's still a lot of surprises lurking: qtmail is one such surprise. I don't
quite grasp why it's so heavy on plugins, and qmfutil also needs some...
attention. But at least it's a start.
As part of this work, we rename the qcop headers to fit the private convention.
This could have been done in a prior commit, but given that I didn't have an
easy way to build prior to this commit, I opted to roll them together.
Change-Id: Ia3e288ffc3639a7751c9040ceecb54fca77a31b1
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
Reviewed-by: Valerio Valerio <valerio.valerio@jollamobile.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
This has persisted long enough, and as far as I am aware, has no users. It is
also blocking potential build system cleanups and other good things.
Reviewed-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
Change-Id: I5e0e0549ef6ffee31b5e60ec94a9e17f27e01436
Reviewed-by: John Brooks <john.brooks@dereferenced.net>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|
| |
|
|
|
|
|
|
|
|
| |
This makes build system detect if Qt libraries are built as framework or not and
add correct flags to LIBS.
Change-Id: Ifb0d2ed87f5d624966395bce39959ce53f1dee89
Reviewed-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Reviewed-by: Tasuku Suzuki <stasuku@gmail.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|
| |
|
|
|
|
|
|
| |
Signed-off-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Change-Id: I2c03d287fc871098cf45d75d4a1262b9c6c4378d
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
|
| |
|
|
|
|
|
|
| |
Update code base to match latest release of Qt.
Signed-off-by: Valerio Valerio <valerio.valerio@jollamobile.com>
Change-Id: I02c2ff250ea8cd960938b81903e92b04c745ae9c
Reviewed-by: Matthew Vogt <matthew.vogt@qinetic.com.au>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
|
| |
|
|
|
| |
Change-Id: If0f4427ee93a37de4ebd9e097defd8b3956f0fc6
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
|
| |
|
|
|
|
| |
as they do nothing.
Thanks to Valerio for the patch.
|
| |
|
|
| |
Remove obsolete pre-release clause.
|
| | |
|
| |
|
|
| |
This is done to avoid conflicts with the QPID Management Framework
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Library Renames:
libmessageserver -> libqmfmessageserver
libqtopiamail -> libqmf
Directory Changes:
src/libraries/messageserver -> src/libraries/qmfmessageserver
src/libraries/qtopiamail -> src/libraries/qmf
src/plugins/contentmanagers/qtopiamailfile -> qmfstoragemanager
src/plugins/messageservices/qtopiamailfile -> qmfsettings
Class changes:
QtopiamailfileConfigurator -> QmfConfigurator
QtopiamailfileSettings -> QmfSettings
QtopiamailfileServicePlugin -> QmfServicePlugin
QtopiamailfileManager -> QmfStorageManager
There's still a few outstanding changes in the docs / translations
that should be fixed shortly.
|
| |
|
|
| |
It's quite dirty, but it's also quite useful
|
| | |
|
| |
|