1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
|
// Copyright 2022 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "src/maglev/maglev-compiler.h"
#include <iomanip>
#include <ostream>
#include <type_traits>
#include "src/base/iterator.h"
#include "src/base/logging.h"
#include "src/base/threaded-list.h"
#include "src/codegen/interface-descriptors-inl.h"
#include "src/codegen/machine-type.h"
#include "src/codegen/register-configuration.h"
#include "src/codegen/register.h"
#include "src/codegen/reglist.h"
#include "src/common/globals.h"
#include "src/compiler/backend/instruction.h"
#include "src/compiler/bytecode-liveness-map.h"
#include "src/compiler/compilation-dependencies.h"
#include "src/compiler/heap-refs.h"
#include "src/compiler/js-heap-broker.h"
#include "src/deoptimizer/frame-translation-builder.h"
#include "src/execution/frames.h"
#include "src/ic/handler-configuration.h"
#include "src/maglev/maglev-basic-block.h"
#include "src/maglev/maglev-code-generator.h"
#include "src/maglev/maglev-compilation-info.h"
#include "src/maglev/maglev-compilation-unit.h"
#include "src/maglev/maglev-graph-builder.h"
#include "src/maglev/maglev-graph-labeller.h"
#include "src/maglev/maglev-graph-printer.h"
#include "src/maglev/maglev-graph-processor.h"
#include "src/maglev/maglev-graph-verifier.h"
#include "src/maglev/maglev-graph.h"
#include "src/maglev/maglev-interpreter-frame-state.h"
#include "src/maglev/maglev-ir-inl.h"
#include "src/maglev/maglev-ir.h"
#include "src/maglev/maglev-phi-representation-selector.h"
#include "src/maglev/maglev-regalloc-data.h"
#include "src/maglev/maglev-regalloc.h"
#include "src/objects/code-inl.h"
#include "src/objects/js-function.h"
#include "src/utils/identity-map.h"
#include "src/zone/zone.h"
namespace v8 {
namespace internal {
namespace maglev {
class ValueLocationConstraintProcessor {
public:
void PreProcessGraph(Graph* graph) {}
void PostProcessGraph(Graph* graph) {}
void PreProcessBasicBlock(BasicBlock* block) {}
#define DEF_PROCESS_NODE(NAME) \
ProcessResult Process(NAME* node, const ProcessingState& state) { \
node->SetValueLocationConstraints(); \
return ProcessResult::kContinue; \
}
NODE_BASE_LIST(DEF_PROCESS_NODE)
#undef DEF_PROCESS_NODE
};
class DecompressedUseMarkingProcessor {
public:
void PreProcessGraph(Graph* graph) {}
void PostProcessGraph(Graph* graph) {}
void PreProcessBasicBlock(BasicBlock* block) {}
template <typename NodeT>
ProcessResult Process(NodeT* node, const ProcessingState& state) {
#ifdef V8_COMPRESS_POINTERS
node->MarkTaggedInputsAsDecompressing();
#endif
return ProcessResult::kContinue;
}
};
class MaxCallDepthProcessor {
public:
void PreProcessGraph(Graph* graph) {}
void PostProcessGraph(Graph* graph) {
graph->set_max_call_stack_args(max_call_stack_args_);
graph->set_max_deopted_stack_size(max_deopted_stack_size_);
}
void PreProcessBasicBlock(BasicBlock* block) {}
template <typename NodeT>
ProcessResult Process(NodeT* node, const ProcessingState& state) {
if constexpr (NodeT::kProperties.is_call() ||
NodeT::kProperties.needs_register_snapshot()) {
int node_stack_args = node->MaxCallStackArgs();
if constexpr (NodeT::kProperties.needs_register_snapshot()) {
// Pessimistically assume that we'll push all registers in deferred
// calls.
node_stack_args +=
kAllocatableGeneralRegisterCount + kAllocatableDoubleRegisterCount;
}
max_call_stack_args_ = std::max(max_call_stack_args_, node_stack_args);
}
if constexpr (NodeT::kProperties.can_eager_deopt()) {
UpdateMaxDeoptedStackSize(node->eager_deopt_info());
}
if constexpr (NodeT::kProperties.can_lazy_deopt()) {
UpdateMaxDeoptedStackSize(node->lazy_deopt_info());
}
return ProcessResult::kContinue;
}
private:
void UpdateMaxDeoptedStackSize(DeoptInfo* deopt_info) {
const DeoptFrame* deopt_frame = &deopt_info->top_frame();
if (deopt_frame->type() == DeoptFrame::FrameType::kInterpretedFrame) {
if (&deopt_frame->as_interpreted().unit() == last_seen_unit_) return;
last_seen_unit_ = &deopt_frame->as_interpreted().unit();
}
int frame_size = 0;
do {
frame_size += ConservativeFrameSize(deopt_frame);
deopt_frame = deopt_frame->parent();
} while (deopt_frame != nullptr);
max_deopted_stack_size_ = std::max(frame_size, max_deopted_stack_size_);
}
int ConservativeFrameSize(const DeoptFrame* deopt_frame) {
switch (deopt_frame->type()) {
case DeoptFrame::FrameType::kInterpretedFrame: {
auto info = UnoptimizedFrameInfo::Conservative(
deopt_frame->as_interpreted().unit().parameter_count(),
deopt_frame->as_interpreted().unit().register_count());
return info.frame_size_in_bytes();
}
case DeoptFrame::FrameType::kConstructInvokeStubFrame: {
return FastConstructStubFrameInfo::Conservative().frame_size_in_bytes();
}
case DeoptFrame::FrameType::kInlinedArgumentsFrame: {
return std::max(
0,
static_cast<int>(
deopt_frame->as_inlined_arguments().arguments().size() -
deopt_frame->as_inlined_arguments().unit().parameter_count()) *
kSystemPointerSize);
}
case DeoptFrame::FrameType::kBuiltinContinuationFrame: {
// PC + FP + Closure + Params + Context
const RegisterConfiguration* config = RegisterConfiguration::Default();
auto info = BuiltinContinuationFrameInfo::Conservative(
deopt_frame->as_builtin_continuation().parameters().length(),
Builtins::CallInterfaceDescriptorFor(
deopt_frame->as_builtin_continuation().builtin_id()),
config);
return info.frame_size_in_bytes();
}
}
}
int max_call_stack_args_ = 0;
int max_deopted_stack_size_ = 0;
// Optimize UpdateMaxDeoptedStackSize to not re-calculate if it sees the same
// compilation unit multiple times in a row.
const MaglevCompilationUnit* last_seen_unit_ = nullptr;
};
class UseMarkingProcessor {
public:
explicit UseMarkingProcessor(MaglevCompilationInfo* compilation_info)
: compilation_info_(compilation_info) {}
void PreProcessGraph(Graph* graph) {}
void PostProcessGraph(Graph* graph) { DCHECK(loop_used_nodes_.empty()); }
void PreProcessBasicBlock(BasicBlock* block) {
if (!block->has_state()) return;
if (block->state()->is_loop()) {
loop_used_nodes_.push_back(
LoopUsedNodes{{}, kInvalidNodeId, kInvalidNodeId, block});
}
}
template <typename NodeT>
ProcessResult Process(NodeT* node, const ProcessingState& state) {
node->set_id(next_node_id_++);
LoopUsedNodes* loop_used_nodes = GetCurrentLoopUsedNodes();
if (loop_used_nodes && node->properties().is_call() &&
loop_used_nodes->header->has_state()) {
if (loop_used_nodes->first_call == kInvalidNodeId) {
loop_used_nodes->first_call = node->id();
}
loop_used_nodes->last_call = node->id();
}
MarkInputUses(node, state);
return ProcessResult::kContinue;
}
template <typename NodeT>
void MarkInputUses(NodeT* node, const ProcessingState& state) {
LoopUsedNodes* loop_used_nodes = GetCurrentLoopUsedNodes();
// Mark input uses in the same order as inputs are assigned in the register
// allocator (see StraightForwardRegisterAllocator::AssignInputs).
node->ForAllInputsInRegallocAssignmentOrder(
[&](NodeBase::InputAllocationPolicy, Input* input) {
MarkUse(input->node(), node->id(), input, loop_used_nodes);
});
if constexpr (NodeT::kProperties.can_eager_deopt()) {
MarkCheckpointNodes(node, node->eager_deopt_info(), loop_used_nodes,
state);
}
if constexpr (NodeT::kProperties.can_lazy_deopt()) {
MarkCheckpointNodes(node, node->lazy_deopt_info(), loop_used_nodes,
state);
}
}
void MarkInputUses(Phi* node, const ProcessingState& state) {
// Don't mark Phi uses when visiting the node, because of loop phis.
// Instead, they'll be visited while processing Jump/JumpLoop.
}
// Specialize the two unconditional jumps to extend their Phis' inputs' live
// ranges.
void MarkInputUses(JumpLoop* node, const ProcessingState& state) {
int i = state.block()->predecessor_id();
BasicBlock* target = node->target();
uint32_t use = node->id();
DCHECK(!loop_used_nodes_.empty());
LoopUsedNodes loop_used_nodes = std::move(loop_used_nodes_.back());
loop_used_nodes_.pop_back();
LoopUsedNodes* outer_loop_used_nodes = GetCurrentLoopUsedNodes();
if (target->has_phi()) {
for (Phi* phi : *target->phis()) {
ValueNode* input = phi->input(i).node();
MarkUse(input, use, &phi->input(i), outer_loop_used_nodes);
}
}
DCHECK_EQ(loop_used_nodes.header, target);
if (!loop_used_nodes.used_nodes.empty()) {
// Try to avoid unnecessary reloads or spills across the back-edge based
// on use positions and calls inside the loop.
ZonePtrList<ValueNode>& reload_hints =
loop_used_nodes.header->reload_hints();
ZonePtrList<ValueNode>& spill_hints =
loop_used_nodes.header->spill_hints();
for (auto p : loop_used_nodes.used_nodes) {
// If the node is used before the first call and after the last call,
// keep it in a register across the back-edge.
if (p.second.first_register_use != kInvalidNodeId &&
(loop_used_nodes.first_call == kInvalidNodeId ||
(p.second.first_register_use <= loop_used_nodes.first_call &&
p.second.last_register_use > loop_used_nodes.last_call))) {
reload_hints.Add(p.first, compilation_info_->zone());
}
// If the node is not used, or used after the first call and before the
// last call, keep it spilled across the back-edge.
if (p.second.first_register_use == kInvalidNodeId ||
(loop_used_nodes.first_call != kInvalidNodeId &&
p.second.first_register_use > loop_used_nodes.first_call &&
p.second.last_register_use <= loop_used_nodes.last_call)) {
spill_hints.Add(p.first, compilation_info_->zone());
}
}
// Uses of nodes in this loop may need to propagate to an outer loop, so
// that they're lifetime is extended there too.
// TODO(leszeks): We only need to extend the lifetime in one outermost
// loop, allow nodes to be "moved" between lifetime extensions.
base::Vector<Input> used_node_inputs =
compilation_info_->zone()->AllocateVector<Input>(
loop_used_nodes.used_nodes.size());
int i = 0;
for (auto& [used_node, info] : loop_used_nodes.used_nodes) {
Input* input = new (&used_node_inputs[i++]) Input(used_node);
MarkUse(used_node, use, input, outer_loop_used_nodes);
}
node->set_used_nodes(used_node_inputs);
}
}
void MarkInputUses(Jump* node, const ProcessingState& state) {
int i = state.block()->predecessor_id();
BasicBlock* target = node->target();
if (!target->has_phi()) return;
uint32_t use = node->id();
LoopUsedNodes* loop_used_nodes = GetCurrentLoopUsedNodes();
for (Phi* phi : *target->phis()) {
ValueNode* input = phi->input(i).node();
MarkUse(input, use, &phi->input(i), loop_used_nodes);
}
}
private:
struct NodeUse {
// First and last register use inside a loop.
NodeIdT first_register_use;
NodeIdT last_register_use;
};
struct LoopUsedNodes {
std::map<ValueNode*, NodeUse> used_nodes;
NodeIdT first_call;
NodeIdT last_call;
BasicBlock* header;
};
LoopUsedNodes* GetCurrentLoopUsedNodes() {
if (loop_used_nodes_.empty()) return nullptr;
return &loop_used_nodes_.back();
}
void MarkUse(ValueNode* node, uint32_t use_id, InputLocation* input,
LoopUsedNodes* loop_used_nodes) {
node->mark_use(use_id, input);
// If we are in a loop, loop_used_nodes is non-null. In this case, check if
// the incoming node is from outside the loop, and make sure to extend its
// lifetime to the loop end if yes.
if (loop_used_nodes) {
// If the node's id is smaller than the smallest id inside the loop, then
// it must have been created before the loop. This means that it's alive
// on loop entry, and therefore has to be alive across the loop back edge
// too.
if (node->id() < loop_used_nodes->header->first_id()) {
auto [it, info] = loop_used_nodes->used_nodes.emplace(
node, NodeUse{kInvalidNodeId, kInvalidNodeId});
if (input->operand().IsUnallocated()) {
const auto& operand =
compiler::UnallocatedOperand::cast(input->operand());
if (operand.HasRegisterPolicy() || operand.HasFixedRegisterPolicy() ||
operand.HasFixedFPRegisterPolicy()) {
if (it->second.first_register_use == kInvalidNodeId) {
it->second.first_register_use = use_id;
}
it->second.last_register_use = use_id;
}
}
}
}
}
void MarkCheckpointNodes(NodeBase* node, const EagerDeoptInfo* deopt_info,
LoopUsedNodes* loop_used_nodes,
const ProcessingState& state) {
int use_id = node->id();
detail::DeepForEachInput(deopt_info,
[&](ValueNode* node, InputLocation* input) {
MarkUse(node, use_id, input, loop_used_nodes);
});
}
void MarkCheckpointNodes(NodeBase* node, const LazyDeoptInfo* deopt_info,
LoopUsedNodes* loop_used_nodes,
const ProcessingState& state) {
int use_id = node->id();
detail::DeepForEachInput(deopt_info,
[&](ValueNode* node, InputLocation* input) {
MarkUse(node, use_id, input, loop_used_nodes);
});
}
MaglevCompilationInfo* compilation_info_;
uint32_t next_node_id_ = kFirstValidNodeId;
std::vector<LoopUsedNodes> loop_used_nodes_;
};
// static
bool MaglevCompiler::Compile(LocalIsolate* local_isolate,
MaglevCompilationInfo* compilation_info) {
compiler::CurrentHeapBrokerScope current_broker(compilation_info->broker());
Graph* graph =
Graph::New(compilation_info->zone(),
compilation_info->toplevel_compilation_unit()->is_osr());
// Build graph.
if (v8_flags.print_maglev_code || v8_flags.code_comments ||
v8_flags.print_maglev_graph || v8_flags.print_maglev_graphs ||
v8_flags.trace_maglev_graph_building ||
v8_flags.trace_maglev_phi_untagging || v8_flags.trace_maglev_regalloc) {
compilation_info->set_graph_labeller(new MaglevGraphLabeller());
}
{
UnparkedScopeIfOnBackground unparked_scope(local_isolate->heap());
if (v8_flags.print_maglev_code || v8_flags.print_maglev_graph ||
v8_flags.print_maglev_graphs || v8_flags.trace_maglev_graph_building ||
v8_flags.trace_maglev_phi_untagging || v8_flags.trace_maglev_regalloc) {
MaglevCompilationUnit* top_level_unit =
compilation_info->toplevel_compilation_unit();
std::cout << "Compiling " << Brief(*compilation_info->toplevel_function())
<< " with Maglev\n";
BytecodeArray::Disassemble(top_level_unit->bytecode().object(),
std::cout);
if (v8_flags.maglev_print_feedback) {
Print(*top_level_unit->feedback().object(), std::cout);
}
}
MaglevGraphBuilder graph_builder(
local_isolate, compilation_info->toplevel_compilation_unit(), graph);
{
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"),
"V8.Maglev.GraphBuilding");
graph_builder.Build();
if (v8_flags.print_maglev_graphs) {
std::cout << "\nAfter graph buiding" << std::endl;
PrintGraph(std::cout, compilation_info, graph);
}
}
if (v8_flags.maglev_untagged_phis) {
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"),
"V8.Maglev.PhiUntagging");
GraphProcessor<MaglevPhiRepresentationSelector> representation_selector(
&graph_builder);
representation_selector.ProcessGraph(graph);
if (v8_flags.print_maglev_graphs) {
std::cout << "\nAfter Phi untagging" << std::endl;
PrintGraph(std::cout, compilation_info, graph);
}
}
}
#ifdef DEBUG
{
GraphProcessor<MaglevGraphVerifier> verifier(compilation_info);
verifier.ProcessGraph(graph);
}
#endif
{
// Preprocessing for register allocation and code gen:
// - Collect input/output location constraints
// - Find the maximum number of stack arguments passed to calls
// - Collect use information, for SSA liveness and next-use distance.
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"),
"V8.Maglev.NodeProcessing");
GraphMultiProcessor<ValueLocationConstraintProcessor, MaxCallDepthProcessor,
UseMarkingProcessor, DecompressedUseMarkingProcessor>
processor(UseMarkingProcessor{compilation_info});
processor.ProcessGraph(graph);
}
if (v8_flags.print_maglev_graphs) {
UnparkedScopeIfOnBackground unparked_scope(local_isolate->heap());
std::cout << "After register allocation pre-processing" << std::endl;
PrintGraph(std::cout, compilation_info, graph);
}
{
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"),
"V8.Maglev.RegisterAllocation");
StraightForwardRegisterAllocator allocator(compilation_info, graph);
if (v8_flags.print_maglev_graph || v8_flags.print_maglev_graphs) {
UnparkedScopeIfOnBackground unparked_scope(local_isolate->heap());
std::cout << "After register allocation" << std::endl;
PrintGraph(std::cout, compilation_info, graph);
}
}
{
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"),
"V8.Maglev.CodeAssembly");
UnparkedScopeIfOnBackground unparked_scope(local_isolate->heap());
std::unique_ptr<MaglevCodeGenerator> code_generator =
std::make_unique<MaglevCodeGenerator>(local_isolate, compilation_info,
graph);
bool success = code_generator->Assemble();
if (!success) {
return false;
}
// Stash the compiled code_generator on the compilation info.
compilation_info->set_code_generator(std::move(code_generator));
}
return true;
}
// static
MaybeHandle<Code> MaglevCompiler::GenerateCode(
Isolate* isolate, MaglevCompilationInfo* compilation_info) {
compiler::CurrentHeapBrokerScope current_broker(compilation_info->broker());
MaglevCodeGenerator* const code_generator =
compilation_info->code_generator();
DCHECK_NOT_NULL(code_generator);
Handle<Code> code;
{
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"),
"V8.Maglev.CodeGeneration");
if (compilation_info->is_detached() ||
!code_generator->Generate(isolate).ToHandle(&code)) {
compilation_info->toplevel_compilation_unit()
->shared_function_info()
.object()
->set_maglev_compilation_failed(true);
return {};
}
}
{
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"),
"V8.Maglev.CommittingDependencies");
if (!compilation_info->broker()->dependencies()->Commit(code)) {
// Don't `set_maglev_compilation_failed` s.t. we may reattempt
// compilation.
// TODO(v8:7700): Make this more robust, i.e.: don't recompile endlessly,
// and possibly attempt to recompile as early as possible.
return {};
}
}
if (v8_flags.print_maglev_code) {
Print(*code);
}
return code;
}
} // namespace maglev
} // namespace internal
} // namespace v8
|