diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2024-08-26 18:02:42 +0200 |
|---|---|---|
| committer | Kaloyan Chehlarski <kaloyan.chehlarski@qt.io> | 2024-08-28 09:31:03 +0200 |
| commit | 46d1e664f2d100355dfcf2438d775189c4d8c0f7 (patch) | |
| tree | ccdee8b86939530bad2ec0123b29c99a69e50e2c /src/core/api/qwebenginepermission.cpp | |
| parent | d088800e7e088203e85360c40af9722953606ba6 (diff) | |
QWebEnginePermission: fix move ctor and QESDP macro use
Unless you =default also ~Public(), the _WITH_EXPORT version of
QT_DECLARE_QESDP_SPECIALIZATION_DTOR is not needed, and could cause
problems with linker scripts that try to keep private API out of the
ABI. For an inline move ctor, the export isn't needed, because the
compiler never calls the d_ptr dtor (even though it must be present
during compilation).
Also fix the move ctor to be inline, noexcept and =default'ed. That's
the whole point of using the QESDP macros, after all.
Found in API-review.
Pick-to: 6.8
Change-Id: Id4092e98931cbbd7334a7cfe763696b8b9b4948a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Kaloyan Chehlarski <kaloyan.chehlarski@qt.io>
Diffstat (limited to 'src/core/api/qwebenginepermission.cpp')
| -rw-r--r-- | src/core/api/qwebenginepermission.cpp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/core/api/qwebenginepermission.cpp b/src/core/api/qwebenginepermission.cpp index d6f5ed98f..5fa1ed484 100644 --- a/src/core/api/qwebenginepermission.cpp +++ b/src/core/api/qwebenginepermission.cpp @@ -93,11 +93,6 @@ QWebEnginePermission::QWebEnginePermission(const QWebEnginePermission &other) { } -QWebEnginePermission::QWebEnginePermission(QWebEnginePermission &&other) - : d_ptr(std::move(other.d_ptr)) -{ -} - QWebEnginePermission::~QWebEnginePermission() = default; QWebEnginePermission &QWebEnginePermission::operator=(const QWebEnginePermission &other) |