summaryrefslogtreecommitdiffstats
path: root/examples/webenginewidgets/simplebrowser/downloadwidget.cpp
Commit message (Collapse)AuthorAgeFilesLines
* fix conditional redundancy for receivedBytesTian Shilin2024-08-161-1/+5
| | | | | | | | | | | | In updateWidget,receivedBytes / m_timeAdded.elapsed() * 1000 may divide by zero,if m_timeAdded.elapsed() returns 0, it will cause the denominator in the division to be zero, which will trigger a warning or error, to fix this, check the m_timeAdded.elapsed() is zero, if it is, you can set a default value () or just set bytesPerSecond to 0 to avoid dividing by zero. Pick-to: 6.8 6.7 Change-Id: Id73b287d44241f97271308f85c64d4830b944948 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* fix conditional redundancy for totalBytesTian Shilin2024-08-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | m_progressBar->setValue(qRound(100 * receivedBytes / totalBytes)); There is a potential risk of de-zeroing here, since receivedBytes / totalBytes will trigger a runtime error if totalBytes is zero. In addition, if totalBytes is always greater than or equal to 0, then checking for totalBytes >= 0 is actually redundant, since the concern should be that totalBytes is not zero. To ensure the robustness of the code, a check that totalBytes is zero should be added to prevent divide-by-zero errors. By ensuring that totalBytes is greater than zero, this improvement not only avoids the risk of de-zeroing, but also ensures that the percentage calculation of the progress bar is meaningful. At the same time, for cases where totalBytes is 0 or unknown, the progress bar is displayed as 0% and the format is "unknown size". This is a safer way to handle the situation and is more in line with the needs of the actual application. Pick-to: 6.8 6.7 Change-Id: I7537243e375f336f5c68ef1cc6ec8ade8fa16e5c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* simplebrowser example: Use new theme iconsFriedemann Kleint2024-04-051-2/+4
| | | | | | Pick-to: 6.7 Change-Id: I1fe5fe8620055eec7c7fd4831459b0aa39864f97 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Simple browser example: Fix clazy warningsFriedemann Kleint2023-03-301-13/+8
| | | | | | | | | - else after return - Use multiarg version of QString::arg(QString) Pick-to: 6.5 Change-Id: Iceff3ee8877b866b5b9187cd85da54864ab17834 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Simple browser example: Use modern string literalsFriedemann Kleint2023-03-281-2/+4
| | | | | | Pick-to: 6.5 Change-Id: I14ed5efed1bf228239f95a8a4addce5d19a9f220 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Use SPDX license identifiersLucie Gérard2022-06-221-49/+2
| | | | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I869ffda1080e283f231eb0dc4477b260f2054d99 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Remove duplicated 'downloadProgress' in favor of separate signalsKirill Burtsev2021-07-211-2/+2
| | | | | | Pick-to: 6.2 Change-Id: Ib825d63c89e591e740b206f43c3eadbf32319daa Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Rename QWebEngineDownloadItem -> QWebEngineDownloadRequestMichal Klocek2020-08-181-11/+11
| | | | | | | | | | This fits better with other QWebEngine*Requests. [ChangeLog] QWebEngineDownloadItem is now QWebEngineDownloadRequest, also in qml. Change-Id: I506e9fac746b4f23ac0936c2fbe1c7472f4fda36 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Remove QT_VERSION from simplebrowserMichal Klocek2020-08-141-4/+0
| | | | | | | | | | | | | | | | Since 468c2d9a6 it is possible to compile simplebrowser with older versions of webengine. Unfortunately it makes example code harder to read and follow. It affects user experience and does not provide any benefits for the user. Moreover, with Qt6 changes to api this would even look more ugly and complexity will grow over time. Keep example code simple and clean, remove all the QT_VERSION checks. Change-Id: I2b2ea1d11c1e59bdcbbc7351daae5308f23890d3 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix build of simplebrowser against 5.12Peter Varga2019-11-281-0/+4
| | | | | Change-Id: Ifbcf7f70ddbed7768e5e7b7231661a69d6d9f1a1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove usages of deprecated APIsSona Kurazyan2019-09-091-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | - Replaced the following deprecated APIs: QWebEngineProfile::setRequestInterceptor -> QWebEngineProfile::setUrlRequestInterceptor QWebEngineSettings::globalSettings -> WebEngineSettings::defaultSettings QLayout::setMargin -> QLayout::setContentsMargins QWheelEvent::{x, y} -> QWheelEvent::position QWheelEvent::{globalX, globalY} -> QWheelEvent::globalPosition QSysInfo::windowsVersion -> QOperatingSystemVersion::current Qt::InputMethodQuery::ImMicroFocus -> Qt::InputMethodQuery::ImCursorRectangle QDesktopWidget::screenGeometry -> QGuiApplication::primaryScreen::geometry QTime -> QElapsedTimer - Fixed the tests to compile when deprecated APIs are disabled. - Replaced the doc references to deprecated APIs with the new ones. Made the docs for deprecated APIs compile conditionally, based on deprecation version. Task-number: QTBUG-76491 Change-Id: I5c6b7c628957deb9163f0bd2b6bc31bde1c7daec Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add API to change download directory path and file nameTamas Zakor2019-07-051-1/+1
| | | | | | | | | | | | | | | | | | Add functions and property to change the download directory and file name in QWebEngineDownloadItem and QQuickWebEngineDownloadItem and deprecate the path() and setPath(). Regenerating the uniquifying download filename after change the download directory. [ChangeLog][DownloadItem] Add functions and property to change the download directory and file name in QWebEngineDownloadItem and QQuickWebEngineDownloadItem and deprecate the path() and setPath(). Task-number: QTBUG-56978 Change-Id: I6e63da82a187add8bc3206cc80c8bf6865fbdd35 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix license header for examplesKai Koehne2017-09-201-1/+11
| | | | | | Task-number: QTBUG-60006 Change-Id: Ie1604aed3d5a9ba566e898eae232227ba340bfaa Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix simplebrowser crash on exit while downloadingMichal Klocek2017-08-021-6/+2
| | | | | | | | | | | | | On webengine profile destruction all download items in progress are canceled. This triggered stateChanged of QWebEngineDownloadItem which called lambda function on already deleted object. Do not use lambda functions in this case. Change-Id: Ia1d359fe47204baa51f1380d1c3547c28550bc28 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
* Update Simple Browser exampleJüri Valdmann2017-07-191-0/+152
- Accept downloads and add a downloads list. - Fix toolbar icons being pixelated on hidpi screens by - enabling attribute AA_UseHighDpiPixmaps, and - replacing the 22x22 icons with 32x32 versions. - Move favicon selection to WebView to reduce duplication. - Replace UrlLineEdit with a standard QLineEdit using a QAction for the favicon and setClearButtonEnabled(true) for the clear button. - Fix bug where the "File -> New Tab" action would create background tabs because the QAction::triggered(bool) signal was connected to the TabWidget::createTab(bool) slot with the bool argument having a completely different meaning between the two. - Make the toolbar unmovable. Nobody wants to move the toolbar. - Add tooltips to toolbar buttons. - Add tooltips to the tab bar (page titles). - Stop adding icons to menu items only to disable them right after. Task-number: QTBUG-60655 Change-Id: I10cc0fa82dbf39281bbdbbf9ef901e1b26402f80 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-17 19:39:35 +0000